* [ANNOUNCE] xfsprogs for-next updated to 6f490d6
@ 2019-02-27 21:39 Eric Sandeen
2019-02-27 22:19 ` [ANNOUNCE] xfsprogs for-next updated to bb83d20 Eric Sandeen
0 siblings, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2019-02-27 21:39 UTC (permalink / raw)
To: linux-xfs
[-- Attachment #1.1: Type: text/plain, Size: 2680 bytes --]
Hi folks,
The xfsprogs repository at:
git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
has just been updated.
This contains only the sync to the kernel's libxfs updates for v5.0.
The new head of the for-next branch is commit:
6f490d6 xfs: stringify btree cursor types in ftrace output
New Commits:
Darrick J. Wong (11):
[5afb131] xfs: idiotproof defer op type configuration
[5a23b29] xfs: streamline defer op type handling
[c2d5dd0] xfs: const-ify xfs_owner_info arguments
[9ef0cb4] xfs: remove xfs_rmap_ag_owner and friends
[09c23f4] xfs: add a block to inode count converter
[c43dd96] xfs: precalculate inodes and blocks per inode cluster
[af22104] xfs: precalculate cluster alignment in inodes and blocks
[5ff3ed4] xfs: fix symbolic enum printing in ftrace output
[57a6c0e] xfs: move XFS_AG_BTREE_CMP_FORMAT_STR mappings to libxfs
[51e1848] xfs: move XFS_INODE_FORMAT_STR mappings to libxfs
[6f490d6] xfs: stringify btree cursor types in ftrace output
Dave Chinner (1):
[7ab21d5] xfs: zero length symlinks are not valid
Omar Sandoval (1):
[5dc4588] xfs: cache minimum realtime summary level
Pan Bian (1):
[972ca59] xfs: libxfs: move xfs_perag_put late
Code Diffstat:
db/check.c | 8 +-
db/convert.c | 4 +-
db/frag.c | 4 +-
db/io.c | 2 +-
db/metadump.c | 4 +-
include/xfs_mount.h | 11 ++
include/xfs_trans.h | 5 -
libxfs/defer_item.c | 44 +-------
libxfs/init.c | 16 +--
libxfs/libxfs_api_defs.h | 1 -
libxfs/xfs_ag.c | 9 +-
libxfs/xfs_alloc.c | 79 +++++++--------
libxfs/xfs_alloc.h | 4 +-
libxfs/xfs_bmap.c | 6 +-
libxfs/xfs_bmap.h | 4 +-
libxfs/xfs_defer.c | 67 +++++++------
libxfs/xfs_defer.h | 37 +++----
libxfs/xfs_format.h | 12 +++
libxfs/xfs_ialloc.c | 56 +++++------
libxfs/xfs_ialloc_btree.c | 7 +-
libxfs/xfs_refcount_btree.c | 6 +-
libxfs/xfs_rmap.c | 240 +++++++++++++++++++++++++-------------------
libxfs/xfs_rmap.h | 54 ++++------
libxfs/xfs_rtbitmap.c | 6 ++
libxfs/xfs_symlink_remote.c | 14 ++-
libxfs/xfs_types.c | 9 +-
libxfs/xfs_types.h | 22 ++++
repair/dino_chunks.c | 12 +--
repair/phase5.c | 4 +-
repair/rmap.c | 5 +-
repair/xfs_repair.c | 13 ++-
31 files changed, 393 insertions(+), 372 deletions(-)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [ANNOUNCE] xfsprogs for-next updated to bb83d20 2019-02-27 21:39 [ANNOUNCE] xfsprogs for-next updated to 6f490d6 Eric Sandeen @ 2019-02-27 22:19 ` Eric Sandeen 2019-02-27 23:03 ` Darrick J. Wong 0 siblings, 1 reply; 4+ messages in thread From: Eric Sandeen @ 2019-02-27 22:19 UTC (permalink / raw) To: linux-xfs [-- Attachment #1.1: Type: text/plain, Size: 1518 bytes --] On 2/27/19 3:39 PM, Eric Sandeen wrote: > Hi folks, > > The xfsprogs repository at: > > git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git > > has just been updated. > > This contains only the sync to the kernel's libxfs updates for v5.0. > > The new head of the for-next branch is commit: Fixed a thinko stray ; caught by coverity and did a forced push on these branches right quick before anyone but djwong pulled it down. ;) Now we're at: bb83d20 xfs: stringify btree cursor types in ftrace output New Commits: Darrick J. Wong (11): [5afb131] xfs: idiotproof defer op type configuration [5a23b29] xfs: streamline defer op type handling [c2d5dd0] xfs: const-ify xfs_owner_info arguments [9ef0cb4] xfs: remove xfs_rmap_ag_owner and friends [09c23f4] xfs: add a block to inode count converter [ad5eff9] xfs: precalculate inodes and blocks per inode cluster [6180d69] xfs: precalculate cluster alignment in inodes and blocks [ef1b0a2] xfs: fix symbolic enum printing in ftrace output [a97fc90] xfs: move XFS_AG_BTREE_CMP_FORMAT_STR mappings to libxfs [e01dc40] xfs: move XFS_INODE_FORMAT_STR mappings to libxfs [bb83d20] xfs: stringify btree cursor types in ftrace output Dave Chinner (1): [7ab21d5] xfs: zero length symlinks are not valid Omar Sandoval (1): [6890a4c] xfs: cache minimum realtime summary level Pan Bian (1): [972ca59] xfs: libxfs: move xfs_perag_put late [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 873 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ANNOUNCE] xfsprogs for-next updated to bb83d20 2019-02-27 22:19 ` [ANNOUNCE] xfsprogs for-next updated to bb83d20 Eric Sandeen @ 2019-02-27 23:03 ` Darrick J. Wong 2019-02-27 23:11 ` Eric Sandeen 0 siblings, 1 reply; 4+ messages in thread From: Darrick J. Wong @ 2019-02-27 23:03 UTC (permalink / raw) To: Eric Sandeen; +Cc: linux-xfs On Wed, Feb 27, 2019 at 04:19:03PM -0600, Eric Sandeen wrote: > On 2/27/19 3:39 PM, Eric Sandeen wrote: > > Hi folks, > > > > The xfsprogs repository at: > > > > git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git > > > > has just been updated. > > > > This contains only the sync to the kernel's libxfs updates for v5.0. > > > > The new head of the for-next branch is commit: > > Fixed a thinko stray ; caught by coverity and did a forced push on > these branches right quick before anyone but djwong pulled it down. ;) Hmmm, I still some discrepancies... diff -Naurp xfsprogs/libxfs/xfs_ialloc.c kernel/libxfs/xfs_ialloc.c --- xfsprogs/libxfs/xfs_ialloc.c 2019-02-27 14:58:30.286319523 -0800 +++ kernel/libxfs/xfs_ialloc.c 2019-02-27 14:58:48.512355119 -0800 @@ -34,7 +34,7 @@ xfs_ialloc_cluster_alignment( struct xfs_mount *mp) { if (xfs_sb_version_hasalign(&mp->m_sb) && - mp->m_sb.sb_inoalignmt >= mp->m_blocks_per_cluster) + mp->m_sb.sb_inoalignmt >= xfs_icluster_size_fsb(mp)) return mp->m_sb.sb_inoalignmt; return 1; } Over on the kernel side we're still using xfs_icluster_size_fsb in the comparison test. TBH I don't remember whether this is actually required on the kernel side or not, but in any case this ought to go through the kernel. I /think/ the reason is that I didn't want the initializer functions for the xfs_mount inode goemetry fields to depend on them being set in any particular order. diff -Naurp xfsprogs/libxfs/xfs_types.h kernel/libxfs/xfs_types.h --- xfsprogs/libxfs/xfs_types.h 2019-02-27 14:58:30.287319525 -0800 +++ kernel/libxfs/xfs_types.h 2019-02-27 14:58:48.516355127 -0800 @@ -114,8 +114,8 @@ typedef enum { { XFS_LOOKUP_GEi, "ge" } /* - * This enum is used in string mapping in xfs_trace.h; please keep the - * TRACE_DEFINE_ENUMs for it up to date. + * This enum is used in string mapping in xfs_trace.h and scrub/trace.h; + * please keep the TRACE_DEFINE_ENUMs for it up to date. */ typedef enum { XFS_BTNUM_BNOi, XFS_BTNUM_CNTi, XFS_BTNUM_RMAPi, XFS_BTNUM_BMAPi, I think you're missing "xfs: stringify scrub types in ftrace output". --D > Now we're at: > > bb83d20 xfs: stringify btree cursor types in ftrace output > > New Commits: > > Darrick J. Wong (11): > [5afb131] xfs: idiotproof defer op type configuration > [5a23b29] xfs: streamline defer op type handling > [c2d5dd0] xfs: const-ify xfs_owner_info arguments > [9ef0cb4] xfs: remove xfs_rmap_ag_owner and friends > [09c23f4] xfs: add a block to inode count converter > [ad5eff9] xfs: precalculate inodes and blocks per inode cluster > [6180d69] xfs: precalculate cluster alignment in inodes and blocks > [ef1b0a2] xfs: fix symbolic enum printing in ftrace output > [a97fc90] xfs: move XFS_AG_BTREE_CMP_FORMAT_STR mappings to libxfs > [e01dc40] xfs: move XFS_INODE_FORMAT_STR mappings to libxfs > [bb83d20] xfs: stringify btree cursor types in ftrace output > > Dave Chinner (1): > [7ab21d5] xfs: zero length symlinks are not valid > > Omar Sandoval (1): > [6890a4c] xfs: cache minimum realtime summary level > > Pan Bian (1): > [972ca59] xfs: libxfs: move xfs_perag_put late > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ANNOUNCE] xfsprogs for-next updated to bb83d20 2019-02-27 23:03 ` Darrick J. Wong @ 2019-02-27 23:11 ` Eric Sandeen 0 siblings, 0 replies; 4+ messages in thread From: Eric Sandeen @ 2019-02-27 23:11 UTC (permalink / raw) To: Darrick J. Wong; +Cc: linux-xfs On 2/27/19 5:03 PM, Darrick J. Wong wrote: > On Wed, Feb 27, 2019 at 04:19:03PM -0600, Eric Sandeen wrote: >> On 2/27/19 3:39 PM, Eric Sandeen wrote: >>> Hi folks, >>> >>> The xfsprogs repository at: >>> >>> git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git >>> >>> has just been updated. >>> >>> This contains only the sync to the kernel's libxfs updates for v5.0. >>> >>> The new head of the for-next branch is commit: >> >> Fixed a thinko stray ; caught by coverity and did a forced push on >> these branches right quick before anyone but djwong pulled it down. ;) > > Hmmm, I still some discrepancies... > > diff -Naurp xfsprogs/libxfs/xfs_ialloc.c kernel/libxfs/xfs_ialloc.c > --- xfsprogs/libxfs/xfs_ialloc.c 2019-02-27 14:58:30.286319523 -0800 > +++ kernel/libxfs/xfs_ialloc.c 2019-02-27 14:58:48.512355119 -0800 > @@ -34,7 +34,7 @@ xfs_ialloc_cluster_alignment( > struct xfs_mount *mp) > { > if (xfs_sb_version_hasalign(&mp->m_sb) && > - mp->m_sb.sb_inoalignmt >= mp->m_blocks_per_cluster) > + mp->m_sb.sb_inoalignmt >= xfs_icluster_size_fsb(mp)) > return mp->m_sb.sb_inoalignmt; > return 1; > } > > > Over on the kernel side we're still using xfs_icluster_size_fsb in the > comparison test. TBH I don't remember whether this is actually required > on the kernel side or not, but in any case this ought to go through the > kernel. That was a mistake, I was searching for direct users of xfs_icluster_size_fsb elsewhere and converting them to the precalculated value, and accidentally hit libxfs. I can change it back. > I /think/ the reason is that I didn't want the initializer functions for > the xfs_mount inode goemetry fields to depend on them being set in any > particular order. I'll fix it regardless. > > > diff -Naurp xfsprogs/libxfs/xfs_types.h kernel/libxfs/xfs_types.h > --- xfsprogs/libxfs/xfs_types.h 2019-02-27 14:58:30.287319525 -0800 > +++ kernel/libxfs/xfs_types.h 2019-02-27 14:58:48.516355127 -0800 > @@ -114,8 +114,8 @@ typedef enum { > { XFS_LOOKUP_GEi, "ge" } > > /* > - * This enum is used in string mapping in xfs_trace.h; please keep the > - * TRACE_DEFINE_ENUMs for it up to date. > + * This enum is used in string mapping in xfs_trace.h and scrub/trace.h; > + * please keep the TRACE_DEFINE_ENUMs for it up to date. > */ > typedef enum { > XFS_BTNUM_BNOi, XFS_BTNUM_CNTi, XFS_BTNUM_RMAPi, XFS_BTNUM_BMAPi, > > I think you're missing "xfs: stringify scrub types in ftrace output". forgot to guilt push it on prior to the re-push. :/ > > --D > >> Now we're at: >> >> bb83d20 xfs: stringify btree cursor types in ftrace output >> >> New Commits: >> >> Darrick J. Wong (11): >> [5afb131] xfs: idiotproof defer op type configuration >> [5a23b29] xfs: streamline defer op type handling >> [c2d5dd0] xfs: const-ify xfs_owner_info arguments >> [9ef0cb4] xfs: remove xfs_rmap_ag_owner and friends >> [09c23f4] xfs: add a block to inode count converter >> [ad5eff9] xfs: precalculate inodes and blocks per inode cluster >> [6180d69] xfs: precalculate cluster alignment in inodes and blocks >> [ef1b0a2] xfs: fix symbolic enum printing in ftrace output >> [a97fc90] xfs: move XFS_AG_BTREE_CMP_FORMAT_STR mappings to libxfs >> [e01dc40] xfs: move XFS_INODE_FORMAT_STR mappings to libxfs >> [bb83d20] xfs: stringify btree cursor types in ftrace output >> >> Dave Chinner (1): >> [7ab21d5] xfs: zero length symlinks are not valid >> >> Omar Sandoval (1): >> [6890a4c] xfs: cache minimum realtime summary level >> >> Pan Bian (1): >> [972ca59] xfs: libxfs: move xfs_perag_put late >> >> > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-27 23:11 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-02-27 21:39 [ANNOUNCE] xfsprogs for-next updated to 6f490d6 Eric Sandeen 2019-02-27 22:19 ` [ANNOUNCE] xfsprogs for-next updated to bb83d20 Eric Sandeen 2019-02-27 23:03 ` Darrick J. Wong 2019-02-27 23:11 ` Eric Sandeen
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.