From: Sam Ravnborg <sam@ravnborg.org>
To: Claudiu.Beznea@microchip.com
Cc: lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com,
Ludovic.Desroches@microchip.com, bbrezillon@kernel.org,
airlied@linux.ie, daniel@ffwll.ch, thierry.reding@gmail.com,
devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/7] drm: atmel-hlcdc: avoid initializing cfg with zero
Date: Thu, 28 Feb 2019 22:41:21 +0100 [thread overview]
Message-ID: <20190228214121.GD30188@ravnborg.org> (raw)
In-Reply-To: <1551284609-14594-3-git-send-email-claudiu.beznea@microchip.com>
On Wed, Feb 27, 2019 at 04:24:21PM +0000, Claudiu.Beznea@microchip.com wrote:
> From: Claudiu Beznea <claudiu.beznea@microchip.com>
>
> Remove cfg initialization with zero and read state with
> drm_crtc_state_to_atmel_hlcdc_crtc_state() so that cfg to be initialized
> with state's output_mode.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Looks good, good to have simpler code.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Claudiu.Beznea@microchip.com
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alexandre.belloni@bootlin.com, bbrezillon@kernel.org,
airlied@linux.ie, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com,
robh+dt@kernel.org, thierry.reding@gmail.com,
dri-devel@lists.freedesktop.org, daniel@ffwll.ch,
lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/7] drm: atmel-hlcdc: avoid initializing cfg with zero
Date: Thu, 28 Feb 2019 22:41:21 +0100 [thread overview]
Message-ID: <20190228214121.GD30188@ravnborg.org> (raw)
In-Reply-To: <1551284609-14594-3-git-send-email-claudiu.beznea@microchip.com>
On Wed, Feb 27, 2019 at 04:24:21PM +0000, Claudiu.Beznea@microchip.com wrote:
> From: Claudiu Beznea <claudiu.beznea@microchip.com>
>
> Remove cfg initialization with zero and read state with
> drm_crtc_state_to_atmel_hlcdc_crtc_state() so that cfg to be initialized
> with state's output_mode.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Looks good, good to have simpler code.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-28 21:41 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 16:24 [PATCH 0/7] add LCD support for SAM9X60 Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-27 16:24 ` [PATCH 1/7] drm: atmel-hlcdc: add config option for clock selection Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-28 21:25 ` Sam Ravnborg
2019-02-28 21:25 ` Sam Ravnborg
2019-03-01 10:07 ` Claudiu.Beznea
2019-03-01 10:07 ` Claudiu.Beznea
2019-03-01 10:07 ` Claudiu.Beznea
2019-02-28 21:38 ` Sam Ravnborg
2019-02-28 21:38 ` Sam Ravnborg
2019-03-01 10:06 ` Claudiu.Beznea
2019-03-01 10:06 ` Claudiu.Beznea
2019-03-01 10:06 ` Claudiu.Beznea
2019-02-27 16:24 ` [PATCH 2/7] drm: atmel-hlcdc: avoid initializing cfg with zero Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-28 21:41 ` Sam Ravnborg [this message]
2019-02-28 21:41 ` Sam Ravnborg
2019-02-27 16:24 ` [PATCH 3/7] dt-bindings: mfd: add bindings for SAM9X60 HLCD controller Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-27 16:24 ` [PATCH 4/7] mfd: atmel-hlcdc: add compatible " Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-27 16:24 ` [PATCH 5/7] pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-03-04 11:05 ` Thierry Reding
2019-03-04 11:05 ` Thierry Reding
2019-03-04 11:05 ` Thierry Reding
2019-02-27 16:24 ` [PATCH 6/7] drm: atmel-hlcdc: enable sys_clk during initalization Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-28 21:55 ` Sam Ravnborg
2019-02-28 21:55 ` Sam Ravnborg
2019-03-01 10:07 ` Claudiu.Beznea
2019-03-01 10:07 ` Claudiu.Beznea
2019-03-01 10:07 ` Claudiu.Beznea
2019-02-27 16:24 ` [PATCH 7/7] drm: atmel-hlcdc: add sam9x60 LCD controller Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-27 16:24 ` Claudiu.Beznea
2019-02-28 18:21 ` [PATCH 0/7] add LCD support for SAM9X60 Sam Ravnborg
2019-02-28 18:21 ` Sam Ravnborg
2019-02-28 18:21 ` Sam Ravnborg
2019-02-28 20:52 ` Alexandre Belloni
2019-02-28 20:52 ` Alexandre Belloni
2019-02-28 21:13 ` Sam Ravnborg
2019-02-28 21:13 ` Sam Ravnborg
2019-02-28 21:13 ` Sam Ravnborg
2019-03-01 10:09 ` Claudiu.Beznea
2019-03-01 10:09 ` Claudiu.Beznea
2019-03-01 10:09 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228214121.GD30188@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Claudiu.Beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=airlied@linux.ie \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.