* [v3 0/2] Add SPDX license
@ 2019-03-01 0:14 Jules Irenge
2019-03-01 0:14 ` [v3 1/2] staging: mt7621-eth: Add SPDX license identifier Jules Irenge
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jules Irenge @ 2019-03-01 0:14 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
This patch series adds SPDX license identifier to fix missing and
malformed warning reported by checkpatch.pl tool
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
The patch then removes unnecessary license boilerplates.
Now that we have the spdx specified, the license text is not necessary.
v3:
[PATCH 1/2]:Commit log corrected, commit message clearer
Jules Irenge (2):
staging: mt7621-eth: Add SPDX license identifier
staging: mt7621-eth: Remove license boilerplate text
drivers/staging/mt7621-eth/ethtool.h | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [v3 1/2] staging: mt7621-eth: Add SPDX license identifier
2019-03-01 0:14 [v3 0/2] Add SPDX license Jules Irenge
@ 2019-03-01 0:14 ` Jules Irenge
2019-03-01 7:59 ` Greg KH
2019-03-01 0:14 ` [v3 2/2] staging: mt7621-eth: Remove license boilerplate text Jules Irenge
2019-03-01 7:59 ` [v3 0/2] Add SPDX license Greg KH
2 siblings, 1 reply; 5+ messages in thread
From: Jules Irenge @ 2019-03-01 0:14 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Add the SPDX GPL-2.0 license identifier to fix checkpatch.pl warning
Issue reported by checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/mt7621-eth/ethtool.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/mt7621-eth/ethtool.h b/drivers/staging/mt7621-eth/ethtool.h
index 40b4cf011660..d0e97ae0d82e 100644
--- a/drivers/staging/mt7621-eth/ethtool.h
+++ b/drivers/staging/mt7621-eth/ethtool.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [v3 2/2] staging: mt7621-eth: Remove license boilerplate text
2019-03-01 0:14 [v3 0/2] Add SPDX license Jules Irenge
2019-03-01 0:14 ` [v3 1/2] staging: mt7621-eth: Add SPDX license identifier Jules Irenge
@ 2019-03-01 0:14 ` Jules Irenge
2019-03-01 7:59 ` [v3 0/2] Add SPDX license Greg KH
2 siblings, 0 replies; 5+ messages in thread
From: Jules Irenge @ 2019-03-01 0:14 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Removes license boilerplate text
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/mt7621-eth/ethtool.h | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/staging/mt7621-eth/ethtool.h b/drivers/staging/mt7621-eth/ethtool.h
index d0e97ae0d82e..0071469aea6c 100644
--- a/drivers/staging/mt7621-eth/ethtool.h
+++ b/drivers/staging/mt7621-eth/ethtool.h
@@ -1,13 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0 */
-/* This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
+/*
* Copyright (C) 2009-2016 John Crispin <blogic@openwrt.org>
* Copyright (C) 2009-2016 Felix Fietkau <nbd@openwrt.org>
* Copyright (C) 2013-2016 Michael Lee <igvtee@gmail.com>
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [v3 0/2] Add SPDX license
2019-03-01 0:14 [v3 0/2] Add SPDX license Jules Irenge
2019-03-01 0:14 ` [v3 1/2] staging: mt7621-eth: Add SPDX license identifier Jules Irenge
2019-03-01 0:14 ` [v3 2/2] staging: mt7621-eth: Remove license boilerplate text Jules Irenge
@ 2019-03-01 7:59 ` Greg KH
2 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2019-03-01 7:59 UTC (permalink / raw)
To: Jules Irenge; +Cc: outreachy-kernel
On Fri, Mar 01, 2019 at 12:14:15AM +0000, Jules Irenge wrote:
> This patch series adds SPDX license identifier to fix missing and
> malformed warning reported by checkpatch.pl tool
>
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
>
> The patch then removes unnecessary license boilerplates.
> Now that we have the spdx specified, the license text is not necessary.
>
> v3:
> [PATCH 1/2]:Commit log corrected, commit message clearer
Next time, the subject for this email should match the patch emails. It
should be something like:
Subject: [PATCH 0/2 v3] staging: mt7621-eth: SPDX license cleanups
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [v3 1/2] staging: mt7621-eth: Add SPDX license identifier
2019-03-01 0:14 ` [v3 1/2] staging: mt7621-eth: Add SPDX license identifier Jules Irenge
@ 2019-03-01 7:59 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2019-03-01 7:59 UTC (permalink / raw)
To: Jules Irenge; +Cc: outreachy-kernel
On Fri, Mar 01, 2019 at 12:14:16AM +0000, Jules Irenge wrote:
> Add the SPDX GPL-2.0 license identifier to fix checkpatch.pl warning
> Issue reported by checkpatch.pl warning:
> "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
This is fine, but where did the PATCH go in the subject line?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-01 7:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-01 0:14 [v3 0/2] Add SPDX license Jules Irenge
2019-03-01 0:14 ` [v3 1/2] staging: mt7621-eth: Add SPDX license identifier Jules Irenge
2019-03-01 7:59 ` Greg KH
2019-03-01 0:14 ` [v3 2/2] staging: mt7621-eth: Remove license boilerplate text Jules Irenge
2019-03-01 7:59 ` [v3 0/2] Add SPDX license Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.