* [PATCH] habanalabs: use do_div for 64-bit divisions
@ 2019-03-01 12:21 Oded Gabbay
0 siblings, 0 replies; only message in thread
From: Oded Gabbay @ 2019-03-01 12:21 UTC (permalink / raw)
To: gregkh, linux-kernel
This patch fix compilation error in 32-bit ARM architecture regarding
division of 2 64-bit variables.
Use the kernel do_div() macro, which is implemented per architecture, for
doing these divisions instead of using the / operator.
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
---
drivers/misc/habanalabs/mmu.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/misc/habanalabs/mmu.c b/drivers/misc/habanalabs/mmu.c
index ce404e6cc9a9..2f2e99cb2743 100644
--- a/drivers/misc/habanalabs/mmu.c
+++ b/drivers/misc/habanalabs/mmu.c
@@ -261,9 +261,9 @@ int hl_mmu_ctx_init(struct hl_ctx *ctx)
!hdev->dram_default_page_mapping)
return 0;
- num_of_hop3 = (prop->dram_size_for_default_page_mapping /
- prop->dram_page_size) /
- PTE_ENTRIES_IN_HOP;
+ num_of_hop3 = prop->dram_size_for_default_page_mapping;
+ do_div(num_of_hop3, prop->dram_page_size);
+ do_div(num_of_hop3, PTE_ENTRIES_IN_HOP);
/* add hop1 and hop2 */
total_hops = num_of_hop3 + 2;
@@ -378,9 +378,9 @@ void hl_mmu_ctx_fini(struct hl_ctx *ctx)
if (hdev->dram_supports_virtual_memory &&
hdev->dram_default_page_mapping) {
- num_of_hop3 = (prop->dram_size_for_default_page_mapping /
- prop->dram_page_size) /
- PTE_ENTRIES_IN_HOP;
+ num_of_hop3 = prop->dram_size_for_default_page_mapping;
+ do_div(num_of_hop3, prop->dram_page_size);
+ do_div(num_of_hop3, PTE_ENTRIES_IN_HOP);
/* add hop1 and hop2 */
total_hops = num_of_hop3 + 2;
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-03-01 12:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-01 12:21 [PATCH] habanalabs: use do_div for 64-bit divisions Oded Gabbay
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.