[PATCH 0/2] staging: mt7621-dma: SPDX license cleanups

[PATCH 0/2] staging: mt7621-dma: SPDX license cleanups

[Jules Irenge]

 This patch series adds SPDX license identifier to fix missing and
 malformed warning generated by checkpatch.pl tool 
 then removes unnecessary license boilerplates.
         Now that we have the spdx specified,
         the license text is not necessary.
 
Jules Irenge (2):
  staging: mt7621-dma: add SPDX GPL-2.0 or later version license
    identifier
  staging: mt7621-dma: remove license boilerplate text

 drivers/staging/mt7621-dma/mtk-hsdma.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

-- 
2.20.1

[PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier

[Jules Irenge]

Add SPDX GPL-2.0-or-later license to fix missing SPDX warning
 reported by checkpatch.pl.

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index d67a2504adb1..7d69586f23c0 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *  Copyright (C) 2015, Michael Lee <igvtee@gmail.com>
  *  MTK HSDMA support
-- 
2.20.1

Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier

[Greg KH]

On Fri, Mar 01, 2019 at 03:18:00PM +0000, Jules Irenge wrote:
> Add SPDX GPL-2.0-or-later license to fix missing SPDX warning
>  reported by checkpatch.pl.
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index d67a2504adb1..7d69586f23c0 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later

Shouldn't this be:

// SPDX-License-Identifier: GPL-2.0+

The "or later" is starting to get used, but I don't think it's all that
prelevant yet.  What did you read to decide to use that format instead
of the "+" format?

thanks,

greg k-h

Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier

[Jules Octave]

[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]

Some people say  GPL-2.0+ has deprecated (
https://www.drupal.org/project/lightning/issues/2938910 ) but I will
change it to GPL-2.0+.
I tried looking  on  https://spdx.org/licenses/

Kind regards,
*Jules*
*..*
BCS West Yorkshire Secretary
Positive action combined with positive thinking results in success - Shiv
Khera


On Fri, 1 Mar 2019 at 15:39, Greg KH <gregkh@linuxfoundation.org> wrote:

> On Fri, Mar 01, 2019 at 03:18:00PM +0000, Jules Irenge wrote:
> > Add SPDX GPL-2.0-or-later license to fix missing SPDX warning
> >  reported by checkpatch.pl.
> >
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> > ---
> >  drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c
> b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > index d67a2504adb1..7d69586f23c0 100644
> > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > @@ -1,3 +1,4 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
>
> Shouldn't this be:
>
> // SPDX-License-Identifier: GPL-2.0+
>
> The "or later" is starting to get used, but I don't think it's all that
> prelevant yet.  What did you read to decide to use that format instead
> of the "+" format?
>
> thanks,
>
> greg k-h
>

[-- Attachment #2: Type: text/html, Size: 2931 bytes --]

Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier

[Greg KH]

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?


http://daringfireball.net/2007/07/on_top

On Fri, Mar 01, 2019 at 05:38:58PM +0000, Jules Octave wrote:
> Some people say  GPL-2.0+ has deprecated (
> https://www.drupal.org/project/lightning/issues/2938910 ) but I will

That is drupal, not the kernel.

> change it to GPL-2.0+.
> I tried looking  on  https://spdx.org/licenses/

That's a nice place to read as well, but we are using an "older" version
of spdx.

Always read the in-kernel documentation, we write it for a reason :)

Look at Documentation/process/license-rules.rst please, it shows that
you should use the "GPL-2.0+" marking.

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier

[Jules Octave]

[-- Attachment #1: Type: text/plain, Size: 1764 bytes --]

Thanks . I have just changed it. I take good note.

*Jules*
*..*
BCS West Yorkshire Secretary
Positive action combined with positive thinking results in success - Shiv
Khera


On Fri, 1 Mar 2019 at 20:01, Greg KH <gregkh@linuxfoundation.org> wrote:

> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>
>
> http://daringfireball.net/2007/07/on_top
>
> On Fri, Mar 01, 2019 at 05:38:58PM +0000, Jules Octave wrote:
> > Some people say  GPL-2.0+ has deprecated (
> > https://www.drupal.org/project/lightning/issues/2938910 ) but I will
>
> That is drupal, not the kernel.
>
> > change it to GPL-2.0+.
> > I tried looking  on  https://spdx.org/licenses/
>
> That's a nice place to read as well, but we are using an "older" version
> of spdx.
>
> Always read the in-kernel documentation, we write it for a reason :)
>
> Look at Documentation/process/license-rules.rst please, it shows that
> you should use the "GPL-2.0+" marking.
>
> thanks,
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20190301200104.GA19353%40kroah.com
> .
> For more options, visit https://groups.google.com/d/optout.
>

[-- Attachment #2: Type: text/html, Size: 3870 bytes --]

Re: [Outreachy kernel] Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 2723 bytes --]



On Sat, 2 Mar 2019, Jules Octave wrote:

> Thanks . I have just changed it. I take good note.

Greg told you not to top post.  But you are top posting again.  Please
move down to the thing that you are responding to and put your response
right under it, like I have done in this message.

julia

>
> Jules
> ..
> BCS West Yorkshire Secretary
> Positive action combined with positive thinking results in success - Shiv Khera
>
>
> On Fri, 1 Mar 2019 at 20:01, Greg KH <gregkh@linuxfoundation.org> wrote:
>       A: http://en.wikipedia.org/wiki/Top_post
>       Q: Were do I find info about this thing called top-posting?
>       A: Because it messes up the order in which people normally read text.
>       Q: Why is top-posting such a bad thing?
>       A: Top-posting.
>       Q: What is the most annoying thing in e-mail?
>
>       A: No.
>       Q: Should I include quotations after my reply?
>
>
>       http://daringfireball.net/2007/07/on_top
>
>       On Fri, Mar 01, 2019 at 05:38:58PM +0000, Jules Octave wrote:
>       > Some people say  GPL-2.0+ has deprecated (
>       > https://www.drupal.org/project/lightning/issues/2938910 ) but I will
>
>       That is drupal, not the kernel.
>
>       > change it to GPL-2.0+.
>       > I tried looking  on  https://spdx.org/licenses/
>
>       That's a nice place to read as well, but we are using an "older" version
>       of spdx.
>
>       Always read the in-kernel documentation, we write it for a reason :)
>
>       Look at Documentation/process/license-rules.rst please, it shows that
>       you should use the "GPL-2.0+" marking.
>
>       thanks,
>
>       greg k-h
>
>       --
>       You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>       To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>       To post to this group, send email to outreachy-kernel@googlegroups.com.
>       To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190301200104.GA19353%40kroah.com.
>       For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAOuULM6csFS6UCZMfefDZhOdraTspMBKrXT5JiL3Gi2EOqAyXw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [Outreachy kernel] Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier

[Jules Octave]

[-- Attachment #1: Type: text/plain, Size: 3128 bytes --]

Apology, I did not  see that. I will change.

*Jules*
*..*
BCS West Yorkshire Secretary
Positive action combined with positive thinking results in success - Shiv
Khera


On Sat, 2 Mar 2019 at 06:30, Julia Lawall <julia.lawall@lip6.fr> wrote:

>
>
> On Sat, 2 Mar 2019, Jules Octave wrote:
>
> > Thanks . I have just changed it. I take good note.
>
> Greg told you not to top post.  But you are top posting again.  Please
> move down to the thing that you are responding to and put your response
> right under it, like I have done in this message.
>
> julia
>
> >
> > Jules
> > ..
> > BCS West Yorkshire Secretary
> > Positive action combined with positive thinking results in success -
> Shiv Khera
> >
> >
> > On Fri, 1 Mar 2019 at 20:01, Greg KH <gregkh@linuxfoundation.org> wrote:
> >       A: http://en.wikipedia.org/wiki/Top_post
> >       Q: Were do I find info about this thing called top-posting?
> >       A: Because it messes up the order in which people normally read
> text.
> >       Q: Why is top-posting such a bad thing?
> >       A: Top-posting.
> >       Q: What is the most annoying thing in e-mail?
> >
> >       A: No.
> >       Q: Should I include quotations after my reply?
> >
> >
> >       http://daringfireball.net/2007/07/on_top
> >
> >       On Fri, Mar 01, 2019 at 05:38:58PM +0000, Jules Octave wrote:
> >       > Some people say  GPL-2.0+ has deprecated (
> >       > https://www.drupal.org/project/lightning/issues/2938910 ) but I
> will
> >
> >       That is drupal, not the kernel.
> >
> >       > change it to GPL-2.0+.
> >       > I tried looking  on  https://spdx.org/licenses/
> >
> >       That's a nice place to read as well, but we are using an "older"
> version
> >       of spdx.
> >
> >       Always read the in-kernel documentation, we write it for a reason
> :)
> >
> >       Look at Documentation/process/license-rules.rst please, it shows
> that
> >       you should use the "GPL-2.0+" marking.
> >
> >       thanks,
> >
> >       greg k-h
> >
> >       --
> >       You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> >       To unsubscribe from this group and stop receiving emails from it,
> send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >       To post to this group, send email to
> outreachy-kernel@googlegroups.com.
> >       To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20190301200104.GA19353%40kroah.com
> .
> >       For more options, visit https://groups.google.com/d/optout.
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/CAOuULM6csFS6UCZMfefDZhOdraTspMBKrXT5JiL3Gi2EOqAyXw%40mail.gmail.com
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
> >

[-- Attachment #2: Type: text/html, Size: 6045 bytes --]

Re: [Outreachy kernel] Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 3934 bytes --]



On Sat, 2 Mar 2019, Jules Octave wrote:

> Apology, I did not  see that. I will change.

This is top posting again.  No mail sent to the mailing list should
involve top posting.

julia

>
> Jules
> ..
> BCS West Yorkshire Secretary
> Positive action combined with positive thinking results in success - Shiv
> Khera
>
>
> On Sat, 2 Mar 2019 at 06:30, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>       On Sat, 2 Mar 2019, Jules Octave wrote:
>
>       > Thanks . I have just changed it. I take good note.
>
>       Greg told you not to top post.  But you are top posting again. 
>       Please
>       move down to the thing that you are responding to and put your
>       response
>       right under it, like I have done in this message.
>
>       julia
>
>       >
>       > Jules
>       > ..
>       > BCS West Yorkshire Secretary
>       > Positive action combined with positive thinking results in
>       success - Shiv Khera
>       >
>       >
>       > On Fri, 1 Mar 2019 at 20:01, Greg KH
>       <gregkh@linuxfoundation.org> wrote:
>       >       A: http://en.wikipedia.org/wiki/Top_post
>       >       Q: Were do I find info about this thing called
>       top-posting?
>       >       A: Because it messes up the order in which people
>       normally read text.
>       >       Q: Why is top-posting such a bad thing?
>       >       A: Top-posting.
>       >       Q: What is the most annoying thing in e-mail?
>       >
>       >       A: No.
>       >       Q: Should I include quotations after my reply?
>       >
>       >
>       >       http://daringfireball.net/2007/07/on_top
>       >
>       >       On Fri, Mar 01, 2019 at 05:38:58PM +0000, Jules Octave
>       wrote:
>       >       > Some people say  GPL-2.0+ has deprecated (
>       >       >
>       https://www.drupal.org/project/lightning/issues/2938910 ) but I
>       will
>       >
>       >       That is drupal, not the kernel.
>       >
>       >       > change it to GPL-2.0+.
>       >       > I tried looking  on  https://spdx.org/licenses/
>       >
>       >       That's a nice place to read as well, but we are using an
>       "older" version
>       >       of spdx.
>       >
>       >       Always read the in-kernel documentation, we write it for
>       a reason :)
>       >
>       >       Look at Documentation/process/license-rules.rst please,
>       it shows that
>       >       you should use the "GPL-2.0+" marking.
>       >
>       >       thanks,
>       >
>       >       greg k-h
>       >
>       >       --
>       >       You received this message because you are subscribed to
>       the Google Groups "outreachy-kernel" group.
>       >       To unsubscribe from this group and stop receiving emails
>       from it, send an email to
>       outreachy-kernel+unsubscribe@googlegroups.com.
>       >       To post to this group, send email to
>       outreachy-kernel@googlegroups.com.
>       >       To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20190301200104.GA19353%4
>       0kroah.com.
>       >       For more options, visit
>       https://groups.google.com/d/optout.
>       >
>       > --
>       > You received this message because you are subscribed to the
>       Google Groups "outreachy-kernel" group.
>       > To unsubscribe from this group and stop receiving emails from
>       it, send an email to
>       outreachy-kernel+unsubscribe@googlegroups.com.
>       > To post to this group, send email to
>       outreachy-kernel@googlegroups.com.
>       > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAOuULM6csFS6UCZMfefDZhO
>       draTspMBKrXT5JiL3Gi2EOqAyXw%40mail.gmail.com.
>       > For more options, visit https://groups.google.com/d/optout.
>       >
>       >
>
>
>

[PATCH 2/2] staging: mt7621-dma: remove license boilerplate text

[Jules Irenge]

Removes license boilerplate text

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index 7d69586f23c0..4e8190a59cf2 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -1,13 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *  Copyright (C) 2015, Michael Lee <igvtee@gmail.com>
- *  MTK HSDMA support
- *
- *  This program is free software; you can redistribute it and/or modify it
- *  under  the terms of the GNU General	 Public License as published by the
- *  Free Software Foundation;  either version 2 of the License, or (at your
- *  option) any later version.
- *
  */
 
 #include <linux/dmaengine.h>
-- 
2.20.1