[PATCH 0/2] staging: mt7621-dma: SPDX license cleanups

[PATCH 0/2] staging: mt7621-dma: SPDX license cleanups

[Jules Irenge]

 This patch series adds SPDX license identifier to fix missing and
 malformed warning generated by checkpatch.pl tool 
 then removes unnecessary license boilerplates.
         Now that we have the spdx specified,
         the license text is not necessary.

Jules Irenge (2):
  staging: mt7621-dma: add SPDX GPL-2.0+ license identifier
  staging: mt7621-dma: Remove license boilerplate text

 drivers/staging/mt7621-dma/mtk-hsdma.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

-- 
2.20.1

[PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0+ license identifier

[Jules Irenge]

Add SPDX GPL-2.0+ to fix missing SPDX warning
 reported by checkpatch.pl.

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index d67a2504adb1..7d69586f23c0 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *  Copyright (C) 2015, Michael Lee <igvtee@gmail.com>
  *  MTK HSDMA support
-- 
2.20.1

Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0+ license identifier

[Greg KH]

On Sat, Mar 02, 2019 at 12:11:14AM +0000, Jules Irenge wrote:
> Add SPDX GPL-2.0+ to fix missing SPDX warning
>  reported by checkpatch.pl.
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index d67a2504adb1..7d69586f23c0 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later

Are you sure you changed the identifer to match what said above in your
changelog?  :(

Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0+ license identifier

[Jules Octave]

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

On Sat, 2 Mar 2019 at 07:45, Greg KH <gregkh@linuxfoundation.org> wrote:

> On Sat, Mar 02, 2019 at 12:11:14AM +0000, Jules Irenge wrote:
> > Add SPDX GPL-2.0+ to fix missing SPDX warning
> >  reported by checkpatch.pl.
> >
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> > ---
> >  drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c
> b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > index d67a2504adb1..7d69586f23c0 100644
> > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > @@ -1,3 +1,4 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
>
> >Are you sure you changed the identifer to match what said above in your
> >changelog?  :(
>
> Apology,
I had two kernels git ; a back up and one that I work in . I mixed them. It
will not happen again.
Kind regards

[-- Attachment #2: Type: text/html, Size: 1519 bytes --]

[PATCH 2/2] staging: mt7621-dma: Remove license boilerplate text

[Jules Irenge]

Removes license boilerplate text

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index 7d69586f23c0..e4a522f3b448 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -2,12 +2,6 @@
 /*
  *  Copyright (C) 2015, Michael Lee <igvtee@gmail.com>
  *  MTK HSDMA support
- *
- *  This program is free software; you can redistribute it and/or modify it
- *  under  the terms of the GNU General	 Public License as published by the
- *  Free Software Foundation;  either version 2 of the License, or (at your
- *  option) any later version.
- *
  */
 
 #include <linux/dmaengine.h>
-- 
2.20.1

Re: [Outreachy kernel] [PATCH 2/2] staging: mt7621-dma: Remove license boilerplate text

[Julia Lawall]

On Sat, 2 Mar 2019, Jules Irenge wrote:

> Removes license boilerplate text

The log message should be in the imperative.  No "s" at the end of the
verb.

Please put a period at the end of the sentence.

The log message should explain why you are removing it, ie it is redundant
now that there is the SPDX identifier.

julia

>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index 7d69586f23c0..e4a522f3b448 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -2,12 +2,6 @@
>  /*
>   *  Copyright (C) 2015, Michael Lee <igvtee@gmail.com>
>   *  MTK HSDMA support
> - *
> - *  This program is free software; you can redistribute it and/or modify it
> - *  under  the terms of the GNU General	 Public License as published by the
> - *  Free Software Foundation;  either version 2 of the License, or (at your
> - *  option) any later version.
> - *
>   */
>
>  #include <linux/dmaengine.h>
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190302001115.20477-3-jbi.octave%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH 2/2] staging: mt7621-dma: Remove license boilerplate text

[Jules Octave]

[-- Attachment #1: Type: text/plain, Size: 1885 bytes --]

On Sat, 2 Mar 2019 at 06:32, Julia Lawall <julia.lawall@lip6.fr> wrote:

>
>
> On Sat, 2 Mar 2019, Jules Irenge wrote:
>
> > Removes license boilerplate text
>
> The log message should be in the imperative.  No "s" at the end of the
> verb.
>
> Please put a period at the end of the sentence.
>
> The log message should explain why you are removing it, ie it is redundant
> now that there is the SPDX identifier.
>
> julia
>
> >
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> > ---
> >  drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ------
> >  1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c
> b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > index 7d69586f23c0..e4a522f3b448 100644
> > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > @@ -2,12 +2,6 @@
> >  /*
> >   *  Copyright (C) 2015, Michael Lee <igvtee@gmail.com>
> >   *  MTK HSDMA support
> > - *
> > - *  This program is free software; you can redistribute it and/or
> modify it
> > - *  under  the terms of the GNU General       Public License as
> published by the
> > - *  Free Software Foundation;  either version 2 of the License, or (at
> your
> > - *  option) any later version.
> > - *
> >   */
> >
> >  #include <linux/dmaengine.h>
> > --
> > 2.20.1
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20190302001115.20477-3-jbi.octave%40gmail.com
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
>

I will do so. Thanks.

[-- Attachment #2: Type: text/html, Size: 2985 bytes --]

Re: [Outreachy kernel] [PATCH 2/2] staging: mt7621-dma: Remove license boilerplate text

[Jules Octave]

[-- Attachment #1: Type: text/plain, Size: 2711 bytes --]

On Sat, 2 Mar 2019 at 08:36, Julia Lawall <julia.lawall@lip6.fr> wrote:

>
>
> On Sat, 2 Mar 2019, Jules Octave wrote:
>
> > On Sat, 2 Mar 2019 at 06:32, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> >
> >       On Sat, 2 Mar 2019, Jules Irenge wrote:
> >
> >       > Removes license boilerplate text
> >
> >       The log message should be in the imperative.  No "s" at the end
> >       of the
> >       verb.
> >
> >       Please put a period at the end of the sentence.
> >
> >       The log message should explain why you are removing it, ie it is
> >       redundant
> >       now that there is the SPDX identifier.
> >
> >       julia
> >
> >       >
> >       > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> >       > ---
> >       >  drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ------
> >       >  1 file changed, 6 deletions(-)
> >       >
> >       > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c
> >       b/drivers/staging/mt7621-dma/mtk-hsdma.c
> >       > index 7d69586f23c0..e4a522f3b448 100644
> >       > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> >       > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> >       > @@ -2,12 +2,6 @@
> >       >  /*
> >       >   *  Copyright (C) 2015, Michael Lee <igvtee@gmail.com>
> >       >   *  MTK HSDMA support
> >       > - *
> >       > - *  This program is free software; you can redistribute it
> >       and/or modify it
> >       > - *  under  the terms of the GNU General       Public License
> >       as published by the
> >       > - *  Free Software Foundation;  either version 2 of the
> >       License, or (at your
> >       > - *  option) any later version.
> >       > - *
> >       >   */
> >       >
> >       >  #include <linux/dmaengine.h>
> >       > --
> >       > 2.20.1
> >       >
> >       > --
> >       > You received this message because you are subscribed to the
> >       Google Groups "outreachy-kernel" group.
> >       > To unsubscribe from this group and stop receiving emails from
> >       it, send an email to
> >       outreachy-kernel+unsubscribe@googlegroups.com.
> >       > To post to this group, send email to
> >       outreachy-kernel@googlegroups.com.
> >       > To view this discussion on the web visithttps://
> groups.google.com/d/msgid/outreachy-kernel/20190302001115.20477-3-j
> >       bi.octave%40gmail.com.
> >       > For more options, visit https://groups.google.com/d/optout.
> >       >
> >
> >
> > I will do so. Thanks.
>
> >This is not the ideal place for comments either.  The response just be
> >right under the text you are responding to.  You aren't responding to
>
> >For more options, visit https://groups.google.com/d/optout.
>
> >julia


Thanks. I take good note.

[-- Attachment #2: Type: text/html, Size: 4544 bytes --]

Re: [Outreachy kernel] [PATCH 0/2] staging: mt7621-dma: SPDX license cleanups

[Julia Lawall]

On Sat, 2 Mar 2019, Jules Irenge wrote:

>  This patch series adds SPDX license identifier to fix missing and
>  malformed warning generated by checkpatch.pl tool
>  then removes unnecessary license boilerplates.
>          Now that we have the spdx specified,
>          the license text is not necessary.

This justification is fine, but it should be in the patch, not the cover
letter.  The cover letter is just for the recipients of the patch series.
It will not be included in the git history.

julia

>
> Jules Irenge (2):
>   staging: mt7621-dma: add SPDX GPL-2.0+ license identifier
>   staging: mt7621-dma: Remove license boilerplate text
>
>  drivers/staging/mt7621-dma/mtk-hsdma.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190302001115.20477-1-jbi.octave%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>