[PATCH v2] arm64: dts: rockchip: give some life to the rk3328-roc-cc leds

[PATCH v2] arm64: dts: rockchip: give some life to the rk3328-roc-cc leds

[Leonidas P. Papadakos]

Assign the LEDs to heartbeat and sdcard io, as in other RK boards.

https://github.com/armbian/build/commit/f1affad5c7be62d6e93832af3556c7609edd0858

Signed-off-by: Leonidas P. Papadakos <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
v2: Don't specify disabled IR led for now

---
 .../arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
index 33c44e857..171c377f8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
@@ -81,6 +81,25 @@
 		regulator-always-on;
 		regulator-boot-on;
 	};
+
+	leds {
+		compatible = "gpio-leds";
+		power {
+			label = "firefly:blue:power";
+			linux,default-trigger = "heartbeat";
+			gpios = <&rk805 1 GPIO_ACTIVE_LOW>;
+			default-state = "on";
+			mode = <0x23>;
+		};
+
+		user {
+			label = "firefly:yellow:user";
+			linux,default-trigger = "mmc1";
+			gpios = <&rk805 0 GPIO_ACTIVE_LOW>;
+			default-state = "off";
+			mode = <0x05>;
+		};
+	};
 };
 
 &cpu0 {
-- 
2.21.0

Re: [PATCH v2] arm64: dts: rockchip: give some life to the rk3328-roc-cc leds

[Tony McKahan]

On Sat, Mar 2, 2019 at 9:13 AM Leonidas P. Papadakos
<papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> Assign the LEDs to heartbeat and sdcard io, as in other RK boards.
>
> https://github.com/armbian/build/commit/f1affad5c7be62d6e93832af3556c7609edd0858
>
> Signed-off-by: Leonidas P. Papadakos <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

I will reach out to JMCC at Armbian and see if he wants tagged as
co-developer/etc.  It's not a big thing, but would be good to ask.

> ---
> v2: Don't specify disabled IR led for now
>
> ---
>  .../arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> index 33c44e857..171c377f8 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> @@ -81,6 +81,25 @@
>                 regulator-always-on;
>                 regulator-boot-on;
>         };
> +
> +       leds {
> +               compatible = "gpio-leds";
> +               power {
> +                       label = "firefly:blue:power";
> +                       linux,default-trigger = "heartbeat";
> +                       gpios = <&rk805 1 GPIO_ACTIVE_LOW>;
> +                       default-state = "on";
> +                       mode = <0x23>;
> +               };
> +
> +               user {
> +                       label = "firefly:yellow:user";
> +                       linux,default-trigger = "mmc1";
> +                       gpios = <&rk805 0 GPIO_ACTIVE_LOW>;
> +                       default-state = "off";
> +                       mode = <0x05>;
> +               };
> +       };
>  };
>
>  &cpu0 {
> --
> 2.21.0
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH v2] arm64: dts: rockchip: give some life to the rk3328-roc-cc leds

[Leonidas P. Papadakos]

On Sat, Mar 02, 2019 at 09:32:17AM -0500, Tony McKahan wrote:
> On Sat, Mar 2, 2019 at 9:13 AM Leonidas P. Papadakos
> <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >
> > Assign the LEDs to heartbeat and sdcard io, as in other RK boards.
> >
> > https://github.com/armbian/build/commit/f1affad5c7be62d6e93832af3556c7609edd0858
> >
> > Signed-off-by: Leonidas P. Papadakos <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> I will reach out to JMCC at Armbian and see if he wants tagged as
> co-developer/etc.  It's not a big thing, but would be good to ask.

Good idea! I didn't know what the "infastructure" for this inclusion was.

Re: [PATCH v2] arm64: dts: rockchip: give some life to the rk3328-roc-cc leds

[Tony McKahan]

On Sat, Mar 2, 2019 at 9:55 AM Leonidas P. Papadakos
<papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> On Sat, Mar 02, 2019 at 09:32:17AM -0500, Tony McKahan wrote:
> > On Sat, Mar 2, 2019 at 9:13 AM Leonidas P. Papadakos
> > <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > >
> > > Assign the LEDs to heartbeat and sdcard io, as in other RK boards.
> > >
> > > https://github.com/armbian/build/commit/f1affad5c7be62d6e93832af3556c7609edd0858
> > >
> > > Signed-off-by: Leonidas P. Papadakos <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >
> > I will reach out to JMCC at Armbian and see if he wants tagged as
> > co-developer/etc.  It's not a big thing, but would be good to ask.
>
> Good idea! I didn't know what the "infastructure" for this inclusion was.

https://www.kernel.org/doc/html/v5.0-rc8/process/submitting-patches.html

Sections 12 and 13 specifically.  I've been reading to try to get to
where I'm willing to bother these guys with patches.