From: Madhumthia Prabakaran <madhumithabiw@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2 0/8] Fix checkpatch.pl issues
Date: Sun, 3 Mar 2019 12:30:23 -0600 [thread overview]
Message-ID: <20190303183022.GA30916@madhuleo> (raw)
In-Reply-To: <20190303080915.GA712@kroah.com>
On Sun, Mar 03, 2019 at 09:09:15AM +0100, Greg KH wrote:
> On Sat, Mar 02, 2019 at 12:34:42PM -0600, Madhumitha Prabakaran wrote:
> > These patches fix warnings of line over 80 characters, comment style
> > issues of SPDX License Identifier and remove unnecessary blank line.
> >
> > Madhumitha Prabakaran (8):
> > Staging: vt6655: card.h: Fix line over 80 character
> > Staging: vt6655: card.h: Fix line over 80 characters
> > Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
> > Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
> > Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
> > Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
> > Staging: vt6655: mac.c: Remove unnecessary blank line
> > Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier
>
> Again, does not match the subject lines :(
>
> Perhaps if you typed out here _exactly_ what you did to create this
> cover letter, and send them off to us, it might help in determining what
> you did wrong.
>
> thanks,
>
> greg k-h
Thanks
Task: commit patchsets, which contains two patches
1. git log --pretty=oneline --abbrev-commit
8f8d8bbad6bc (HEAD -> staging-testing) Staging: vt6655: Fix ...
f68b96b7f7f5 Staging: vt6655: Fix comment ...
08b9bee66e3e (origin/staging-testing, origin/staging-next) ...
2. Format-patch
git format-patch -o /tmp/three/ --cover-letter -n --thread=shallow --cc="madhumithabiw@gmail.com" f68b96b7f7f5^..8f8d8bbad6bc
/tmp/three/0000-cover-letter.patch
/tmp/three/0001-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch
/tmp/three/0002-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch
3. Format patch for versioning
git format-patch -n --subject-prefix="PATCH v2" --cover-letter
On executing this, my subject prefix never changed. I assume, this is the issues. As this creates same version of subject line and clubs all version into same conversation.
4. I manually edit the vim /tmp/three/0000-cover-letter.patch
5. Edited the 'SUBJECT HERE' and 'BLURB HERE'. Here too I noticed that the subject prefix never changed.. So i tried to edit it manually.
I tried to change subject prefix for all the three files manually
6. After that I tried using mutt and git to send files
For git I used
git send-email --to-cover --cc-cover /tmp/three/*.patch
For mutt I used
mutt -H /tmp/third/0000......patch
For all three files I individually sent it via mutt
Referred: 1. https://kernelnewbies.org/Outreachyfirstpatch
2. https://kernelnewbies.org/PatchSeries
Thanks,
Madhumitha
next prev parent reply other threads:[~2019-03-03 18:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 18:34 [PATCH v2 0/8] Fix checkpatch.pl issues Madhumitha Prabakaran
2019-03-02 18:34 ` [PATCH v2 1/8] Staging: vt6655: Fix line over 80 character Madhumitha Prabakaran
2019-03-02 18:34 ` [PATCH v2 2/8] Staging: vt6655: Fix line over 80 characters Madhumitha Prabakaran
2019-03-02 18:34 ` [PATCH v2 3/8] Staging: vt6655: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
2019-03-02 18:34 ` [PATCH v2 4/8] Staging: vt6655: Fix comment style of SPDX License Identifer Madhumitha Prabakaran
2019-03-02 18:34 ` [PATCH v2 5/8] Staging: vt6655: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
2019-03-02 18:34 ` [PATCH v2 6/8] " Madhumitha Prabakaran
2019-03-02 18:34 ` [PATCH v2 7/8] Staging: vt6655: Remove unnecessary blank line Madhumitha Prabakaran
2019-03-02 18:34 ` [PATCH v2 8/8] Staging: vt6655: Fix comment style of SPDX License Identifier Madhumitha Prabakaran
2019-03-03 6:41 ` [Outreachy kernel] [PATCH v2 0/8] Fix checkpatch.pl issues Julia Lawall
2019-03-03 8:09 ` Greg KH
2019-03-03 18:30 ` Madhumthia Prabakaran [this message]
2019-03-04 7:44 ` Greg KH
2019-03-04 16:06 ` Madhumthia Prabakaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190303183022.GA30916@madhuleo \
--to=madhumithabiw@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.