Re: [PATCH v2 0/8] Fix checkpatch.pl issues

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Mar 03, 2019 at 12:30:23PM -0600, Madhumthia Prabakaran wrote:
> On Sun, Mar 03, 2019 at 09:09:15AM +0100, Greg KH wrote:
> > On Sat, Mar 02, 2019 at 12:34:42PM -0600, Madhumitha Prabakaran wrote:
> > > These patches fix warnings of line over 80 characters, comment style
> > > issues of SPDX License Identifier and remove unnecessary blank line.
> > > 
> > > Madhumitha Prabakaran (8):
> > >   Staging: vt6655: card.h: Fix line over 80 character
> > >   Staging: vt6655: card.h: Fix line over 80 characters
> > >   Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
> > >   Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
> > >   Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
> > >   Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
> > >   Staging: vt6655: mac.c: Remove unnecessary blank line
> > >   Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier
> > 
> > Again, does not match the subject lines :(
> > 
> > Perhaps if you typed out here _exactly_ what you did to create this
> > cover letter, and send them off to us, it might help in determining what
> > you did wrong.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Thanks
> 
> Task: commit patchsets, which contains two patches
> 
> 1. git log --pretty=oneline --abbrev-commit 
> 
> 8f8d8bbad6bc (HEAD -> staging-testing) Staging: vt6655: Fix ...
> f68b96b7f7f5 Staging: vt6655: Fix comment ...
> 
> 08b9bee66e3e (origin/staging-testing, origin/staging-next) ...

Ah, the problem is you never changed the actual changelog text in the
patch itself.  You need to do that.

> 2. Format-patch 
> 
> git format-patch -o /tmp/three/ --cover-letter -n --thread=shallow --cc="madhumithabiw@gmail.com" f68b96b7f7f5^..8f8d8bbad6bc
> 
> /tmp/three/0000-cover-letter.patch
> /tmp/three/0001-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch
> /tmp/three/0002-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch

See the subject line does not have the file name in it.

> 3. Format patch for versioning 
> 
> git format-patch -n --subject-prefix="PATCH v2" --cover-letter
> 
> On executing this, my subject prefix never changed. I assume, this is the issues. As this creates same version of subject line and clubs all version into same conversation. 

As discussed on irc, you don't need to use --subject-prefix.

Also, no need to call format-patch twice.

> 4. I manually edit the vim /tmp/three/0000-cover-letter.patch
> 
> 5. Edited the 'SUBJECT HERE'  and 'BLURB HERE'. Here too I noticed that the subject prefix never changed.. So i tried to edit it manually.
>    I tried to change subject prefix for all the three files manually

Editing this file does not change the actual text in the patches
themselves.

> 6. After that I tried using mutt and git to send files 
> 
> For git I used 
> git send-email --to-cover --cc-cover /tmp/three/*.patch
> 
> For mutt I used 
> mutt -H /tmp/third/0000......patch
> For all three files I individually sent  it via mutt

Sending is fine.

Ok, you need to change the subject lines of your patch.

to do this, rebase the patches and edit the changelog text.  Look up how
'git rebase -i' works, with the "reword" option.  That will give you the
chance to reword the changlog text to properly change the first line of
the patches to contain the filenames.

Then do your step 3 and others and all should be good.

Hope this helps,

greg k-h