From: Sudeep Holla <sudeep.holla@arm.com>
To: "Haibo Xu (Arm Technology China)" <Haibo.Xu@arm.com>
Cc: Steve Capper <Steve.Capper@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"jdike@addtoit.com" <jdike@addtoit.com>,
"x86@kernel.org" <x86@kernel.org>,
Will Deacon <Will.Deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Richard Weinberger <richard@nod.at>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Bin Lu \(Arm Technology China\)" <Bin.Lu@arm.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/6] ptrace: introduce ptrace_syscall_enter to consolidate PTRACE_SYSEMU handling
Date: Mon, 4 Mar 2019 10:46:43 +0000 [thread overview]
Message-ID: <20190304104643.GA28643@e107155-lin> (raw)
In-Reply-To: <f3441e63-c54d-3b9d-2919-8a3955cbee69@arm.com>
On Mon, Mar 04, 2019 at 08:03:47AM +0000, Haibo Xu (Arm Technology China) wrote:
> On 2019/3/1 2:32, Sudeep Holla wrote:
> > Currently each architecture handles PTRACE_SYSEMU in very similar way.
> > It's completely arch independent and can be handled in the code helping
> > to consolidate PTRACE_SYSEMU handling.
> >
> > Let's introduce a hook 'ptrace_syscall_enter' that arch specific syscall
> > entry code can call.
> >
>
> The 'ptrace_syscall_enter' is dedicated for PTRACE_SYSEMU flag,
> So I suggest to rename the function to something like 'ptrace_syscall_emu_enter".
>
I am fine to rename.
> > +/*
> > + * Hook to check and report for PTRACE_SYSEMU, can be called from arch
> > + * arch syscall entry code
> > + */
> > +long ptrace_syscall_enter(struct pt_regs *regs)
> > +{
> > +#ifdef TIF_SYSCALL_EMU
> > + if (test_thread_flag(TIF_SYSCALL_EMU)) {
> > + if (tracehook_report_syscall_entry(regs));
>
> Shall we remove the semi-colon at end of the above line?
>
Added intentionally to keep GCC happy.
--
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: "Haibo Xu (Arm Technology China)" <Haibo.Xu@arm.com>
Cc: Steve Capper <Steve.Capper@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"jdike@addtoit.com" <jdike@addtoit.com>,
"x86@kernel.org" <x86@kernel.org>,
Will Deacon <Will.Deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Richard Weinberger <richard@nod.at>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Thomas Gleixner <tglx@linutronix.de>,
"Bin Lu \(Arm Technology China\)" <Bin.Lu@arm.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/6] ptrace: introduce ptrace_syscall_enter to consolidate PTRACE_SYSEMU handling
Date: Mon, 4 Mar 2019 10:46:43 +0000 [thread overview]
Message-ID: <20190304104643.GA28643@e107155-lin> (raw)
In-Reply-To: <f3441e63-c54d-3b9d-2919-8a3955cbee69@arm.com>
On Mon, Mar 04, 2019 at 08:03:47AM +0000, Haibo Xu (Arm Technology China) wrote:
> On 2019/3/1 2:32, Sudeep Holla wrote:
> > Currently each architecture handles PTRACE_SYSEMU in very similar way.
> > It's completely arch independent and can be handled in the code helping
> > to consolidate PTRACE_SYSEMU handling.
> >
> > Let's introduce a hook 'ptrace_syscall_enter' that arch specific syscall
> > entry code can call.
> >
>
> The 'ptrace_syscall_enter' is dedicated for PTRACE_SYSEMU flag,
> So I suggest to rename the function to something like 'ptrace_syscall_emu_enter".
>
I am fine to rename.
> > +/*
> > + * Hook to check and report for PTRACE_SYSEMU, can be called from arch
> > + * arch syscall entry code
> > + */
> > +long ptrace_syscall_enter(struct pt_regs *regs)
> > +{
> > +#ifdef TIF_SYSCALL_EMU
> > + if (test_thread_flag(TIF_SYSCALL_EMU)) {
> > + if (tracehook_report_syscall_entry(regs));
>
> Shall we remove the semi-colon at end of the above line?
>
Added intentionally to keep GCC happy.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: "Haibo Xu (Arm Technology China)" <Haibo.Xu@arm.com>
Cc: "x86@kernel.org" <x86@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
Oleg Nesterov <oleg@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Richard Weinberger <richard@nod.at>,
"jdike@addtoit.com" <jdike@addtoit.com>,
Steve Capper <Steve.Capper@arm.com>,
"Bin Lu (Arm Technology China)" <Bin.Lu@arm.com>
Subject: Re: [PATCH 2/6] ptrace: introduce ptrace_syscall_enter to consolidate PTRACE_SYSEMU handling
Date: Mon, 4 Mar 2019 10:46:43 +0000 [thread overview]
Message-ID: <20190304104643.GA28643@e107155-lin> (raw)
In-Reply-To: <f3441e63-c54d-3b9d-2919-8a3955cbee69@arm.com>
On Mon, Mar 04, 2019 at 08:03:47AM +0000, Haibo Xu (Arm Technology China) wrote:
> On 2019/3/1 2:32, Sudeep Holla wrote:
> > Currently each architecture handles PTRACE_SYSEMU in very similar way.
> > It's completely arch independent and can be handled in the code helping
> > to consolidate PTRACE_SYSEMU handling.
> >
> > Let's introduce a hook 'ptrace_syscall_enter' that arch specific syscall
> > entry code can call.
> >
>
> The 'ptrace_syscall_enter' is dedicated for PTRACE_SYSEMU flag,
> So I suggest to rename the function to something like 'ptrace_syscall_emu_enter".
>
I am fine to rename.
> > +/*
> > + * Hook to check and report for PTRACE_SYSEMU, can be called from arch
> > + * arch syscall entry code
> > + */
> > +long ptrace_syscall_enter(struct pt_regs *regs)
> > +{
> > +#ifdef TIF_SYSCALL_EMU
> > + if (test_thread_flag(TIF_SYSCALL_EMU)) {
> > + if (tracehook_report_syscall_entry(regs));
>
> Shall we remove the semi-colon at end of the above line?
>
Added intentionally to keep GCC happy.
--
Regards,
Sudeep
next prev parent reply other threads:[~2019-03-04 10:48 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 18:32 [PATCH 0/6] ptrace: consolidate PTRACE_SYSEMU handling and add support for arm64 Sudeep Holla
2019-02-28 18:32 ` Sudeep Holla
2019-02-28 18:32 ` Sudeep Holla
2019-02-28 18:32 ` [PATCH 1/6] ptrace: move clearing of TIF_SYSCALL_EMU flag to core Sudeep Holla
2019-02-28 18:32 ` Sudeep Holla
2019-02-28 18:32 ` Sudeep Holla
2019-02-28 18:32 ` [PATCH 2/6] ptrace: introduce ptrace_syscall_enter to consolidate PTRACE_SYSEMU handling Sudeep Holla
2019-02-28 18:32 ` Sudeep Holla
2019-02-28 18:32 ` Sudeep Holla
2019-03-04 8:03 ` Haibo Xu (Arm Technology China)
2019-03-04 8:03 ` Haibo Xu (Arm Technology China)
2019-03-04 8:03 ` Haibo Xu (Arm Technology China)
2019-03-04 10:46 ` Sudeep Holla [this message]
2019-03-04 10:46 ` Sudeep Holla
2019-03-04 10:46 ` Sudeep Holla
2019-03-04 12:23 ` Segher Boessenkool
2019-03-04 12:23 ` Segher Boessenkool
2019-03-04 12:23 ` Segher Boessenkool
2019-03-04 12:27 ` Sudeep Holla
2019-03-04 12:27 ` Sudeep Holla
2019-03-04 12:27 ` Sudeep Holla
2019-02-28 18:32 ` [PATCH 3/6] x86: clean up _TIF_SYSCALL_EMU handling using ptrace_syscall_enter hook Sudeep Holla
2019-02-28 18:32 ` Sudeep Holla
2019-02-28 18:32 ` Sudeep Holla
2019-03-03 1:11 ` Andy Lutomirski
2019-03-03 1:11 ` Andy Lutomirski
2019-03-03 1:11 ` Andy Lutomirski
2019-03-04 10:07 ` Sudeep Holla
2019-03-04 10:07 ` Sudeep Holla
2019-03-04 10:07 ` Sudeep Holla
2019-03-04 8:25 ` Haibo Xu (Arm Technology China)
2019-03-04 8:25 ` Haibo Xu (Arm Technology China)
2019-03-04 8:25 ` Haibo Xu (Arm Technology China)
2019-03-04 10:12 ` Sudeep Holla
2019-03-04 10:12 ` Sudeep Holla
2019-03-04 10:12 ` Sudeep Holla
2019-03-05 2:14 ` Haibo Xu (Arm Technology China)
2019-03-05 2:14 ` Haibo Xu (Arm Technology China)
2019-03-05 2:14 ` Haibo Xu (Arm Technology China)
2019-03-11 18:34 ` Sudeep Holla
2019-03-11 18:34 ` Sudeep Holla
2019-03-11 18:34 ` Sudeep Holla
2019-03-12 1:34 ` Haibo Xu (Arm Technology China)
2019-03-12 1:34 ` Haibo Xu (Arm Technology China)
2019-03-12 1:34 ` Haibo Xu (Arm Technology China)
2019-03-12 3:04 ` Andy Lutomirski
2019-03-12 3:04 ` Andy Lutomirski
2019-03-12 3:04 ` Andy Lutomirski
2019-03-12 12:09 ` Sudeep Holla
2019-03-12 12:09 ` Sudeep Holla
2019-03-12 12:09 ` Sudeep Holla
2019-03-13 1:03 ` Haibo Xu (Arm Technology China)
2019-03-13 1:03 ` Haibo Xu (Arm Technology China)
2019-03-13 1:03 ` Haibo Xu (Arm Technology China)
2019-03-14 10:51 ` Sudeep Holla
2019-03-14 10:51 ` Sudeep Holla
2019-03-14 10:51 ` Sudeep Holla
2019-03-15 5:48 ` Haibo Xu (Arm Technology China)
2019-03-15 5:48 ` Haibo Xu (Arm Technology China)
2019-03-15 5:48 ` Haibo Xu (Arm Technology China)
2019-03-12 12:05 ` Sudeep Holla
2019-03-12 12:05 ` Sudeep Holla
2019-03-12 12:05 ` Sudeep Holla
2019-02-28 18:32 ` [PATCH 4/6] powerpc: use common ptrace_syscall_enter hook to handle _TIF_SYSCALL_EMU Sudeep Holla
2019-02-28 18:32 ` Sudeep Holla
2019-02-28 18:32 ` Sudeep Holla
2019-03-04 9:36 ` Haibo Xu (Arm Technology China)
2019-03-04 9:36 ` Haibo Xu (Arm Technology China)
2019-03-04 9:36 ` Haibo Xu (Arm Technology China)
2019-03-04 10:42 ` Sudeep Holla
2019-03-04 10:42 ` Sudeep Holla
2019-03-04 10:42 ` Sudeep Holla
2019-02-28 18:32 ` [PATCH 5/6] arm64: add PTRACE_SYSEMU{, SINGLESTEP} definations to uapi headers Sudeep Holla
2019-02-28 18:32 ` [PATCH 5/6] arm64: add PTRACE_SYSEMU{,SINGLESTEP} " Sudeep Holla
2019-02-28 18:32 ` [PATCH 5/6] arm64: add PTRACE_SYSEMU{, SINGLESTEP} " Sudeep Holla
2019-02-28 18:32 ` [PATCH 6/6] arm64: ptrace: add support for syscall emulation Sudeep Holla
2019-02-28 18:32 ` Sudeep Holla
2019-02-28 18:32 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304104643.GA28643@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=Bin.Lu@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Haibo.Xu@arm.com \
--cc=Steve.Capper@arm.com \
--cc=Will.Deacon@arm.com \
--cc=jdike@addtoit.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.