From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org
Cc: f.fainelli@gmail.com, bgolaszewski@baylibre.com,
linux-iio@vger.kernel.org, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
lars@metafoo.de, bcm-kernel-feedback-list@broadcom.com,
kbuild-all@01.org, pmeerw@pmeerw.net, knaack.h@gmx.de,
jic23@kernel.org, Justin Chen <justinpopo6@gmail.com>
Subject: Re: [PATCH v4 2/2] iio: adc: ti-ads7950: add GPIO support
Date: Mon, 4 Mar 2019 17:53:03 +0300 [thread overview]
Message-ID: <20190304145303.GA13452@kadam> (raw)
In-Reply-To: <1551392209-20004-3-git-send-email-justinpopo6@gmail.com>
Hi Justin,
url: https://github.com/0day-ci/linux/commits/justinpopo6-gmail-com/iio-adc-ads7950-add-gpio-support/20190301-201828
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
smatch warnings:
drivers/iio/adc/ti-ads7950.c:530 ti_ads7950_init_hw() error: double unlock 'mutex:&st->slock'
# https://github.com/0day-ci/linux/commit/5290a7752b734ae0b2f5b343bd761366decdbbeb
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 5290a7752b734ae0b2f5b343bd761366decdbbeb
vim +530 drivers/iio/adc/ti-ads7950.c
5290a775 Justin Chen 2019-02-28 506
5290a775 Justin Chen 2019-02-28 507 static int ti_ads7950_init_hw(struct ti_ads7950_state *st)
5290a775 Justin Chen 2019-02-28 508 {
5290a775 Justin Chen 2019-02-28 509 int ret = 0;
5290a775 Justin Chen 2019-02-28 510
5290a775 Justin Chen 2019-02-28 511 mutex_lock(&st->slock);
5290a775 Justin Chen 2019-02-28 512
5290a775 Justin Chen 2019-02-28 513 /* Settings for Manual/Auto1/Auto2 commands */
5290a775 Justin Chen 2019-02-28 514 /* Default to 5v ref */
5290a775 Justin Chen 2019-02-28 515 st->cmd_settings_bitmask = TI_ADS7950_CR_RANGE_5V;
5290a775 Justin Chen 2019-02-28 516 st->single_tx = TI_ADS7950_MAN_CMD_SETTINGS(st);
5290a775 Justin Chen 2019-02-28 517 ret = spi_sync(st->spi, &st->scan_single_msg);
5290a775 Justin Chen 2019-02-28 518 if (ret)
5290a775 Justin Chen 2019-02-28 519 goto out;
5290a775 Justin Chen 2019-02-28 520
5290a775 Justin Chen 2019-02-28 521 /* Settings for GPIO command */
5290a775 Justin Chen 2019-02-28 522 st->gpio_cmd_settings_bitmask = 0x0;
5290a775 Justin Chen 2019-02-28 523 st->single_tx = TI_ADS7950_GPIO_CMD_SETTINGS(st);
5290a775 Justin Chen 2019-02-28 524 ret = spi_sync(st->spi, &st->scan_single_msg);
5290a775 Justin Chen 2019-02-28 525 mutex_unlock(&st->slock);
^^^^^^^^^^^^^^^^^^^^^^^^
5290a775 Justin Chen 2019-02-28 526 if (ret)
5290a775 Justin Chen 2019-02-28 527 goto out;
5290a775 Justin Chen 2019-02-28 528
5290a775 Justin Chen 2019-02-28 529 out:
5290a775 Justin Chen 2019-02-28 @530 mutex_unlock(&st->slock);
^^^^^^^^^^^^^^^^^^^^^^^^
It's a bit disappointing that mutex_unlock() doesn't generate a warning
at runtime... :(
5290a775 Justin Chen 2019-02-28 531
5290a775 Justin Chen 2019-02-28 532 return ret;
5290a775 Justin Chen 2019-02-28 533 }
5290a775 Justin Chen 2019-02-28 534
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org, justinpopo6@gmail.com
Cc: kbuild-all@01.org, linux-iio@vger.kernel.org,
linux-gpio@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com, f.fainelli@gmail.com,
bgolaszewski@baylibre.com, linus.walleij@linaro.org,
jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, linux-kernel@vger.kernel.org,
Justin Chen <justinpopo6@gmail.com>
Subject: Re: [PATCH v4 2/2] iio: adc: ti-ads7950: add GPIO support
Date: Mon, 4 Mar 2019 17:53:03 +0300 [thread overview]
Message-ID: <20190304145303.GA13452@kadam> (raw)
In-Reply-To: <1551392209-20004-3-git-send-email-justinpopo6@gmail.com>
Hi Justin,
url: https://github.com/0day-ci/linux/commits/justinpopo6-gmail-com/iio-adc-ads7950-add-gpio-support/20190301-201828
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
smatch warnings:
drivers/iio/adc/ti-ads7950.c:530 ti_ads7950_init_hw() error: double unlock 'mutex:&st->slock'
# https://github.com/0day-ci/linux/commit/5290a7752b734ae0b2f5b343bd761366decdbbeb
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 5290a7752b734ae0b2f5b343bd761366decdbbeb
vim +530 drivers/iio/adc/ti-ads7950.c
5290a775 Justin Chen 2019-02-28 506
5290a775 Justin Chen 2019-02-28 507 static int ti_ads7950_init_hw(struct ti_ads7950_state *st)
5290a775 Justin Chen 2019-02-28 508 {
5290a775 Justin Chen 2019-02-28 509 int ret = 0;
5290a775 Justin Chen 2019-02-28 510
5290a775 Justin Chen 2019-02-28 511 mutex_lock(&st->slock);
5290a775 Justin Chen 2019-02-28 512
5290a775 Justin Chen 2019-02-28 513 /* Settings for Manual/Auto1/Auto2 commands */
5290a775 Justin Chen 2019-02-28 514 /* Default to 5v ref */
5290a775 Justin Chen 2019-02-28 515 st->cmd_settings_bitmask = TI_ADS7950_CR_RANGE_5V;
5290a775 Justin Chen 2019-02-28 516 st->single_tx = TI_ADS7950_MAN_CMD_SETTINGS(st);
5290a775 Justin Chen 2019-02-28 517 ret = spi_sync(st->spi, &st->scan_single_msg);
5290a775 Justin Chen 2019-02-28 518 if (ret)
5290a775 Justin Chen 2019-02-28 519 goto out;
5290a775 Justin Chen 2019-02-28 520
5290a775 Justin Chen 2019-02-28 521 /* Settings for GPIO command */
5290a775 Justin Chen 2019-02-28 522 st->gpio_cmd_settings_bitmask = 0x0;
5290a775 Justin Chen 2019-02-28 523 st->single_tx = TI_ADS7950_GPIO_CMD_SETTINGS(st);
5290a775 Justin Chen 2019-02-28 524 ret = spi_sync(st->spi, &st->scan_single_msg);
5290a775 Justin Chen 2019-02-28 525 mutex_unlock(&st->slock);
^^^^^^^^^^^^^^^^^^^^^^^^
5290a775 Justin Chen 2019-02-28 526 if (ret)
5290a775 Justin Chen 2019-02-28 527 goto out;
5290a775 Justin Chen 2019-02-28 528
5290a775 Justin Chen 2019-02-28 529 out:
5290a775 Justin Chen 2019-02-28 @530 mutex_unlock(&st->slock);
^^^^^^^^^^^^^^^^^^^^^^^^
It's a bit disappointing that mutex_unlock() doesn't generate a warning
at runtime... :(
5290a775 Justin Chen 2019-02-28 531
5290a775 Justin Chen 2019-02-28 532 return ret;
5290a775 Justin Chen 2019-02-28 533 }
5290a775 Justin Chen 2019-02-28 534
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2019-03-04 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 22:16 [PATCH v4 0/2] iio: adc: ads7950: add gpio support justinpopo6
2019-02-28 22:16 ` [PATCH v4 1/2] iio: adc: ti-ads7950: Fix improper use of mlock justinpopo6
2019-03-02 18:53 ` Jonathan Cameron
2019-02-28 22:16 ` [PATCH v4 2/2] iio: adc: ti-ads7950: add GPIO support justinpopo6
2019-03-01 13:25 ` Linus Walleij
2019-03-02 18:53 ` Jonathan Cameron
2019-03-04 14:53 ` Dan Carpenter [this message]
2019-03-04 14:53 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304145303.GA13452@kadam \
--to=dan.carpenter@oracle.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=f.fainelli@gmail.com \
--cc=jic23@kernel.org \
--cc=justinpopo6@gmail.com \
--cc=kbuild-all@01.org \
--cc=kbuild@01.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.