* [PATCH v2] Staging: pi433: Fix line over 80 characters issue
@ 2019-03-04 16:29 Debleena Sen
2019-03-04 16:37 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Debleena Sen @ 2019-03-04 16:29 UTC (permalink / raw)
To: gregkh, outreachy-kernel; +Cc: Debleena Sen
Delete extra whitespace and tab space and use one tab space to
remove the checkpatch.pl warning:
WARNING: line over 80 characters
Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index b231463..53928af 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -45,10 +45,10 @@
#include "pi433_if.h"
#include "rf69.h"
-#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
-#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
-#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
-#define NUM_DIO 2
+#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
+#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
+#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
+#define NUM_DIO 2
static dev_t pi433_dev;
static DEFINE_IDR(pi433_idr);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Staging: pi433: Fix line over 80 characters issue
2019-03-04 16:29 [PATCH v2] Staging: pi433: Fix line over 80 characters issue Debleena Sen
@ 2019-03-04 16:37 ` Greg KH
2019-03-04 16:41 ` Debleena Sen
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-03-04 16:37 UTC (permalink / raw)
To: Debleena Sen; +Cc: outreachy-kernel
On Mon, Mar 04, 2019 at 08:29:59AM -0800, Debleena Sen wrote:
> Delete extra whitespace and tab space and use one tab space to
> remove the checkpatch.pl warning:
> WARNING: line over 80 characters
>
> Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
What changed from v1? That always goes below the --- line please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Staging: pi433: Fix line over 80 characters issue
2019-03-04 16:37 ` Greg KH
@ 2019-03-04 16:41 ` Debleena Sen
0 siblings, 0 replies; 3+ messages in thread
From: Debleena Sen @ 2019-03-04 16:41 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
On Mon, 4 Mar 2019, 22:07 Greg KH, <gregkh@linuxfoundation.org> wrote:
> On Mon, Mar 04, 2019 at 08:29:59AM -0800, Debleena Sen wrote:
> > Delete extra whitespace and tab space and use one tab space to
> > remove the checkpatch.pl warning:
> > WARNING: line over 80 characters
> >
> > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > ---
> > drivers/staging/pi433/pi433_if.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> What changed from v1? That always goes below the --- line please.
>
> thanks,
>
> greg k-h
OK. Editing and re-sending.
[-- Attachment #2: Type: text/html, Size: 1155 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-04 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-04 16:29 [PATCH v2] Staging: pi433: Fix line over 80 characters issue Debleena Sen
2019-03-04 16:37 ` Greg KH
2019-03-04 16:41 ` Debleena Sen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.