From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: hkallweit1@gmail.com, f.fainelli@gmail.com, heiko@sntech.de,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH net-next] net: phy: improve handling link_change_notify callback
Date: Mon, 4 Mar 2019 21:06:30 +0100 [thread overview]
Message-ID: <20190304200630.GJ26378@lunn.ch> (raw)
In-Reply-To: <20190304.113025.1437399524067140375.davem@davemloft.net>
On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote:
> From: Heiner Kallweit <hkallweit1@gmail.com>
> Date: Sun, 3 Mar 2019 19:58:57 +0100
>
> > Currently the Phy driver's link_change_notify callback is called
> > whenever the state machine is run (every second if polling), no matter
> > whether the state changed or not. This isn't needed and may confuse
> > users considering the name of the callback. Therefore let's change
> > the behavior and call this callback only in case of an actual
> > state change.
> >
> > This requires changes to the at803x and rockchip drivers.
> > at803x can be simplified so that it reacts on a state change to
> > PHY_NOLINK only.
> > The rockchip driver can also be much simplified. We simply re-init
> > the AFE/DSP registers whenever we change to PHY_RUNNING and speed
> > is 100Mbps. This causes very small overhead because we do this even
> > if the speed was 100Mbps already. But this is neglectable and
> > I think justified by the much simpler code.
> >
> > Changes are compile-tested only.
> >
> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> Someone please review this.
Hi David
We should probably wait for a Tested-by: from Daniel Mack
<zonque@gmail.com> and David Wu <david.wu@rock-chips.com>, or
equivalent.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: f.fainelli@gmail.com, heiko@sntech.de, netdev@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com
Subject: Re: [PATCH net-next] net: phy: improve handling link_change_notify callback
Date: Mon, 4 Mar 2019 21:06:30 +0100 [thread overview]
Message-ID: <20190304200630.GJ26378@lunn.ch> (raw)
In-Reply-To: <20190304.113025.1437399524067140375.davem@davemloft.net>
On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote:
> From: Heiner Kallweit <hkallweit1@gmail.com>
> Date: Sun, 3 Mar 2019 19:58:57 +0100
>
> > Currently the Phy driver's link_change_notify callback is called
> > whenever the state machine is run (every second if polling), no matter
> > whether the state changed or not. This isn't needed and may confuse
> > users considering the name of the callback. Therefore let's change
> > the behavior and call this callback only in case of an actual
> > state change.
> >
> > This requires changes to the at803x and rockchip drivers.
> > at803x can be simplified so that it reacts on a state change to
> > PHY_NOLINK only.
> > The rockchip driver can also be much simplified. We simply re-init
> > the AFE/DSP registers whenever we change to PHY_RUNNING and speed
> > is 100Mbps. This causes very small overhead because we do this even
> > if the speed was 100Mbps already. But this is neglectable and
> > I think justified by the much simpler code.
> >
> > Changes are compile-tested only.
> >
> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> Someone please review this.
Hi David
We should probably wait for a Tested-by: from Daniel Mack
<zonque@gmail.com> and David Wu <david.wu@rock-chips.com>, or
equivalent.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-04 20:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 18:58 [PATCH net-next] net: phy: improve handling link_change_notify callback Heiner Kallweit
2019-03-03 18:58 ` Heiner Kallweit
2019-03-04 19:30 ` David Miller
2019-03-04 19:30 ` David Miller
2019-03-04 20:06 ` Andrew Lunn [this message]
2019-03-04 20:06 ` Andrew Lunn
2019-03-04 21:03 ` David Miller
2019-03-04 21:03 ` David Miller
2019-03-12 12:27 ` Heiko Stuebner
2019-03-12 12:27 ` Heiko Stuebner
2019-03-12 17:50 ` Daniel Mack
2019-03-12 17:50 ` Daniel Mack
2019-03-12 23:19 ` Russell King - ARM Linux admin
2019-03-12 23:19 ` Russell King - ARM Linux admin
2019-03-15 13:29 ` David Wu
2019-03-15 13:29 ` David Wu
2019-03-08 19:45 ` David Miller
2019-03-08 19:45 ` David Miller
2019-03-12 17:56 ` Florian Fainelli
2019-03-12 17:56 ` Florian Fainelli
-- strict thread matches above, loose matches on Subject: below --
2019-03-19 18:56 Heiner Kallweit
2019-03-19 18:56 ` Heiner Kallweit
2019-03-20 17:50 ` David Miller
2019-03-20 17:50 ` David Miller
2019-04-04 11:04 ` David Wu
2019-04-04 11:04 ` David Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304200630.GJ26378@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.