* [PATCH] Staging: fbtft: Lines over 80 characters
@ 2019-03-04 21:09 Daniela Mormocea
2019-03-04 21:33 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Daniela Mormocea @ 2019-03-04 21:09 UTC (permalink / raw)
To: outreachy-kernel; +Cc: daniela.mormocea
Fix lines with over 80 characters
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
---
drivers/staging/fbtft/flexfb.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
index c5fa591..0759d93 100644
--- a/drivers/staging/fbtft/flexfb.c
+++ b/drivers/staging/fbtft/flexfb.c
@@ -671,7 +671,10 @@ static int flexfb_probe_common(struct spi_device *sdev,
break;
case 9:
if (regwidth == 16) {
- dev_err(dev, "argument 'regwidth': %d is not supported with buswidth=%d and SPI.\n", regwidth, buswidth);
+ dev_err(dev,
+ "argument 'regwidth': %d is not
+ supported with buswidth=%d and SPI.\n",
+ regwidth, buswidth);
return -EINVAL;
}
par->fbtftops.write_register = fbtft_write_reg8_bus9;
@@ -718,7 +721,9 @@ static int flexfb_probe_common(struct spi_device *sdev,
par->fbtftops.write_vmem = fbtft_write_vmem16_bus16;
break;
default:
- dev_err(dev, "argument 'buswidth': %d is not supported with parallel.\n", buswidth);
+ dev_err(dev,
+ "argument 'buswidth': %d is not supported with parallel.\n",
+ buswidth);
return -EINVAL;
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: fbtft: Lines over 80 characters
2019-03-04 21:09 [PATCH] Staging: fbtft: Lines over 80 characters Daniela Mormocea
@ 2019-03-04 21:33 ` Julia Lawall
2019-03-04 21:39 ` Dana Mormocea
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2019-03-04 21:33 UTC (permalink / raw)
To: Daniela Mormocea; +Cc: outreachy-kernel
On Mon, 4 Mar 2019, Daniela Mormocea wrote:
> Fix lines with over 80 characters
>
> Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
> ---
> drivers/staging/fbtft/flexfb.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
> index c5fa591..0759d93 100644
> --- a/drivers/staging/fbtft/flexfb.c
> +++ b/drivers/staging/fbtft/flexfb.c
> @@ -671,7 +671,10 @@ static int flexfb_probe_common(struct spi_device *sdev,
> break;
> case 9:
> if (regwidth == 16) {
> - dev_err(dev, "argument 'regwidth': %d is not supported with buswidth=%d and SPI.\n", regwidth, buswidth);
> + dev_err(dev,
> + "argument 'regwidth': %d is not
> + supported with buswidth=%d and SPI.\n",
Don't break the string in this way. Strings are allowed to drift over 80
characters, so that it is possible to grep for the string that one sees at
runtime.
julia
> + regwidth, buswidth);
> return -EINVAL;
> }
> par->fbtftops.write_register = fbtft_write_reg8_bus9;
> @@ -718,7 +721,9 @@ static int flexfb_probe_common(struct spi_device *sdev,
> par->fbtftops.write_vmem = fbtft_write_vmem16_bus16;
> break;
> default:
> - dev_err(dev, "argument 'buswidth': %d is not supported with parallel.\n", buswidth);
> + dev_err(dev,
> + "argument 'buswidth': %d is not supported with parallel.\n",
> + buswidth);
> return -EINVAL;
> }
> }
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190304210909.GA4408%40pthm.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: fbtft: Lines over 80 characters
2019-03-04 21:33 ` [Outreachy kernel] " Julia Lawall
@ 2019-03-04 21:39 ` Dana Mormocea
2019-03-04 21:41 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Dana Mormocea @ 2019-03-04 21:39 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 2855 bytes --]
ok, I understand, thank you
should I correct the string issue and mail this patch again?
On Monday, March 4, 2019 at 11:34:00 PM UTC+2, Julia Lawall wrote:
>
>
>
> On Mon, 4 Mar 2019, Daniela Mormocea wrote:
>
> > Fix lines with over 80 characters
> >
> > Signed-off-by: Daniela Mormocea <daniela....@gmail.com <javascript:>>
> > ---
> > drivers/staging/fbtft/flexfb.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/fbtft/flexfb.c
> b/drivers/staging/fbtft/flexfb.c
> > index c5fa591..0759d93 100644
> > --- a/drivers/staging/fbtft/flexfb.c
> > +++ b/drivers/staging/fbtft/flexfb.c
> > @@ -671,7 +671,10 @@ static int flexfb_probe_common(struct spi_device
> *sdev,
> > break;
> > case 9:
> > if (regwidth == 16) {
> > - dev_err(dev, "argument 'regwidth': %d
> is not supported with buswidth=%d and SPI.\n", regwidth, buswidth);
> > + dev_err(dev,
> > + "argument 'regwidth': %d is not
> > + supported with buswidth=%d and
> SPI.\n",
>
> Don't break the string in this way. Strings are allowed to drift over 80
> characters, so that it is possible to grep for the string that one sees at
> runtime.
>
> julia
>
> > + regwidth, buswidth);
> > return -EINVAL;
> > }
> > par->fbtftops.write_register =
> fbtft_write_reg8_bus9;
> > @@ -718,7 +721,9 @@ static int flexfb_probe_common(struct spi_device
> *sdev,
> > par->fbtftops.write_vmem =
> fbtft_write_vmem16_bus16;
> > break;
> > default:
> > - dev_err(dev, "argument 'buswidth': %d is not
> supported with parallel.\n", buswidth);
> > + dev_err(dev,
> > + "argument 'buswidth': %d is not
> supported with parallel.\n",
> > + buswidth);
> > return -EINVAL;
> > }
> > }
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kern...@googlegroups.com <javascript:>.
> > To post to this group, send email to outreach...@googlegroups.com
> <javascript:>.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20190304210909.GA4408%40pthm.
>
> > For more options, visit https://groups.google.com/d/optout.
> >
>
[-- Attachment #1.2: Type: text/html, Size: 5231 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: fbtft: Lines over 80 characters
2019-03-04 21:39 ` Dana Mormocea
@ 2019-03-04 21:41 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2019-03-04 21:41 UTC (permalink / raw)
To: Dana Mormocea; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 4496 bytes --]
On Mon, 4 Mar 2019, Dana Mormocea wrote:
> ok, I understand, thank you
> should I correct the string issue and mail this patch again?
To my recollection, the rest looked ok. So you can fix it up and send it
again. Please don't top post. You see how I have put my response under
your text that I am responding to.
julia
>
> On Monday, March 4, 2019 at 11:34:00 PM UTC+2, Julia Lawall wrote:
>
>
> On Mon, 4 Mar 2019, Daniela Mormocea wrote:
>
> > Fix lines with over 80 characters
> >
> > Signed-off-by: Daniela Mormocea <daniela....@gmail.com>
> > ---
> > drivers/staging/fbtft/flexfb.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/fbtft/flexfb.c
> b/drivers/staging/fbtft/flexfb.c
> > index c5fa591..0759d93 100644
> > --- a/drivers/staging/fbtft/flexfb.c
> > +++ b/drivers/staging/fbtft/flexfb.c
> > @@ -671,7 +671,10 @@ static int flexfb_probe_common(struct
> spi_device *sdev,
> > break;
> > case 9:
> > if (regwidth == 16) {
> > - dev_err(dev, "argument
> 'regwidth': %d is not supported with buswidth=%d and SPI.\n",
> regwidth, buswidth);
> > + dev_err(dev,
> > + "argument 'regwidth':
> %d is not
> > + supported with
> buswidth=%d and SPI.\n",
>
> Don't break the string in this way. Strings are allowed to
> drift over 80
> characters, so that it is possible to grep for the string that
> one sees at
> runtime.
>
> julia
>
> > + regwidth, buswidth);
> > return -EINVAL;
> > }
> > par->fbtftops.write_register =
> fbtft_write_reg8_bus9;
> > @@ -718,7 +721,9 @@ static int flexfb_probe_common(struct
> spi_device *sdev,
> > par->fbtftops.write_vmem =
> fbtft_write_vmem16_bus16;
> > break;
> > default:
> > - dev_err(dev, "argument 'buswidth': %d
> is not supported with parallel.\n", buswidth);
> > + dev_err(dev,
> > + "argument 'buswidth': %d is
> not supported with parallel.\n",
> > + buswidth);
> > return -EINVAL;
> > }
> > }
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the
> Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from
> it, send an email to outreachy-kern...@googlegroups.com.
> > To post to this group, send email to
> outreach...@googlegroups.com.
> > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20190304210909.GA4408%40
> pthm.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/ba227e82-6a25-4767-8358-
> 26f2a1a17f13%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-04 21:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-04 21:09 [PATCH] Staging: fbtft: Lines over 80 characters Daniela Mormocea
2019-03-04 21:33 ` [Outreachy kernel] " Julia Lawall
2019-03-04 21:39 ` Dana Mormocea
2019-03-04 21:41 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.