* [PATCH] Staging: fbtft: Fix line over 80 characters
@ 2019-03-04 22:05 Daniela Mormocea
2019-03-04 22:09 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Daniela Mormocea @ 2019-03-04 22:05 UTC (permalink / raw)
To: outreachy-kernel
fix line over 80 characters, warning by checkpatch
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
---
drivers/staging/fbtft/flexfb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
index c5fa591..b91b459 100644
--- a/drivers/staging/fbtft/flexfb.c
+++ b/drivers/staging/fbtft/flexfb.c
@@ -718,7 +718,9 @@ static int flexfb_probe_common(struct spi_device *sdev,
par->fbtftops.write_vmem = fbtft_write_vmem16_bus16;
break;
default:
- dev_err(dev, "argument 'buswidth': %d is not supported with parallel.\n", buswidth);
+ dev_err(dev,
+ "argument 'buswidth': %d is not supported with parallel.\n",
+ buswidth);
return -EINVAL;
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: fbtft: Fix line over 80 characters
2019-03-04 22:05 [PATCH] Staging: fbtft: Fix line over 80 characters Daniela Mormocea
@ 2019-03-04 22:09 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2019-03-04 22:09 UTC (permalink / raw)
To: Daniela Mormocea; +Cc: outreachy-kernel
On Tue, 5 Mar 2019, Daniela Mormocea wrote:
> fix line over 80 characters, warning by checkpatch
This should be a proper sentence. That is, it should begin with a capital
letter and end with a period.
It would be better to say what you actually did, rather than just saying
that you fixed something. Say what you did and why.
If this change is to replace a patch that you previously sent, it should
be indicated as v2, ie [PATCH v2], and you should describe what has
changed since the previous version under the ---
julia
>
> Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
> ---
> drivers/staging/fbtft/flexfb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
> index c5fa591..b91b459 100644
> --- a/drivers/staging/fbtft/flexfb.c
> +++ b/drivers/staging/fbtft/flexfb.c
> @@ -718,7 +718,9 @@ static int flexfb_probe_common(struct spi_device *sdev,
> par->fbtftops.write_vmem = fbtft_write_vmem16_bus16;
> break;
> default:
> - dev_err(dev, "argument 'buswidth': %d is not supported with parallel.\n", buswidth);
> + dev_err(dev,
> + "argument 'buswidth': %d is not supported with parallel.\n",
> + buswidth);
> return -EINVAL;
> }
> }
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190304220537.GA9580%40pthm.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-04 22:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-04 22:05 [PATCH] Staging: fbtft: Fix line over 80 characters Daniela Mormocea
2019-03-04 22:09 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.