[PATCH v4] Staging: pi433: Fix line over 80 characters issue

[PATCH v4] Staging: pi433: Fix line over 80 characters issue

[Debleena Sen]

Break the line and match the indentation to remove the
checkpatch.pl warning:
WARNING: line over 80 characters

Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
---
 drivers/staging/pi433/rf69.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e19b9ce..0c189a7 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -563,7 +563,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
 {
 	switch (flag) {
 	case mode_switch_completed:
-		return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_MODE_READY);
+		return (rf69_read_reg(spi, REG_IRQFLAGS1) &
+			MASK_IRQFLAGS1_MODE_READY);
 	case ready_to_receive:
 		return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_RX_READY);
 	case ready_to_send:
-- 
2.7.4

Re: [Outreachy kernel] [PATCH v4] Staging: pi433: Fix line over 80 characters issue

[Julia Lawall]

On Sun, 3 Mar 2019, Debleena Sen wrote:

> Break the line and match the indentation to remove the
> checkpatch.pl warning:
> WARNING: line over 80 characters
>
> Signed-off-by: Debleena Sen <idebleenasen@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
>  drivers/staging/pi433/rf69.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index e19b9ce..0c189a7 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -563,7 +563,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
>  {
>  	switch (flag) {
>  	case mode_switch_completed:
> -		return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_MODE_READY);
> +		return (rf69_read_reg(spi, REG_IRQFLAGS1) &
> +			MASK_IRQFLAGS1_MODE_READY);
>  	case ready_to_receive:
>  		return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_RX_READY);
>  	case ready_to_send:
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1551607296-33723-1-git-send-email-idebleenasen%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue

[Greg KH]

On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> Break the line and match the indentation to remove the
> checkpatch.pl warning:
> WARNING: line over 80 characters
> 
> Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> ---
>  drivers/staging/pi433/rf69.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

What changed from the previous versions?  That information always goes
below the --- line please.

Please fix up and resend.

thanks,

greg k-h

Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue

[Debleena Sen]

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

 On Tue, 5 Mar 2019, 13:10 Greg KH, <gregkh@linuxfoundation.org> wrote:

> On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> > Break the line and match the indentation to remove the
> > checkpatch.pl warning:
> > WARNING: line over 80 characters
> >
> > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > ---
> >  drivers/staging/pi433/rf69.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
>
> What changed from the previous versions?  That information always goes
> below the --- line please.
>
> Please fix up and resend.
>
> thanks,
>
> greg k-h
>

Will do.

Thnaks,
Debleena

[-- Attachment #2: Type: text/html, Size: 1220 bytes --]

Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue

[Debleena Sen]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

On Tue, Mar 5, 2019 at 1:10 PM Greg KH <gregkh@linuxfoundation.org> wrote:

> On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> > Break the line and match the indentation to remove the
> > checkpatch.pl warning:
> > WARNING: line over 80 characters
> >
> > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > ---
> >  drivers/staging/pi433/rf69.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
>
> What changed from the previous versions?  That information always goes
> below the --- line please.
>
> Please fix up and resend.
>
> thanks,
>
> greg k-h
>

I'm not able to find the commit.

I tried using "git reset --mixed e19b9ce" but it shows an error:

error: object e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9 is a blob, not a
commit
fatal: could not parse object 'e19b9ce'

How can I recover it so that I can add the changes?

Thank you,
Debleena

[-- Attachment #2: Type: text/html, Size: 1593 bytes --]

Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue

[Greg KH]

On Tue, Mar 05, 2019 at 09:54:44PM +0530, Debleena Sen wrote:
> On Tue, Mar 5, 2019 at 1:10 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> > On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> > > Break the line and match the indentation to remove the
> > > checkpatch.pl warning:
> > > WARNING: line over 80 characters
> > >
> > > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > > ---
> > >  drivers/staging/pi433/rf69.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > What changed from the previous versions?  That information always goes
> > below the --- line please.
> >
> > Please fix up and resend.
> >
> > thanks,
> >
> > greg k-h
> >
> 
> I'm not able to find the commit.
> 
> I tried using "git reset --mixed e19b9ce" but it shows an error:
> 
> error: object e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9 is a blob, not a
> commit
> fatal: could not parse object 'e19b9ce'
> 
> How can I recover it so that I can add the changes?

I have no idea what you are trying to do here, sorry.  Why are you
running 'git reset'?

confused,

greg k-h

Re: [Outreachy kernel] Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue

[Julia Lawall]

On Wed, 6 Mar 2019, Greg KH wrote:

> On Tue, Mar 05, 2019 at 09:54:44PM +0530, Debleena Sen wrote:
> > On Tue, Mar 5, 2019 at 1:10 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > > On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> > > > Break the line and match the indentation to remove the
> > > > checkpatch.pl warning:
> > > > WARNING: line over 80 characters
> > > >
> > > > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > > > ---
> > > >  drivers/staging/pi433/rf69.c | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > What changed from the previous versions?  That information always goes
> > > below the --- line please.
> > >
> > > Please fix up and resend.
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> >
> > I'm not able to find the commit.
> >
> > I tried using "git reset --mixed e19b9ce" but it shows an error:
> >
> > error: object e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9 is a blob, not a
> > commit
> > fatal: could not parse object 'e19b9ce'
> >
> > How can I recover it so that I can add the changes?
>
> I have no idea what you are trying to do here, sorry.  Why are you
> running 'git reset'?

If you get confused with git, just undo the whole thing and start over.

julia


>
> confused,
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190306091544.GE7927%40kroah.com.
> For more options, visit https://groups.google.com/d/optout.
>

Fwd: [PATCH v4] Staging: pi433: Fix line over 80 characters issue

[Debleena Sen]

[-- Attachment #1: Type: text/plain, Size: 2105 bytes --]

---------- Forwarded message ---------
From: Debleena Sen <idebleenasen@gmail.com>
Date: Wed, Mar 6, 2019 at 3:10 PM
Subject: Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue
To: Greg KH <gregkh@linuxfoundation.org>


On Wed, Mar 6, 2019 at 2:45 PM Greg KH <gregkh@linuxfoundation.org> wrote:

> On Tue, Mar 05, 2019 at 09:54:44PM +0530, Debleena Sen wrote:
> > On Tue, Mar 5, 2019 at 1:10 PM Greg KH <gregkh@linuxfoundation.org>
> wrote:
> >
> > > On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> > > > Break the line and match the indentation to remove the
> > > > checkpatch.pl warning:
> > > > WARNING: line over 80 characters
> > > >
> > > > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > > > ---
> > > >  drivers/staging/pi433/rf69.c | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > What changed from the previous versions?  That information always goes
> > > below the --- line please.
> > >
> > > Please fix up and resend.
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> >
> > I'm not able to find the commit.
> >
> > I tried using "git reset --mixed e19b9ce" but it shows an error:
> >
> > error: object e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9 is a blob, not a
> > commit
> > fatal: could not parse object 'e19b9ce'
> >
> > How can I recover it so that I can add the changes?
>
> I have no idea what you are trying to do here, sorry.  Why are you
> running 'git reset'?
>
> confused,
>
> greg k-h
>

In the tutorial it was written to edit a commit we need to use git reset
--mixed <file ID>

So I thought to use that.

It was my first patch probably. I already told you in another mail that
there were like 16 warnings of the same type and same styling issue in
pi433/rf69.c

So in this patch I had fixed only one warning. Yesterday I sent another
patch in which I've fixed the other 15 warnings.

In the tutorial, it was written to edit a commit we need to use git reset
--mixed <file ID>

So I thought to use that  to add the version change log.

But when I  tried it, this error popped.

I'm sorry. I think I've messed up.

[-- Attachment #2: Type: text/html, Size: 3497 bytes --]

[PATCH v4] Staging: pi433: Fix line over 80 characters issue

[Debleena Sen]

Delete extra whitespace and tab space and use one tab space to
remove the checkpatch.pl warning:
WARNING: line over 80 characters

Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
---
Changes in v4:
	- Add version change log in the right place
Changes in v3:
        - Add version change log
Changes in v2:
        - Add "and use one tab space" to the log message

 drivers/staging/pi433/pi433_if.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index b231463..53928af 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -45,10 +45,10 @@
 #include "pi433_if.h"
 #include "rf69.h"
 
-#define N_PI433_MINORS			BIT(MINORBITS) /*32*/	/* ... up to 256 */
-#define MAX_MSG_SIZE			900	/* min: FIFO_SIZE! */
-#define MSG_FIFO_SIZE			65536   /* 65536 = 2^16  */
-#define NUM_DIO				2
+#define N_PI433_MINORS		BIT(MINORBITS) /*32*/	/* ... up to 256 */
+#define MAX_MSG_SIZE		900	/* min: FIFO_SIZE! */
+#define MSG_FIFO_SIZE		65536   /* 65536 = 2^16  */
+#define NUM_DIO			2
 
 static dev_t pi433_dev;
 static DEFINE_IDR(pi433_idr);
-- 
2.7.4