* [PATCH] staging: iio: Line over 80 characters
@ 2019-03-05 10:00 Daniela Mormocea
2019-03-05 10:04 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Daniela Mormocea @ 2019-03-05 10:00 UTC (permalink / raw)
To: outreachy-kernel
Fix line over 80 characters to get rid of checkpatch warning
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
---
drivers/staging/iio/addac/adt7316.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 6f7891b..be2dfdb 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -2155,7 +2155,8 @@ int adt7316_probe(struct device *dev, struct adt7316_bus *bus,
else
chip->dac_bits = 8;
- chip->ldac_pin = devm_gpiod_get_optional(dev, "adi,ldac", GPIOD_OUT_LOW);
+ chip->ldac_pin = devm_gpiod_get_optional(dev,
+ "adi,ldac", GPIOD_OUT_LOW);
if (IS_ERR(chip->ldac_pin)) {
ret = PTR_ERR(chip->ldac_pin);
dev_err(dev, "Failed to request ldac GPIO: %d\n", ret);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: iio: Line over 80 characters
2019-03-05 10:00 [PATCH] staging: iio: Line over 80 characters Daniela Mormocea
@ 2019-03-05 10:04 ` Greg KH
2019-03-05 10:41 ` Dana Mormocea
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-03-05 10:04 UTC (permalink / raw)
To: Daniela Mormocea; +Cc: outreachy-kernel
On Tue, Mar 05, 2019 at 12:00:01PM +0200, Daniela Mormocea wrote:
> Fix line over 80 characters to get rid of checkpatch warning
>
> Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
> ---
> drivers/staging/iio/addac/adt7316.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 6f7891b..be2dfdb 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -2155,7 +2155,8 @@ int adt7316_probe(struct device *dev, struct adt7316_bus *bus,
> else
> chip->dac_bits = 8;
>
> - chip->ldac_pin = devm_gpiod_get_optional(dev, "adi,ldac", GPIOD_OUT_LOW);
> + chip->ldac_pin = devm_gpiod_get_optional(dev,
> + "adi,ldac", GPIOD_OUT_LOW);
Shouldn't this be:
chip->ldac_pin = devm_gpiod_get_optional(dev, "adi,ldac",
GPIOD_OUT_LOW);
?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: iio: Line over 80 characters
2019-03-05 10:04 ` [Outreachy kernel] " Greg KH
@ 2019-03-05 10:41 ` Dana Mormocea
0 siblings, 0 replies; 3+ messages in thread
From: Dana Mormocea @ 2019-03-05 10:41 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1285 bytes --]
On Tuesday, March 5, 2019 at 12:04:19 PM UTC+2, Greg Kroah-Hartman wrote:
>
> On Tue, Mar 05, 2019 at 12:00:01PM +0200, Daniela Mormocea wrote:
> > Fix line over 80 characters to get rid of checkpatch warning
> >
> > Signed-off-by: Daniela Mormocea <daniela....@gmail.com <javascript:>>
> > ---
> > drivers/staging/iio/addac/adt7316.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/iio/addac/adt7316.c
> b/drivers/staging/iio/addac/adt7316.c
> > index 6f7891b..be2dfdb 100644
> > --- a/drivers/staging/iio/addac/adt7316.c
> > +++ b/drivers/staging/iio/addac/adt7316.c
> > @@ -2155,7 +2155,8 @@ int adt7316_probe(struct device *dev, struct
> adt7316_bus *bus,
> > else
> > chip->dac_bits = 8;
> >
> > - chip->ldac_pin = devm_gpiod_get_optional(dev, "adi,ldac",
> GPIOD_OUT_LOW);
> > + chip->ldac_pin = devm_gpiod_get_optional(dev,
> > + "adi,ldac",
> GPIOD_OUT_LOW);
>
> Shouldn't this be:
> chip->ldac_pin = devm_gpiod_get_optional(dev, "adi,ldac",
> GPIOD_OUT_LOW);
> ?
>
> thanks,
>
> greg k-h
>
oops.. yes.. I will revert the changes and mail it back
[-- Attachment #1.2: Type: text/html, Size: 2019 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-05 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-05 10:00 [PATCH] staging: iio: Line over 80 characters Daniela Mormocea
2019-03-05 10:04 ` [Outreachy kernel] " Greg KH
2019-03-05 10:41 ` Dana Mormocea
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.