From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Wentao.Lou-5C7GfCeVMHo@public.gmane.org
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [bug report] drm/amdgpu: tighten gpu_recover in mailbox_flr to avoid duplicate recover in sriov
Date: Tue, 5 Mar 2019 14:34:59 +0300 [thread overview]
Message-ID: <20190305113459.GA13649@kadam> (raw)
Hello wentalou,
The patch 2c11ee6ae553: "drm/amdgpu: tighten gpu_recover in
mailbox_flr to avoid duplicate recover in sriov" from Jan 30, 2019,
leads to the following static checker warning:
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c:270 xgpu_ai_mailbox_flr_work()
warn: impossible condition '(amdgpu_lockup_timeout == ((~0 >> 1))) => (s32min-s32max == s64max)'
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c
262 flr_done:
263 if (locked) {
264 adev->in_gpu_reset = 0;
265 mutex_unlock(&adev->lock_reset);
266 }
267
268 /* Trigger recovery for world switch failure if no TDR */
269 if (amdgpu_device_should_recover_gpu(adev)
--> 270 && amdgpu_lockup_timeout == MAX_SCHEDULE_TIMEOUT)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
amdgpu_lockup_timeout is an int and I'm not sure if that's what you
want to test. MAX_SCHEDULE_TIMEOUT is LONG_MAX.
271 amdgpu_device_gpu_recover(adev, NULL);
272 }
regards,
dan carpenter
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
reply other threads:[~2019-03-05 11:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305113459.GA13649@kadam \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=Wentao.Lou-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.