[bug report] drm/amdgpu: tighten gpu_recover in mailbox_flr to avoid duplicate recover in sriov

[bug report] drm/amdgpu: tighten gpu_recover in mailbox_flr to avoid duplicate recover in sriov

[Dan Carpenter]

Hello wentalou,

The patch 2c11ee6ae553: "drm/amdgpu: tighten gpu_recover in
mailbox_flr to avoid duplicate recover in sriov" from Jan 30, 2019,
leads to the following static checker warning:

	drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c:270 xgpu_ai_mailbox_flr_work()
	warn: impossible condition '(amdgpu_lockup_timeout == ((~0 >> 1))) => (s32min-s32max == s64max)'

drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c
    262 flr_done:
    263 	if (locked) {
    264 		adev->in_gpu_reset = 0;
    265 		mutex_unlock(&adev->lock_reset);
    266 	}
    267 
    268 	/* Trigger recovery for world switch failure if no TDR */
    269 	if (amdgpu_device_should_recover_gpu(adev)
--> 270 		&& amdgpu_lockup_timeout == MAX_SCHEDULE_TIMEOUT)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
amdgpu_lockup_timeout is an int and I'm not sure if that's what you 
want to test.  MAX_SCHEDULE_TIMEOUT is LONG_MAX.

    271 		amdgpu_device_gpu_recover(adev, NULL);
    272 }

regards,
dan carpenter
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx