All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Quentin Perret <quentin.perret@arm.com>,
	Linux PM <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Chen Yu <yu.c.chen@intel.com>,
	Gabriele Mazzotta <gabriele.mzt@gmail.com>
Subject: Re: [RFT][Update][PATCH 2/2] cpufreq: intel_pstate: Update max CPU frequency on global turbo changes
Date: Tue, 5 Mar 2019 12:44:06 +0100	[thread overview]
Message-ID: <20190305114406.GV32494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <6357319.Iupbu3ldGQ@aspire.rjw.lan>

On Tue, Mar 05, 2019 at 11:58:37AM +0100, Rafael J. Wysocki wrote:
> So after the Peter's patch "sched/cpufreq: Fix 32bit math overflow"
> I will need to recompute sg_cpu->min in sugov_limits().

So there's still an open question; do we want that ->min thing to depend
on available frequencies _at_all_ ?

I'm thinking it might be a good thing to have the iowait boost curve be
independent of all that.

Like said; if we set it at 128 (static), it takes 9 consequtive wake-ups
for it to reach 1024 (max). While now the curve depends on how wide the
gap is between min_freq and max_freq. And it seems weird to have this
behaviour depend on that. To me at least.

Now, I don't know if 128/9 is the right curve, it is just a random
number I pulled out of a hat. But it seems to make more sense than
depending on frequencies.

  reply	other threads:[~2019-03-05 11:44 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-01 12:43 [RFT][PATCH 0/2] cpufreq: intel_pstate: Handle _PPC updates on global turbo disable/enable Rafael J. Wysocki
2019-03-01 12:45 ` [RFT][PATCH 1/2] cpufreq: intel_pstate: Driver-specific handling of _PPC updates Rafael J. Wysocki
2019-03-01 12:47 ` [RFT][PATCH 2/2] cpufreq: intel_pstate: Update max CPU frequency on global turbo changes Rafael J. Wysocki
2019-03-01 12:57   ` [RFT][Update][PATCH " Rafael J. Wysocki
2019-03-04 14:39     ` Yu Chen
2019-03-05 10:42     ` Quentin Perret
2019-03-05 10:50       ` Rafael J. Wysocki
2019-03-05 10:58         ` Rafael J. Wysocki
2019-03-05 11:44           ` Peter Zijlstra [this message]
2019-03-05 11:52             ` Rafael J. Wysocki
2019-03-05 12:00             ` Quentin Perret
2019-03-05 12:24               ` Peter Zijlstra
2019-03-05 17:02               ` Rafael J. Wysocki
2019-03-05 17:37                 ` Quentin Perret
2019-03-06 10:05                   ` Rafael J. Wysocki
2019-03-07 11:02                     ` Quentin Perret
2019-03-07 11:23                       ` Peter Zijlstra
2019-03-07 11:49                         ` Quentin Perret
2019-03-07 11:25                       ` Rafael J. Wysocki
2019-03-07 11:59                         ` Quentin Perret
2019-03-05 11:01         ` Quentin Perret
2019-03-01 17:39 ` [RFT][PATCH 0/2] cpufreq: intel_pstate: Handle _PPC updates on global turbo disable/enable Srinivas Pandruvada
2019-03-02 10:30   ` Yu Chen
2019-03-02 16:24     ` Srinivas Pandruvada
2019-03-03 17:03   ` Rafael J. Wysocki
2019-03-03 21:20     ` Srinivas Pandruvada
2019-03-03 21:51       ` Rafael J. Wysocki
2019-03-04  4:06         ` Srinivas Pandruvada
2019-03-04  9:41           ` Rafael J. Wysocki
2019-03-04 18:06             ` Srinivas Pandruvada
2019-03-04 21:57               ` Rafael J. Wysocki
2019-03-04 23:04                 ` Srinivas Pandruvada
2019-03-05  8:40                   ` Rafael J. Wysocki
2019-03-03 22:42 ` Gabriele Mazzotta
2019-03-04  9:58   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190305114406.GV32494@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=gabriele.mzt@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=quentin.perret@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=viresh.kumar@linaro.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.