From: Peter Zijlstra <peterz@infradead.org>
To: Quentin Perret <quentin.perret@arm.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Chen Yu <yu.c.chen@intel.com>,
Gabriele Mazzotta <gabriele.mzt@gmail.com>
Subject: Re: [RFT][Update][PATCH 2/2] cpufreq: intel_pstate: Update max CPU frequency on global turbo changes
Date: Thu, 7 Mar 2019 12:23:44 +0100 [thread overview]
Message-ID: <20190307112344.GC32477@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190307110256.padefvq4e52ly3nm@queper01-lin>
On Thu, Mar 07, 2019 at 11:02:58AM +0000, Quentin Perret wrote:
> Also on recent big little SoCs, the capacity ratio can be pretty high.
> You can get little CPUs with 300 of capacity or so. The arbitrary 128
> thing is basically gonna go near max freq in one step, although the CPUs
> actually 20 available OPPs or so. And I guess that's a shame.
Ah, but remember; with the latest patch the iowait_boost is scaled on
max. So in order to hit that 300, you first have to hit 1024.
+ boost = (sg_cpu->iowait_boost * max) >> SCHED_CAPACITY_SHIFT;
+ return max(boost, util);
So iowait_boost goes from 128 to 1024 in 4 wakeups (the first sets 128,
the next 3 get it to 1024), but the effective value is, given @max ==
300:
128 -> 37
256 -> 75
512 -> 150
1024 -> 300
so irrespective of the number of OPPs and their spread, it takes 4
wakeups to get to max.
next prev parent reply other threads:[~2019-03-07 11:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 12:43 [RFT][PATCH 0/2] cpufreq: intel_pstate: Handle _PPC updates on global turbo disable/enable Rafael J. Wysocki
2019-03-01 12:45 ` [RFT][PATCH 1/2] cpufreq: intel_pstate: Driver-specific handling of _PPC updates Rafael J. Wysocki
2019-03-01 12:47 ` [RFT][PATCH 2/2] cpufreq: intel_pstate: Update max CPU frequency on global turbo changes Rafael J. Wysocki
2019-03-01 12:57 ` [RFT][Update][PATCH " Rafael J. Wysocki
2019-03-04 14:39 ` Yu Chen
2019-03-05 10:42 ` Quentin Perret
2019-03-05 10:50 ` Rafael J. Wysocki
2019-03-05 10:58 ` Rafael J. Wysocki
2019-03-05 11:44 ` Peter Zijlstra
2019-03-05 11:52 ` Rafael J. Wysocki
2019-03-05 12:00 ` Quentin Perret
2019-03-05 12:24 ` Peter Zijlstra
2019-03-05 17:02 ` Rafael J. Wysocki
2019-03-05 17:37 ` Quentin Perret
2019-03-06 10:05 ` Rafael J. Wysocki
2019-03-07 11:02 ` Quentin Perret
2019-03-07 11:23 ` Peter Zijlstra [this message]
2019-03-07 11:49 ` Quentin Perret
2019-03-07 11:25 ` Rafael J. Wysocki
2019-03-07 11:59 ` Quentin Perret
2019-03-05 11:01 ` Quentin Perret
2019-03-01 17:39 ` [RFT][PATCH 0/2] cpufreq: intel_pstate: Handle _PPC updates on global turbo disable/enable Srinivas Pandruvada
2019-03-02 10:30 ` Yu Chen
2019-03-02 16:24 ` Srinivas Pandruvada
2019-03-03 17:03 ` Rafael J. Wysocki
2019-03-03 21:20 ` Srinivas Pandruvada
2019-03-03 21:51 ` Rafael J. Wysocki
2019-03-04 4:06 ` Srinivas Pandruvada
2019-03-04 9:41 ` Rafael J. Wysocki
2019-03-04 18:06 ` Srinivas Pandruvada
2019-03-04 21:57 ` Rafael J. Wysocki
2019-03-04 23:04 ` Srinivas Pandruvada
2019-03-05 8:40 ` Rafael J. Wysocki
2019-03-03 22:42 ` Gabriele Mazzotta
2019-03-04 9:58 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307112344.GC32477@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=gabriele.mzt@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quentin.perret@arm.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.