From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sameer Pujar <spujar@nvidia.com>,
Mohan Kumar D <mkumard@nvidia.com>,
Ravindra Lokhande <rlokhande@nvidia.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/tegra: avoid build error without CONFIG_PM
Date: Tue, 5 Mar 2019 13:20:52 +0100 [thread overview]
Message-ID: <20190305122052.GG26369@ulmo> (raw)
In-Reply-To: <20190304203337.1968705-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
On Mon, Mar 04, 2019 at 09:33:25PM +0100, Arnd Bergmann wrote:
> The #ifdef protection around the PM functions is wrong, leading to
> a failed reference in some configurations:
>
> sound/pci/hda/hda_tegra.c: In function 'hda_tegra_runtime_suspend':
> sound/pci/hda/hda_tegra.c:273:2: error: implicit declaration of function 'hda_tegra_disable_clocks'; did you mean 'hda_tegra_enable_clocks'? [-Werror=implicit-function-declaration]
>
> Better remove the #ifdefs entirely and rely on the compiler silently
> dropping unused functions marked __maybe_unused.
>
> Fixes: 707e0759f2f4 ("ALSA: hda/tegra: implement runtime suspend/resume")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> sound/pci/hda/hda_tegra.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-03-05 12:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 20:33 [PATCH] ALSA: hda/tegra: avoid build error without CONFIG_PM Arnd Bergmann
2019-03-05 12:20 ` Thierry Reding [this message]
2019-03-13 10:29 ` Takashi Iwai
2019-03-13 10:29 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305122052.GG26369@ulmo \
--to=thierry.reding@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rlokhande@nvidia.com \
--cc=spujar@nvidia.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.