From: Takashi Iwai <tiwai@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Mohan Kumar D <mkumard@nvidia.com>,
Ravindra Lokhande <rlokhande@nvidia.com>,
Sameer Pujar <spujar@nvidia.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/tegra: avoid build error without CONFIG_PM
Date: Wed, 13 Mar 2019 11:29:00 +0100 [thread overview]
Message-ID: <s5hr2bbukyb.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190304203337.1968705-1-arnd@arndb.de>
On Mon, 04 Mar 2019 21:33:25 +0100,
Arnd Bergmann wrote:
>
> The #ifdef protection around the PM functions is wrong, leading to
> a failed reference in some configurations:
>
> sound/pci/hda/hda_tegra.c: In function 'hda_tegra_runtime_suspend':
> sound/pci/hda/hda_tegra.c:273:2: error: implicit declaration of function 'hda_tegra_disable_clocks'; did you mean 'hda_tegra_enable_clocks'? [-Werror=implicit-function-declaration]
>
> Better remove the #ifdefs entirely and rely on the compiler silently
> dropping unused functions marked __maybe_unused.
>
> Fixes: 707e0759f2f4 ("ALSA: hda/tegra: implement runtime suspend/resume")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied now. Thanks.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Mohan Kumar D" <mkumard@nvidia.com>,
"Ravindra Lokhande" <rlokhande@nvidia.com>,
"Sameer Pujar" <spujar@nvidia.com>,
<linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda/tegra: avoid build error without CONFIG_PM
Date: Wed, 13 Mar 2019 11:29:00 +0100 [thread overview]
Message-ID: <s5hr2bbukyb.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190304203337.1968705-1-arnd@arndb.de>
On Mon, 04 Mar 2019 21:33:25 +0100,
Arnd Bergmann wrote:
>
> The #ifdef protection around the PM functions is wrong, leading to
> a failed reference in some configurations:
>
> sound/pci/hda/hda_tegra.c: In function 'hda_tegra_runtime_suspend':
> sound/pci/hda/hda_tegra.c:273:2: error: implicit declaration of function 'hda_tegra_disable_clocks'; did you mean 'hda_tegra_enable_clocks'? [-Werror=implicit-function-declaration]
>
> Better remove the #ifdefs entirely and rely on the compiler silently
> dropping unused functions marked __maybe_unused.
>
> Fixes: 707e0759f2f4 ("ALSA: hda/tegra: implement runtime suspend/resume")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied now. Thanks.
Takashi
next prev parent reply other threads:[~2019-03-13 10:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 20:33 [PATCH] ALSA: hda/tegra: avoid build error without CONFIG_PM Arnd Bergmann
2019-03-05 12:20 ` Thierry Reding
2019-03-13 10:29 ` Takashi Iwai [this message]
2019-03-13 10:29 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr2bbukyb.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rlokhande@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.