Re: [PATCH] staging: emxx_udc: replace bool with unsigned base type to fix possible alignment warning

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Mar 08, 2019 at 12:06:32AM +0000, Jules Irenge wrote:
> replace bool with unsigned base type to fix the checkpatch.pl warning
>  Avoid using bool structure members because of possible alignment issues
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/emxx_udc/emxx_udc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
> index b8c3dee5626c..4a610bc90db3 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.h
> +++ b/drivers/staging/emxx_udc/emxx_udc.h
> @@ -528,7 +528,7 @@ struct nbu2ss_req {
>  	struct list_head		queue;
>  
>  	u32			div_len;
> -	bool		dma_flag;
> +	unsigned int		dma_flag;

No, there's no issue with the original code here.  See the archives for
why making this type of change is not always what you want to do.

thanks,

greg k-h