* [PATCH] staging: emxx_udc: replace bool with unsigned base type to fix possible alignment warning
@ 2019-03-08 0:06 Jules Irenge
2019-03-08 6:12 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jules Irenge @ 2019-03-08 0:06 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
replace bool with unsigned base type to fix the checkpatch.pl warning
Avoid using bool structure members because of possible alignment issues
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/emxx_udc/emxx_udc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
index b8c3dee5626c..4a610bc90db3 100644
--- a/drivers/staging/emxx_udc/emxx_udc.h
+++ b/drivers/staging/emxx_udc/emxx_udc.h
@@ -528,7 +528,7 @@ struct nbu2ss_req {
struct list_head queue;
u32 div_len;
- bool dma_flag;
+ unsigned int dma_flag;
bool zero;
bool unaligned;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: emxx_udc: replace bool with unsigned base type to fix possible alignment warning
2019-03-08 0:06 [PATCH] staging: emxx_udc: replace bool with unsigned base type to fix possible alignment warning Jules Irenge
@ 2019-03-08 6:12 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-03-08 6:12 UTC (permalink / raw)
To: Jules Irenge; +Cc: outreachy-kernel
On Fri, Mar 08, 2019 at 12:06:32AM +0000, Jules Irenge wrote:
> replace bool with unsigned base type to fix the checkpatch.pl warning
> Avoid using bool structure members because of possible alignment issues
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
> index b8c3dee5626c..4a610bc90db3 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.h
> +++ b/drivers/staging/emxx_udc/emxx_udc.h
> @@ -528,7 +528,7 @@ struct nbu2ss_req {
> struct list_head queue;
>
> u32 div_len;
> - bool dma_flag;
> + unsigned int dma_flag;
No, there's no issue with the original code here. See the archives for
why making this type of change is not always what you want to do.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-08 6:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-08 0:06 [PATCH] staging: emxx_udc: replace bool with unsigned base type to fix possible alignment warning Jules Irenge
2019-03-08 6:12 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.