From: Greg KH <gregkh@linuxfoundation.org>
To: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Cc: forest@alittletooquiet.net, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v3] Staging: vt6655: Remove unused function prototype and definition
Date: Fri, 8 Mar 2019 08:00:16 +0100 [thread overview]
Message-ID: <20190308070016.GA17194@kroah.com> (raw)
In-Reply-To: <20190307204930.8418-1-madhumithabiw@gmail.com>
On Thu, Mar 07, 2019 at 02:49:30PM -0600, Madhumitha Prabakaran wrote:
> Remove an unused function, as it is never called in kernel tree.
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Tiny nit, and I'll fix this up on my own, but usually it is nice to put
the name of the function that you are removing in the changelog, so it
is easier to search for in the future when you are wondering why did a
specific function disappear.
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-08 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 20:49 [PATCH v3] Staging: vt6655: Remove unused function prototype and definition Madhumitha Prabakaran
2019-03-08 7:00 ` Greg KH [this message]
2019-03-10 13:24 ` [Outreachy kernel] " Madhumthia Prabakaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308070016.GA17194@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=forest@alittletooquiet.net \
--cc=madhumithabiw@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.