[PATCH v3] Staging: vt6655: Remove unused function prototype and definition

[PATCH v3] Staging: vt6655: Remove unused function prototype and definition

[Madhumitha Prabakaran]

Remove an unused function, as it is never called in kernel tree.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>

---
Changes in v3-
- Changed subject line
- Removed change log above signed-off-by

Changes in v2-
- Changed patch series to a patch
---
 drivers/staging/vt6655/mac.c | 7 -------
 drivers/staging/vt6655/mac.h | 2 --
 2 files changed, 9 deletions(-)

diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
index 40a8f1ce837c..2f773fdf8d64 100644
--- a/drivers/staging/vt6655/mac.c
+++ b/drivers/staging/vt6655/mac.c
@@ -57,13 +57,6 @@
  * Return Value: true if all test bits On; otherwise false
  *
  */
-bool MACbIsRegBitsOn(struct vnt_private *priv, unsigned char byRegOfs,
-		     unsigned char byTestBits)
-{
-	void __iomem *io_base = priv->PortOffset;
-
-	return (ioread8(io_base + byRegOfs) & byTestBits) == byTestBits;
-}
 
 /*
  * Description:
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index 59538ac09fc5..c7888c4e96f2 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -876,8 +876,6 @@ do {								\
 #define MACvSetRFLE_LatchBase(iobase)                                 \
 	MACvWordRegBitsOn(iobase, MAC_REG_SOFTPWRCTL, SOFTPWRCTL_RFLEOPT)
 
-bool MACbIsRegBitsOn(struct vnt_private *priv, unsigned char byRegOfs,
-		     unsigned char byTestBits);
 bool MACbIsRegBitsOff(struct vnt_private *priv, unsigned char byRegOfs,
 		      unsigned char byTestBits);
 
-- 
2.17.1

Re: [Outreachy kernel] [PATCH v3] Staging: vt6655: Remove unused function prototype and definition

[Greg KH]

On Thu, Mar 07, 2019 at 02:49:30PM -0600, Madhumitha Prabakaran wrote:
> Remove an unused function, as it is never called in kernel tree.
> 
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>

Tiny nit, and I'll fix this up on my own, but usually it is nice to put
the name of the function that you are removing in the changelog, so it
is easier to search for in the future when you are wondering why did a
specific function disappear.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH v3] Staging: vt6655: Remove unused function prototype and definition

[Madhumthia Prabakaran]

On Fri, Mar 08, 2019 at 08:00:16AM +0100, Greg KH wrote:
> On Thu, Mar 07, 2019 at 02:49:30PM -0600, Madhumitha Prabakaran wrote:
> > Remove an unused function, as it is never called in kernel tree.
> > 
> > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> 
> Tiny nit, and I'll fix this up on my own, but usually it is nice to put
> the name of the function that you are removing in the changelog, so it
> is easier to search for in the future when you are wondering why did a
> specific function disappear.
> 
> thanks,
> 
> greg k-h

Thanks, will remember that in future.

Madhumitha