All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Wentao Cai <etsai042@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2] Staging: r8712u: Replace '--help--' with 'help'
Date: Fri, 8 Mar 2019 08:07:29 +0100	[thread overview]
Message-ID: <20190308070729.GA20013@kroah.com> (raw)
In-Reply-To: <20190308020444.3291-1-etsai042@gmail.com>

On Thu, Mar 07, 2019 at 06:04:44PM -0800, Wentao Cai wrote:
> Replace '--help--' in Kconfig and indent the subsequent text to silence checkpatch.pl
> warning:
> WARNING: prefer 'help' over '---help---' for new help texts
> 
> Signed-off-by: Wentao Cai <etsai042@gmail.com>
> ---
>  drivers/staging/rtl8712/Kconfig | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/Kconfig b/drivers/staging/rtl8712/Kconfig
> index f160eee52f09..622ad14f232c 100644
> --- a/drivers/staging/rtl8712/Kconfig
> +++ b/drivers/staging/rtl8712/Kconfig
> @@ -4,14 +4,14 @@ config R8712U
>  	select WIRELESS_EXT
>  	select WEXT_PRIV
>  	select FW_LOADER
> -	---help---
> -	This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
> -	If built as a module, it will be called r8712u.
> +	help
> +	    This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
> +	    If built as a module, it will be called r8712u.
>  
>  config R8712_TX_AGGR
>  	bool "Realtek RTL8712U Transmit Aggregation code"
>  	depends on R8712U && BROKEN
> -	---help---
> -	This option provides transmit aggregation for the Realtek RTL8712 USB device.
> +	help
> +	    This option provides transmit aggregation for the Realtek RTL8712 USB device.
>  
>  

This patch does not apply.  Please make sure to always work off of my
staging-testing branch of the staging.git repository.

thanks,

greg k-h


      reply	other threads:[~2019-03-08  7:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08  2:04 [PATCH v2] Staging: r8712u: Replace '--help--' with 'help' Wentao Cai
2019-03-08  7:07 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190308070729.GA20013@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=etsai042@gmail.com \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.