All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] Staging: r8712u: Replace '--help--' with 'help'
@ 2019-03-08  2:04 Wentao Cai
  2019-03-08  7:07 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Wentao Cai @ 2019-03-08  2:04 UTC (permalink / raw)
  To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman
  Cc: outreachy-kernel, Wentao Cai

Replace '--help--' in Kconfig and indent the subsequent text to silence checkpatch.pl
warning:
WARNING: prefer 'help' over '---help---' for new help texts

Signed-off-by: Wentao Cai <etsai042@gmail.com>
---
 drivers/staging/rtl8712/Kconfig | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8712/Kconfig b/drivers/staging/rtl8712/Kconfig
index f160eee52f09..622ad14f232c 100644
--- a/drivers/staging/rtl8712/Kconfig
+++ b/drivers/staging/rtl8712/Kconfig
@@ -4,14 +4,14 @@ config R8712U
 	select WIRELESS_EXT
 	select WEXT_PRIV
 	select FW_LOADER
-	---help---
-	This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
-	If built as a module, it will be called r8712u.
+	help
+	    This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
+	    If built as a module, it will be called r8712u.
 
 config R8712_TX_AGGR
 	bool "Realtek RTL8712U Transmit Aggregation code"
 	depends on R8712U && BROKEN
-	---help---
-	This option provides transmit aggregation for the Realtek RTL8712 USB device.
+	help
+	    This option provides transmit aggregation for the Realtek RTL8712 USB device.
 
 
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] Staging: r8712u: Replace '--help--' with 'help'
  2019-03-08  2:04 [PATCH v2] Staging: r8712u: Replace '--help--' with 'help' Wentao Cai
@ 2019-03-08  7:07 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2019-03-08  7:07 UTC (permalink / raw)
  To: Wentao Cai; +Cc: Larry Finger, Florian Schilhabel, outreachy-kernel

On Thu, Mar 07, 2019 at 06:04:44PM -0800, Wentao Cai wrote:
> Replace '--help--' in Kconfig and indent the subsequent text to silence checkpatch.pl
> warning:
> WARNING: prefer 'help' over '---help---' for new help texts
> 
> Signed-off-by: Wentao Cai <etsai042@gmail.com>
> ---
>  drivers/staging/rtl8712/Kconfig | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/Kconfig b/drivers/staging/rtl8712/Kconfig
> index f160eee52f09..622ad14f232c 100644
> --- a/drivers/staging/rtl8712/Kconfig
> +++ b/drivers/staging/rtl8712/Kconfig
> @@ -4,14 +4,14 @@ config R8712U
>  	select WIRELESS_EXT
>  	select WEXT_PRIV
>  	select FW_LOADER
> -	---help---
> -	This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
> -	If built as a module, it will be called r8712u.
> +	help
> +	    This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
> +	    If built as a module, it will be called r8712u.
>  
>  config R8712_TX_AGGR
>  	bool "Realtek RTL8712U Transmit Aggregation code"
>  	depends on R8712U && BROKEN
> -	---help---
> -	This option provides transmit aggregation for the Realtek RTL8712 USB device.
> +	help
> +	    This option provides transmit aggregation for the Realtek RTL8712 USB device.
>  
>  

This patch does not apply.  Please make sure to always work off of my
staging-testing branch of the staging.git repository.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-08  7:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-08  2:04 [PATCH v2] Staging: r8712u: Replace '--help--' with 'help' Wentao Cai
2019-03-08  7:07 ` Greg Kroah-Hartman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.