Re: [PATCH v2] staging: speakup: remove unnecessary assignment statement before return

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Himadri Pandya, le sam. 09 mars 2019 14:39:27 +0530, a ecrit:
> Remove unnecessary assignment statement before return from function
> find_specifier_end. Issue found by Coccinelle.

Well, I have to say that for style I prefer the way it was: we apply
several functions to the input variable, before returning it.

> Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
> ---
> Changes in V2:
> 	- Remove "Coccinelle" from patch tag
> 
>  drivers/staging/speakup/i18n.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index ee240d36f947..a748eb8052d1 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
>  	input++;		/* Advance over %. */
>  	input = skip_flags(input);
>  	input = skip_width(input);
> -	input = skip_conversion(input);
> -	return input;
> +	return skip_conversion(input);
>  }
>  
>  /*
> -- 
> 2.17.1
>