[PATCH Coccinelle] staging: speakup: remove unnecessary assignment statement before return

[PATCH Coccinelle] staging: speakup: remove unnecessary assignment statement before return

[Himadri Pandya]

Remove unnecessary assignment statement before return from function
find_specifier_end. Issue found by Coccinelle.

Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
---
 drivers/staging/speakup/i18n.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
index ee240d36f947..a748eb8052d1 100644
--- a/drivers/staging/speakup/i18n.c
+++ b/drivers/staging/speakup/i18n.c
@@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
 	input++;		/* Advance over %. */
 	input = skip_flags(input);
 	input = skip_width(input);
-	input = skip_conversion(input);
-	return input;
+	return skip_conversion(input);
 }
 
 /*
-- 
2.17.1

Re: [Outreachy kernel] [PATCH Coccinelle] staging: speakup: remove unnecessary assignment statement before return

[Julia Lawall]

Hello,

Please don't explicitly CC me and please don't put Coccinelle after PATCH.
I see the patches.  It is better to put in the commit log that Coccinelle
was used to find or fix the problem than to overload the PATCh tag.

thanks,
julia

On Sat, 9 Mar 2019, Himadri Pandya wrote:

> Remove unnecessary assignment statement before return from function
> find_specifier_end. Issue found by Coccinelle.
>
> Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
> ---
>  drivers/staging/speakup/i18n.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index ee240d36f947..a748eb8052d1 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
>  	input++;		/* Advance over %. */
>  	input = skip_flags(input);
>  	input = skip_width(input);
> -	input = skip_conversion(input);
> -	return input;
> +	return skip_conversion(input);
>  }
>
>  /*
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190309080721.26121-1-himadri18.07%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

[PATCH v2] staging: speakup: remove unnecessary assignment statement before return

[Himadri Pandya]

Remove unnecessary assignment statement before return from function
find_specifier_end. Issue found by Coccinelle.

Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
---
Changes in V2:
	- Remove "Coccinelle" from patch tag

 drivers/staging/speakup/i18n.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
index ee240d36f947..a748eb8052d1 100644
--- a/drivers/staging/speakup/i18n.c
+++ b/drivers/staging/speakup/i18n.c
@@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
 	input++;		/* Advance over %. */
 	input = skip_flags(input);
 	input = skip_width(input);
-	input = skip_conversion(input);
-	return input;
+	return skip_conversion(input);
 }
 
 /*
-- 
2.17.1

Re: [PATCH v2] staging: speakup: remove unnecessary assignment statement before return

[Samuel Thibault]

Himadri Pandya, le sam. 09 mars 2019 14:39:27 +0530, a ecrit:
> Remove unnecessary assignment statement before return from function
> find_specifier_end. Issue found by Coccinelle.

Well, I have to say that for style I prefer the way it was: we apply
several functions to the input variable, before returning it.

> Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
> ---
> Changes in V2:
> 	- Remove "Coccinelle" from patch tag
> 
>  drivers/staging/speakup/i18n.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index ee240d36f947..a748eb8052d1 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
>  	input++;		/* Advance over %. */
>  	input = skip_flags(input);
>  	input = skip_width(input);
> -	input = skip_conversion(input);
> -	return input;
> +	return skip_conversion(input);
>  }
>  
>  /*
> -- 
> 2.17.1
> 

Re: [Outreachy kernel] Re: [PATCH v2] staging: speakup: remove unnecessary assignment statement before return

[Himadri Pandya]

[-- Attachment #1: Type: text/plain, Size: 1761 bytes --]

On Sat, 9 Mar, 2019, 2:41 PM Samuel Thibault, <samuel.thibault@ens-lyon.org>
wrote:

> Himadri Pandya, le sam. 09 mars 2019 14:39:27 +0530, a ecrit:
> > Remove unnecessary assignment statement before return from function
> > find_specifier_end. Issue found by Coccinelle.
>
> Well, I have to say that for style I prefer the way it was: we apply
> several functions to the input variable, before returning it.
>

Okay. Thank you.

- Himadri


> > Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
> > ---
> > Changes in V2:
> >       - Remove "Coccinelle" from patch tag
> >
> >  drivers/staging/speakup/i18n.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/speakup/i18n.c
> b/drivers/staging/speakup/i18n.c
> > index ee240d36f947..a748eb8052d1 100644
> > --- a/drivers/staging/speakup/i18n.c
> > +++ b/drivers/staging/speakup/i18n.c
> > @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
> >       input++;                /* Advance over %. */
> >       input = skip_flags(input);
> >       input = skip_width(input);
> > -     input = skip_conversion(input);
> > -     return input;
> > +     return skip_conversion(input);
> >  }
> >
> >  /*
> > --
> > 2.17.1
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20190309091133.uyhjrmiipm2rahnu%40function
> .
> For more options, visit https://groups.google.com/d/optout.
>

[-- Attachment #2: Type: text/html, Size: 3103 bytes --]