From: Wei Yang <richardw.yang@linux.intel.com>
To: qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, marcel.apfelbaum@gmail.com,
pbonzini@redhat.com, Wei Yang <richardw.yang@linux.intel.com>
Subject: [Qemu-devel] [PATCH 1/2] vl.c: make find_default_machine() local
Date: Mon, 11 Mar 2019 14:08:22 +0800 [thread overview]
Message-ID: <20190311060823.18360-2-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20190311060823.18360-1-richardw.yang@linux.intel.com>
Function find_default_machine() is introduced by commit 2c8cffa599b7
"vl: make find_default_machine externally visible", while it seems no
one outside use it.
This patch make it local again.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
include/hw/boards.h | 1 -
vl.c | 4 ++--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/hw/boards.h b/include/hw/boards.h
index 21212f0859..e911d56c28 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -57,7 +57,6 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,
#define MACHINE_CLASS(klass) \
OBJECT_CLASS_CHECK(MachineClass, (klass), TYPE_MACHINE)
-MachineClass *find_default_machine(void);
extern MachineState *current_machine;
void machine_run_board_init(MachineState *machine);
diff --git a/vl.c b/vl.c
index 502857a176..3688e2bc98 100644
--- a/vl.c
+++ b/vl.c
@@ -1441,7 +1441,7 @@ static MachineClass *find_machine(const char *name)
return mc;
}
-MachineClass *find_default_machine(void)
+static MachineClass *find_default_machine(void)
{
GSList *el, *machines = object_class_get_list(TYPE_MACHINE, false);
MachineClass *mc = NULL;
@@ -2538,7 +2538,7 @@ static gint machine_class_cmp(gconstpointer a, gconstpointer b)
object_class_get_name(OBJECT_CLASS(mc1)));
}
- static MachineClass *machine_parse(const char *name)
+static MachineClass *machine_parse(const char *name)
{
MachineClass *mc = NULL;
GSList *el, *machines = object_class_get_list(TYPE_MACHINE, false);
--
2.19.1
next prev parent reply other threads:[~2019-03-11 6:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 6:08 [Qemu-devel] [PATCH 0/2] cleanup select_machine Wei Yang
2019-03-11 6:08 ` Wei Yang [this message]
2019-04-02 6:33 ` [Qemu-devel] [PATCH 1/2] vl.c: make find_default_machine() local Markus Armbruster
2019-04-02 15:07 ` Wei Yang
2019-04-02 15:17 ` Markus Armbruster
2019-03-11 6:08 ` [Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup Wei Yang
2019-04-02 13:28 ` Markus Armbruster
2019-04-02 15:16 ` Wei Yang
2019-04-02 16:10 ` Markus Armbruster
2019-04-03 0:49 ` Wei Yang
2019-04-03 6:15 ` Markus Armbruster
2019-04-02 13:26 ` [Qemu-devel] [PATCH 3/4] vl: Clean up after previous commit Markus Armbruster
2019-04-03 22:10 ` Wei Yang
2019-04-04 15:49 ` Markus Armbruster
2019-04-02 13:26 ` [Qemu-devel] [PATCH 4/4] vl: Simplify machine_parse() Markus Armbruster
2019-04-03 22:32 ` Wei Yang
2019-04-04 16:05 ` Markus Armbruster
2019-04-04 23:15 ` Wei Yang
2019-04-04 23:15 ` Wei Yang
2019-04-05 5:39 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311060823.18360-2-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=ehabkost@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.