From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Ming Lei <ming.lei@redhat.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: Re: NVMe: Regression: write zeros corrupts ext4 file system
Date: Mon, 11 Mar 2019 16:23:31 +0100 [thread overview]
Message-ID: <20190311152331.GA9000@lst.de> (raw)
In-Reply-To: <20190311145457.GA10411@localhost.localdomain>
On Mon, Mar 11, 2019 at 08:54:59AM -0600, Keith Busch wrote:
> In QEMU, blk_aio_pwrite_zeroes() takes bytes, but the nvme controller
> thought it was blocks. Oops, that went by unnoticed till now!
>
> We should fix QEMU (patch below). Question is, should we quirk driver
> for older versions too?
I think we should. We are actually still quirking all qemu controllers
for broken Identify behavior, at some point we'll have to make them
version specific..
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: NVMe: Regression: write zeros corrupts ext4 file system
Date: Mon, 11 Mar 2019 16:23:31 +0100 [thread overview]
Message-ID: <20190311152331.GA9000@lst.de> (raw)
In-Reply-To: <20190311145457.GA10411@localhost.localdomain>
On Mon, Mar 11, 2019@08:54:59AM -0600, Keith Busch wrote:
> In QEMU, blk_aio_pwrite_zeroes() takes bytes, but the nvme controller
> thought it was blocks. Oops, that went by unnoticed till now!
>
> We should fix QEMU (patch below). Question is, should we quirk driver
> for older versions too?
I think we should. We are actually still quirking all qemu controllers
for broken Identify behavior, at some point we'll have to make them
version specific..
next prev parent reply other threads:[~2019-03-11 15:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 2:24 NVMe: Regression: write zeros corrupts ext4 file system Ming Lei
2019-03-11 2:24 ` Ming Lei
2019-03-11 7:54 ` Dongli Zhang
2019-03-11 7:54 ` Dongli Zhang
2019-03-11 10:16 ` Ming Lei
2019-03-11 10:16 ` Ming Lei
2019-03-11 14:54 ` Keith Busch
2019-03-11 14:54 ` Keith Busch
2019-03-11 15:23 ` Christoph Hellwig [this message]
2019-03-11 15:23 ` Christoph Hellwig
2019-03-12 1:32 ` Ming Lei
2019-03-12 1:32 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311152331.GA9000@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.