All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Schnelle <svens@stackframe.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, Sven Schnelle <svens@stackframe.org>,
	Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 06/11] target/hppa: ignore DIAG opcode
Date: Mon, 11 Mar 2019 20:15:57 +0100	[thread overview]
Message-ID: <20190311191602.25796-7-svens@stackframe.org> (raw)
In-Reply-To: <20190311191602.25796-1-svens@stackframe.org>

DIAG is usually only used by diagnostics software as it's CPU
specific. In most of the cases it's better to ignore it and log
a message that it's not implemented.

Signed-off-by: Sven Schnelle <svens@stackframe.org>
---
 target/hppa/insns.decode | 3 +++
 target/hppa/translate.c  | 6 ++++++
 2 files changed, 9 insertions(+)

diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode
index 55ff39dd05..098370c2f0 100644
--- a/target/hppa/insns.decode
+++ b/target/hppa/insns.decode
@@ -525,3 +525,6 @@ fmpy_d          001110 ..... ..... 010 ..... ... .....  @f0e_d_3
 fdiv_d          001110 ..... ..... 011 ..... ... .....  @f0e_d_3
 
 xmpyu           001110 ..... ..... 010 .0111 .00 t:5    r1=%ra64 r2=%rb64
+
+# diag
+diag            000101 ----- ----- ---- ---- ---- ----
diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index 7001c2eb80..441f0ea9d6 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -4292,3 +4292,9 @@ void restore_state_to_opc(CPUHPPAState *env, TranslationBlock *tb,
        that the instruction was not nullified.  */
     env->psw_n = 0;
 }
+
+static bool trans_diag(DisasContext *ctx, arg_diag *a)
+{
+    qemu_log_mask(LOG_UNIMP, "DIAG opcode ignored\n");
+    return true;
+}
-- 
2.20.1

  parent reply	other threads:[~2019-03-11 19:28 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11 19:15 [Qemu-devel] [PATCH 00/11] target/hppa patches Sven Schnelle
2019-03-11 19:15 ` [Qemu-devel] [PATCH 01/11] target/hppa: fix overwriting source reg in addb Sven Schnelle
2019-03-12  3:24   ` Richard Henderson
2019-03-11 19:15 ` [Qemu-devel] [PATCH 02/11] target/hppa: fix TLB handling for page 0 Sven Schnelle
2019-03-12  3:24   ` Richard Henderson
2019-03-11 19:15 ` [Qemu-devel] [PATCH 03/11] target/hppa: report ITLB_EXCP_MISS for ITLB misses Sven Schnelle
2019-03-12  3:26   ` Richard Henderson
2019-03-11 19:15 ` [Qemu-devel] [PATCH 04/11] target/hppa: add TLB trace events Sven Schnelle
2019-03-12  3:26   ` Richard Henderson
2019-03-11 19:15 ` [Qemu-devel] [PATCH 05/11] target/hppa: remove PSW I/R/Q bit check Sven Schnelle
2019-03-12  3:26   ` Richard Henderson
2019-03-11 19:15 ` Sven Schnelle [this message]
2019-03-12  0:22   ` [Qemu-devel] [PATCH 06/11] target/hppa: ignore DIAG opcode Richard Henderson
2019-03-11 19:15 ` [Qemu-devel] [PATCH 07/11] target/hppa: fix b,gate instruction Sven Schnelle
2019-03-12  1:17   ` Richard Henderson
2019-03-11 19:15 ` [Qemu-devel] [PATCH 08/11] target/hppa: allow multiple itlbp without itlba Sven Schnelle
2019-03-12  1:22   ` Richard Henderson
2019-03-11 19:16 ` [Qemu-devel] [PATCH 09/11] target/hppa: add TLB protection id check Sven Schnelle
2019-03-12  3:23   ` Richard Henderson
2019-03-11 19:16 ` [Qemu-devel] [PATCH 10/11] target/hppa: exit TB if either Data or Instruction TLB changes Sven Schnelle
2019-03-12  3:27   ` Richard Henderson
2019-03-11 19:16 ` [Qemu-devel] [PATCH 11/11] target/hppa: call eval_interrupt() after ssm Sven Schnelle
2019-03-12  3:28   ` Richard Henderson
2019-03-12  4:01     ` Richard Henderson
2019-03-11 19:48 ` [Qemu-devel] [PATCH 00/11] target/hppa patches no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190311191602.25796-7-svens@stackframe.org \
    --to=svens@stackframe.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.