All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Branden Bonaby <brandonbonaby94@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: octeon: Lines should not end with a '('
Date: Mon, 11 Mar 2019 15:51:20 -0700	[thread overview]
Message-ID: <20190311225120.GA569@kroah.com> (raw)
In-Reply-To: <20190310211430.27369-1-brandonbonaby94@gmail.com>

On Sun, Mar 10, 2019 at 05:14:30PM -0400, Branden Bonaby wrote:
> Start function arguments immediately after opening bracket.
> CHECK: Lines should not end with a '('.
> 
> Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
> ---
>  drivers/staging/octeon/ethernet-tx.c | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)

Is this a v2 patch?  You sent 2 patches with the same subject and
changelog, but the patches do different things, which is very confusing.

Please fix this up and resend both as a properly versioned patch.

thanks,

greg k-h


  reply	other threads:[~2019-03-11 22:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-10 21:14 [PATCH] staging: octeon: Lines should not end with a '(' Branden Bonaby
2019-03-11 22:51 ` Greg KH [this message]
2019-03-11 23:30   ` Branden Bonaby
  -- strict thread matches above, loose matches on Subject: below --
2019-03-10  0:06 Branden Bonaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190311225120.GA569@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=brandonbonaby94@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.