[PATCH] staging: octeon: Lines should not end with a '('

[PATCH] staging: octeon: Lines should not end with a '('

[Branden Bonaby]

Start function arguments immediately after opening bracket.
CHECK: Lines should not end with a '('.

Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
---
 drivers/staging/octeon/ethernet-tx.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c
index f89b309ffa6f..20f513fbaa85 100644
--- a/drivers/staging/octeon/ethernet-tx.c
+++ b/drivers/staging/octeon/ethernet-tx.c
@@ -214,8 +214,10 @@ int cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
 				 * Get the number of skbuffs in use
 				 * by the hardware
 				 */
-				skb_to_free = cvmx_fau_fetch_and_add32(
-					priv->fau + qos * 4, MAX_SKB_TO_FREE);
+				skb_to_free =
+				     cvmx_fau_fetch_and_add32(priv->fau +
+							      qos * 4,
+							      MAX_SKB_TO_FREE);
 			}
 			skb_to_free = cvm_oct_adjust_skb_to_free(skb_to_free,
 								 priv->fau +
@@ -280,9 +282,9 @@ int cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
 		for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) {
 			struct skb_frag_struct *fs = skb_shinfo(skb)->frags + i;
 
-			hw_buffer.s.addr = XKPHYS_TO_PHYS(
-				(u64)(page_address(fs->page.p) +
-				fs->page_offset));
+			hw_buffer.s.addr =
+				XKPHYS_TO_PHYS((u64)(page_address(fs->page.p) +
+					       fs->page_offset));
 			hw_buffer.s.size = fs->size;
 			CVM_OCT_SKB_CB(skb)[i + 1] = hw_buffer.u64;
 		}
@@ -491,8 +493,8 @@ int cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
 		cvmx_scratch_write64(CVMX_SCR_SCRATCH, old_scratch);
 		cvmx_scratch_write64(CVMX_SCR_SCRATCH + 8, old_scratch2);
 	} else {
-		total_to_clean = cvmx_fau_fetch_and_add32(
-						FAU_TOTAL_TX_TO_CLEAN, 1);
+		total_to_clean =
+			cvmx_fau_fetch_and_add32(FAU_TOTAL_TX_TO_CLEAN, 1);
 	}
 
 	if (total_to_clean & 0x3ff) {
-- 
2.17.1

Re: [PATCH] staging: octeon: Lines should not end with a '('

[Greg KH]

On Sun, Mar 10, 2019 at 05:14:30PM -0400, Branden Bonaby wrote:
> Start function arguments immediately after opening bracket.
> CHECK: Lines should not end with a '('.
> 
> Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
> ---
>  drivers/staging/octeon/ethernet-tx.c | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)

Is this a v2 patch?  You sent 2 patches with the same subject and
changelog, but the patches do different things, which is very confusing.

Please fix this up and resend both as a properly versioned patch.

thanks,

greg k-h

Re: [PATCH] staging: octeon: Lines should not end with a '('

[Branden Bonaby]

On Mon, Mar 11, 2019 at 03:51:20PM -0700, Greg KH wrote:
> On Sun, Mar 10, 2019 at 05:14:30PM -0400, Branden Bonaby wrote:
> > Start function arguments immediately after opening bracket.
> > CHECK: Lines should not end with a '('.
> > 
> > Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
> > ---
> >  drivers/staging/octeon/ethernet-tx.c | 16 +++++++++-------
> >  1 file changed, 9 insertions(+), 7 deletions(-)
> 
> Is this a v2 patch?  You sent 2 patches with the same subject and
> changelog, but the patches do different things, which is very confusing.
> 
> Please fix this up and resend both as a properly versioned patch.
> 
> thanks,
> 
> greg k-h

Hey Greg

So what happened was I sent both patches as individual patches
and since they had the same subject they now showed up under 
eachother in the google groups. What I realize now is it probably 
doesnt make any since to split a patch into 2 when they both do the
same thing in the same files. What I will do is send a new patch with 
PATCH v2 as the subject and include the changes I did in the other
2 patches as 1 patch.

Branden Bonaby

[PATCH] staging: octeon: Lines should not end with a '('

[Branden Bonaby]

Start function arguments immediately after opening bracket.
CHECK: Lines should not end with a '('.

Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
---
 drivers/staging/octeon/ethernet-tx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c
index 317c9720467c..f89b309ffa6f 100644
--- a/drivers/staging/octeon/ethernet-tx.c
+++ b/drivers/staging/octeon/ethernet-tx.c
@@ -413,8 +413,8 @@ int cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
 		queue_type = QUEUE_HW;
 	}
 	if (USE_ASYNC_IOBDMA)
-		cvmx_fau_async_fetch_and_add32(
-				CVMX_SCR_SCRATCH, FAU_TOTAL_TX_TO_CLEAN, 1);
+		cvmx_fau_async_fetch_and_add32(CVMX_SCR_SCRATCH,
+					       FAU_TOTAL_TX_TO_CLEAN, 1);
 
 	spin_lock_irqsave(&priv->tx_free_list[qos].lock, flags);
 
-- 
2.17.1