Re: [PATCH] Fix spinlock_t definition without comment warning

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Mar 09, 2019 at 10:18:10PM +0000, Jules Irenge wrote:
> Fix checkpatch issue: "CHECK: spinlock_t definition without comment".
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/gdm724x/gdm_mux.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/gdm724x/gdm_mux.h b/drivers/staging/gdm724x/gdm_mux.h
> index 51c22e3d8aeb..f1169d7e10c1 100644
> --- a/drivers/staging/gdm724x/gdm_mux.h
> +++ b/drivers/staging/gdm724x/gdm_mux.h
> @@ -60,7 +60,7 @@ struct rx_cxt {
>  	struct list_head to_host_list;
>  	struct list_head rx_submit_list;
>  	struct list_head rx_free_list;
> -	spinlock_t to_host_lock;
> +	spinlock_t to_host_lock; /* spinlock for to_host command handling */

Are you sure about this?  Please document why this is true somehow in
the changelog text so we feel good about it :)

Also, the subject: needs to be fixed up to show the subsystem (staging),
and the driver name.  See the other patches on the mailing list for the
proper format.

thanks,

greg k-h

>  	spinlock_t submit_list_lock;
>  	spinlock_t free_list_lock;
>  };
> -- 
> 2.20.1
>