* [PATCH] Fix spinlock_t definition without comment warning
@ 2019-03-09 22:18 Jules Irenge
2019-03-11 22:56 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jules Irenge @ 2019-03-09 22:18 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Fix checkpatch issue: "CHECK: spinlock_t definition without comment".
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/gdm724x/gdm_mux.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.h b/drivers/staging/gdm724x/gdm_mux.h
index 51c22e3d8aeb..f1169d7e10c1 100644
--- a/drivers/staging/gdm724x/gdm_mux.h
+++ b/drivers/staging/gdm724x/gdm_mux.h
@@ -60,7 +60,7 @@ struct rx_cxt {
struct list_head to_host_list;
struct list_head rx_submit_list;
struct list_head rx_free_list;
- spinlock_t to_host_lock;
+ spinlock_t to_host_lock; /* spinlock for to_host command handling */
spinlock_t submit_list_lock;
spinlock_t free_list_lock;
};
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Fix spinlock_t definition without comment warning
2019-03-09 22:18 [PATCH] Fix spinlock_t definition without comment warning Jules Irenge
@ 2019-03-11 22:56 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-03-11 22:56 UTC (permalink / raw)
To: Jules Irenge; +Cc: outreachy-kernel
On Sat, Mar 09, 2019 at 10:18:10PM +0000, Jules Irenge wrote:
> Fix checkpatch issue: "CHECK: spinlock_t definition without comment".
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/gdm724x/gdm_mux.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_mux.h b/drivers/staging/gdm724x/gdm_mux.h
> index 51c22e3d8aeb..f1169d7e10c1 100644
> --- a/drivers/staging/gdm724x/gdm_mux.h
> +++ b/drivers/staging/gdm724x/gdm_mux.h
> @@ -60,7 +60,7 @@ struct rx_cxt {
> struct list_head to_host_list;
> struct list_head rx_submit_list;
> struct list_head rx_free_list;
> - spinlock_t to_host_lock;
> + spinlock_t to_host_lock; /* spinlock for to_host command handling */
Are you sure about this? Please document why this is true somehow in
the changelog text so we feel good about it :)
Also, the subject: needs to be fixed up to show the subsystem (staging),
and the driver name. See the other patches on the mailing list for the
proper format.
thanks,
greg k-h
> spinlock_t submit_list_lock;
> spinlock_t free_list_lock;
> };
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-11 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-09 22:18 [PATCH] Fix spinlock_t definition without comment warning Jules Irenge
2019-03-11 22:56 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.