* [PATCH v5 1/2] staging: fbtft: line over 80 characters.
@ 2019-03-09 15:38 Bhagyashri Dighole
2019-03-11 23:07 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Bhagyashri Dighole @ 2019-03-09 15:38 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Outreachy
Fix coding style issues, which solves checkpatch.pl warning:
"WARNING: line over 80 characters".
Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
---
Changes in v5:
- Make patch series.
Changes in v4:
- Convert a ternary statement into a if statement.
Changes in v3:
- Make the code in original form.
- Use tab to line up the code.
Changes in v2:
- Improve code order.
- Make the code more readable.
drivers/staging/fbtft/fb_ssd1331.c | 3 ++-
drivers/staging/fbtft/fbtft.h | 14 +++++++++++---
drivers/staging/fbtft/flexfb.c | 3 ++-
3 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c
index 9f54fe2..4cfe9f8 100644
--- a/drivers/staging/fbtft/fb_ssd1331.c
+++ b/drivers/staging/fbtft/fb_ssd1331.c
@@ -74,7 +74,8 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)
for (i = 0; i < len; i++)
buf[i] = (u8)va_arg(args, unsigned int);
va_end(args);
- fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device, u8, buf, len, "%s: ", __func__);
+ fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device,
+ u8, buf, len, "%s: ", __func__);
}
va_start(args, len);
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 7fdd3b0..c265aff 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b/drivers/staging/fbtft/fbtft.h
@@ -347,9 +347,17 @@ module_exit(fbtft_driver_module_exit);
/* shorthand debug levels */
#define DEBUG_LEVEL_1 DEBUG_REQUEST_GPIOS
-#define DEBUG_LEVEL_2 (DEBUG_LEVEL_1 | DEBUG_DRIVER_INIT_FUNCTIONS | DEBUG_TIME_FIRST_UPDATE)
-#define DEBUG_LEVEL_3 (DEBUG_LEVEL_2 | DEBUG_RESET | DEBUG_INIT_DISPLAY | DEBUG_BLANK | DEBUG_REQUEST_GPIOS | DEBUG_FREE_GPIOS | DEBUG_VERIFY_GPIOS | DEBUG_BACKLIGHT | DEBUG_SYSFS)
-#define DEBUG_LEVEL_4 (DEBUG_LEVEL_2 | DEBUG_FB_READ | DEBUG_FB_WRITE | DEBUG_FB_FILLRECT | DEBUG_FB_COPYAREA | DEBUG_FB_IMAGEBLIT | DEBUG_FB_BLANK)
+#define DEBUG_LEVEL_2 (DEBUG_LEVEL_1 | DEBUG_DRIVER_INIT_FUNCTIONS | \
+ DEBUG_TIME_FIRST_UPDATE) \
+#define DEBUG_LEVEL_3 (DEBUG_LEVEL_2 | DEBUG_RESET | \
+ DEBUG_INIT_DISPLAY | DEBUG_BLANK | \
+ DEBUG_REQUEST_GPIOS | DEBUG_FREE_GPIOS | \
+ DEBUG_VERIFY_GPIOS | DEBUG_BACKLIGHT | \
+ DEBUG_SYSFS) \
+#define DEBUG_LEVEL_4 (DEBUG_LEVEL_2 | DEBUG_FB_READ | \
+ DEBUG_FB_WRITE | DEBUG_FB_FILLRECT | \
+ DEBUG_FB_COPYAREA | DEBUG_FB_IMAGEBLIT | \
+ DEBUG_FB_BLANK) \
#define DEBUG_LEVEL_5 (DEBUG_LEVEL_3 | DEBUG_UPDATE_DISPLAY)
#define DEBUG_LEVEL_6 (DEBUG_LEVEL_4 | DEBUG_LEVEL_5)
#define DEBUG_LEVEL_7 0xFFFFFFFF
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
index b91b459..3747321 100644
--- a/drivers/staging/fbtft/flexfb.c
+++ b/drivers/staging/fbtft/flexfb.c
@@ -671,7 +671,8 @@ static int flexfb_probe_common(struct spi_device *sdev,
break;
case 9:
if (regwidth == 16) {
- dev_err(dev, "argument 'regwidth': %d is not supported with buswidth=%d and SPI.\n", regwidth, buswidth);
+ dev_err(dev, "argument 'regwidth': %d is not supported with buswidth=%d and SPI.\n",
+ regwidth, buswidth);
return -EINVAL;
}
par->fbtftops.write_register = fbtft_write_reg8_bus9;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v5 1/2] staging: fbtft: line over 80 characters.
2019-03-09 15:38 [PATCH v5 1/2] staging: fbtft: line over 80 characters Bhagyashri Dighole
@ 2019-03-11 23:07 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2019-03-11 23:07 UTC (permalink / raw)
To: Bhagyashri Dighole; +Cc: Outreachy
On Sat, Mar 09, 2019 at 09:08:13PM +0530, Bhagyashri Dighole wrote:
> Fix coding style issues, which solves checkpatch.pl warning:
> "WARNING: line over 80 characters".
>
> Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
> ---
> Changes in v5:
> - Make patch series.
>
> Changes in v4:
> - Convert a ternary statement into a if statement.
>
> Changes in v3:
> - Make the code in original form.
> - Use tab to line up the code.
>
> Changes in v2:
> - Improve code order.
> - Make the code more readable.
>
> drivers/staging/fbtft/fb_ssd1331.c | 3 ++-
> drivers/staging/fbtft/fbtft.h | 14 +++++++++++---
> drivers/staging/fbtft/flexfb.c | 3 ++-
> 3 files changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c
> index 9f54fe2..4cfe9f8 100644
> --- a/drivers/staging/fbtft/fb_ssd1331.c
> +++ b/drivers/staging/fbtft/fb_ssd1331.c
> @@ -74,7 +74,8 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)
> for (i = 0; i < len; i++)
> buf[i] = (u8)va_arg(args, unsigned int);
> va_end(args);
> - fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device, u8, buf, len, "%s: ", __func__);
> + fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device,
> + u8, buf, len, "%s: ", __func__);
> }
>
> va_start(args, len);
> diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
> index 7fdd3b0..c265aff 100644
> --- a/drivers/staging/fbtft/fbtft.h
> +++ b/drivers/staging/fbtft/fbtft.h
> @@ -347,9 +347,17 @@ module_exit(fbtft_driver_module_exit);
>
> /* shorthand debug levels */
> #define DEBUG_LEVEL_1 DEBUG_REQUEST_GPIOS
> -#define DEBUG_LEVEL_2 (DEBUG_LEVEL_1 | DEBUG_DRIVER_INIT_FUNCTIONS | DEBUG_TIME_FIRST_UPDATE)
> -#define DEBUG_LEVEL_3 (DEBUG_LEVEL_2 | DEBUG_RESET | DEBUG_INIT_DISPLAY | DEBUG_BLANK | DEBUG_REQUEST_GPIOS | DEBUG_FREE_GPIOS | DEBUG_VERIFY_GPIOS | DEBUG_BACKLIGHT | DEBUG_SYSFS)
> -#define DEBUG_LEVEL_4 (DEBUG_LEVEL_2 | DEBUG_FB_READ | DEBUG_FB_WRITE | DEBUG_FB_FILLRECT | DEBUG_FB_COPYAREA | DEBUG_FB_IMAGEBLIT | DEBUG_FB_BLANK)
> +#define DEBUG_LEVEL_2 (DEBUG_LEVEL_1 | DEBUG_DRIVER_INIT_FUNCTIONS | \
> + DEBUG_TIME_FIRST_UPDATE) \
> +#define DEBUG_LEVEL_3 (DEBUG_LEVEL_2 | DEBUG_RESET | \
> + DEBUG_INIT_DISPLAY | DEBUG_BLANK | \
> + DEBUG_REQUEST_GPIOS | DEBUG_FREE_GPIOS | \
> + DEBUG_VERIFY_GPIOS | DEBUG_BACKLIGHT | \
> + DEBUG_SYSFS) \
> +#define DEBUG_LEVEL_4 (DEBUG_LEVEL_2 | DEBUG_FB_READ | \
> + DEBUG_FB_WRITE | DEBUG_FB_FILLRECT | \
> + DEBUG_FB_COPYAREA | DEBUG_FB_IMAGEBLIT | \
> + DEBUG_FB_BLANK) \
> #define DEBUG_LEVEL_5 (DEBUG_LEVEL_3 | DEBUG_UPDATE_DISPLAY)
> #define DEBUG_LEVEL_6 (DEBUG_LEVEL_4 | DEBUG_LEVEL_5)
> #define DEBUG_LEVEL_7 0xFFFFFFFF
You did not build this change :(
ALWAYS test build your patches, otherwise you will get emails from
grumpy maintainers complaining when you broke their build systems :)
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-11 23:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-09 15:38 [PATCH v5 1/2] staging: fbtft: line over 80 characters Bhagyashri Dighole
2019-03-11 23:07 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.