[virtio] [PATCH v2] signal start and end of structures consistently

[virtio] [PATCH v2] signal start and end of structures consistently

[Michael S. Tsirkin]

Make sure all structs have the format:

struct X {
...
};

VIRTIO-170

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Changes since v1:
	no text changes, fix typo in commit log reported by Cornelia

 content.tex    | 11 +++++------
 virtio-gpu.tex |  2 +-
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/content.tex b/content.tex
index 4180296..f40d4fc 100644
--- a/content.tex
+++ b/content.tex
@@ -5272,8 +5272,7 @@ The following commands are defined:
 #define VIRTIO_SCSI_T_TMF_QUERY_TASK           6
 #define VIRTIO_SCSI_T_TMF_QUERY_TASK_SET       7
 
-struct virtio_scsi_ctrl_tmf
-{
+struct virtio_scsi_ctrl_tmf {
         // Device-readable part
         le32 type;
         le32 subtype;
@@ -5281,7 +5280,7 @@ struct virtio_scsi_ctrl_tmf
         le64 id;
         // Device-writable part
         u8   response;
-}
+};
 
 /* command-specific response values */
 #define VIRTIO_SCSI_S_FUNCTION_COMPLETE        0
@@ -5328,7 +5327,7 @@ struct virtio_scsi_ctrl_an {
     // Device-writable part
     le32 event_actual;
     u8   response;
-}
+};
 
 #define VIRTIO_SCSI_EVT_ASYNC_OPERATIONAL_CHANGE  2
 #define VIRTIO_SCSI_EVT_ASYNC_POWER_MGMT          4
@@ -5363,7 +5362,7 @@ struct virtio_scsi_ctrl_an {
         // Device-writable part
         le32 event_actual;
         u8   response;
-}
+};
 \end{lstlisting}
 
   By sending this command, the driver asks the specified LUN to
@@ -5415,7 +5414,7 @@ struct virtio_scsi_event {
         le32 event;
         u8  lun[8];
         le32 reason;
-}
+};
 \end{lstlisting}
 
 The devices sets bit 31 in \field{event} to report lost events
diff --git a/virtio-gpu.tex b/virtio-gpu.tex
index 0cf2209..992d4e6 100644
--- a/virtio-gpu.tex
+++ b/virtio-gpu.tex
@@ -47,7 +47,7 @@ struct virtio_gpu_config {
         le32 events_clear;
         le32 num_scanouts;
         le32 reserved;
-}
+};
 \end{lstlisting}
 
 \subsubsection{Device configuration fields}
-- 
MST

---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 

Re: [virtio] [PATCH v2] signal start and end of structures consistently

[Cornelia Huck]

On Mon, 11 Mar 2019 14:18:48 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> Make sure all structs have the format:
> 
> struct X {
> ...
> };
> 
> VIRTIO-170
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> Changes since v1:
> 	no text changes, fix typo in commit log reported by Cornelia
> 
>  content.tex    | 11 +++++------
>  virtio-gpu.tex |  2 +-
>  2 files changed, 6 insertions(+), 7 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 

[virtio] Re: [virtio-dev] [PATCH v2] signal start and end of structures consistently

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

On Mon, Mar 11, 2019 at 02:18:48PM -0400, Michael S. Tsirkin wrote:
> Make sure all structs have the format:
> 
> struct X {
> ...
> };
> 
> VIRTIO-170
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> Changes since v1:
> 	no text changes, fix typo in commit log reported by Cornelia
> 
>  content.tex    | 11 +++++------
>  virtio-gpu.tex |  2 +-
>  2 files changed, 6 insertions(+), 7 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]