* [PATCH] scsi: qla2xxx: Fix a small typo in qla_bsg.c
@ 2019-03-12 11:53 ` Milan P. Gandhi
0 siblings, 0 replies; 4+ messages in thread
From: Milan P. Gandhi @ 2019-03-12 11:53 UTC (permalink / raw)
To: kernel-janitors
Cc: qla2xxx-upstream, jejb, martin.petersen, linux-scsi, linux-kernel
This patch fixes a minor formatting issue with comment section and a
typo for 'iiDMA' cmd in drivers/scsi/qla2xxx/qla_bsg.c
Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
---
diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
index 17d42658ad9a..2353be988907 100644
--- a/drivers/scsi/qla2xxx/qla_bsg.c
+++ b/drivers/scsi/qla2xxx/qla_bsg.c
@@ -1,4 +1,4 @@
- /*
+/*
* QLogic Fibre Channel HBA Driver
* Copyright (c) 2003-2014 QLogic Corporation
*
@@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)
if (rval) {
ql_log(ql_log_warn, vha, 0x704c,
- "iIDMA cmd failed for %8phN -- "
+ "iiDMA cmd failed for %8phN -- "
"%04x %x %04x %04x.\n", fcport->port_name,
rval, fcport->fp_speed, mb[0], mb[1]);
rval = (DID_ERROR << 16);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] scsi: qla2xxx: Fix a small typo in qla_bsg.c
@ 2019-03-12 11:53 ` Milan P. Gandhi
0 siblings, 0 replies; 4+ messages in thread
From: Milan P. Gandhi @ 2019-03-12 11:53 UTC (permalink / raw)
To: kernel-janitors
Cc: qla2xxx-upstream, jejb, martin.petersen, linux-scsi, linux-kernel
This patch fixes a minor formatting issue with comment section and a
typo for 'iiDMA' cmd in drivers/scsi/qla2xxx/qla_bsg.c
Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
---
diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
index 17d42658ad9a..2353be988907 100644
--- a/drivers/scsi/qla2xxx/qla_bsg.c
+++ b/drivers/scsi/qla2xxx/qla_bsg.c
@@ -1,4 +1,4 @@
- /*
+/*
* QLogic Fibre Channel HBA Driver
* Copyright (c) 2003-2014 QLogic Corporation
*
@@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)
if (rval) {
ql_log(ql_log_warn, vha, 0x704c,
- "iIDMA cmd failed for %8phN -- "
+ "iiDMA cmd failed for %8phN -- "
"%04x %x %04x %04x.\n", fcport->port_name,
rval, fcport->fp_speed, mb[0], mb[1]);
rval = (DID_ERROR << 16);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: qla2xxx: Fix a small typo in qla_bsg.c
2019-03-12 11:53 ` Milan P. Gandhi
@ 2019-03-12 12:06 ` Julia Lawall
-1 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2019-03-12 12:06 UTC (permalink / raw)
To: Milan P. Gandhi
Cc: kernel-janitors, qla2xxx-upstream, jejb, martin.petersen,
linux-scsi, linux-kernel
On Tue, 12 Mar 2019, Milan P. Gandhi wrote:
> This patch fixes a minor formatting issue with comment section and a
> typo for 'iiDMA' cmd in drivers/scsi/qla2xxx/qla_bsg.c
This seems to be two completely unrelated changes. The subject line
promises only one change, and indeed only one change per patch would have
been better. You should make a series.
julia
>
> Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
> ---
> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
> index 17d42658ad9a..2353be988907 100644
> --- a/drivers/scsi/qla2xxx/qla_bsg.c
> +++ b/drivers/scsi/qla2xxx/qla_bsg.c
> @@ -1,4 +1,4 @@
> - /*
> +/*
> * QLogic Fibre Channel HBA Driver
> * Copyright (c) 2003-2014 QLogic Corporation
> *
> @@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)
>
> if (rval) {
> ql_log(ql_log_warn, vha, 0x704c,
> - "iIDMA cmd failed for %8phN -- "
> + "iiDMA cmd failed for %8phN -- "
> "%04x %x %04x %04x.\n", fcport->port_name,
> rval, fcport->fp_speed, mb[0], mb[1]);
> rval = (DID_ERROR << 16);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: qla2xxx: Fix a small typo in qla_bsg.c
@ 2019-03-12 12:06 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2019-03-12 12:06 UTC (permalink / raw)
To: Milan P. Gandhi
Cc: kernel-janitors, qla2xxx-upstream, jejb, martin.petersen,
linux-scsi, linux-kernel
On Tue, 12 Mar 2019, Milan P. Gandhi wrote:
> This patch fixes a minor formatting issue with comment section and a
> typo for 'iiDMA' cmd in drivers/scsi/qla2xxx/qla_bsg.c
This seems to be two completely unrelated changes. The subject line
promises only one change, and indeed only one change per patch would have
been better. You should make a series.
julia
>
> Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
> ---
> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
> index 17d42658ad9a..2353be988907 100644
> --- a/drivers/scsi/qla2xxx/qla_bsg.c
> +++ b/drivers/scsi/qla2xxx/qla_bsg.c
> @@ -1,4 +1,4 @@
> - /*
> +/*
> * QLogic Fibre Channel HBA Driver
> * Copyright (c) 2003-2014 QLogic Corporation
> *
> @@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)
>
> if (rval) {
> ql_log(ql_log_warn, vha, 0x704c,
> - "iIDMA cmd failed for %8phN -- "
> + "iiDMA cmd failed for %8phN -- "
> "%04x %x %04x %04x.\n", fcport->port_name,
> rval, fcport->fp_speed, mb[0], mb[1]);
> rval = (DID_ERROR << 16);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-12 12:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-12 11:53 [PATCH] scsi: qla2xxx: Fix a small typo in qla_bsg.c Milan P. Gandhi
2019-03-12 11:53 ` Milan P. Gandhi
2019-03-12 12:06 ` Julia Lawall
2019-03-12 12:06 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.