* [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: use PCIE_MMCFG_BUS to retrieve end_bus_number
@ 2019-03-12 7:49 Wei Yang
2019-03-12 8:26 ` [Qemu-arm] " Auger Eric
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wei Yang @ 2019-03-12 7:49 UTC (permalink / raw)
To: qemu-arm, qemu-devel; +Cc: imammedo, shannon.zhaosl, Wei Yang, mst
This is more proper to use PCIE_MMCFG_BUS to retrieve end_bus_number.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
hw/arm/virt-acpi-build.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index d7e2e4885b..57679a89bf 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -560,8 +560,8 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
/* Only a single allocation so no need to play with segments */
mcfg->allocation[0].pci_segment = cpu_to_le16(0);
mcfg->allocation[0].start_bus_number = 0;
- mcfg->allocation[0].end_bus_number = (memmap[ecam_id].size
- / PCIE_MMCFG_SIZE_MIN) - 1;
+ mcfg->allocation[0].end_bus_number =
+ PCIE_MMCFG_BUS(memmap[ecam_id].size - 1);
build_header(linker, table_data, (void *)(table_data->data + mcfg_start),
"MCFG", table_data->len - mcfg_start, 1, NULL, NULL);
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-arm] [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: use PCIE_MMCFG_BUS to retrieve end_bus_number
2019-03-12 7:49 [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: use PCIE_MMCFG_BUS to retrieve end_bus_number Wei Yang
@ 2019-03-12 8:26 ` Auger Eric
2019-03-13 11:48 ` Igor Mammedov
2019-03-14 13:41 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Auger Eric @ 2019-03-12 8:26 UTC (permalink / raw)
To: Wei Yang, qemu-arm, qemu-devel; +Cc: imammedo, mst, shannon.zhaosl
Hi
On 3/12/19 8:49 AM, Wei Yang wrote:
> This is more proper to use PCIE_MMCFG_BUS to retrieve end_bus_number.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
> ---
> hw/arm/virt-acpi-build.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index d7e2e4885b..57679a89bf 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -560,8 +560,8 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
> /* Only a single allocation so no need to play with segments */
> mcfg->allocation[0].pci_segment = cpu_to_le16(0);
> mcfg->allocation[0].start_bus_number = 0;
> - mcfg->allocation[0].end_bus_number = (memmap[ecam_id].size
> - / PCIE_MMCFG_SIZE_MIN) - 1;
> + mcfg->allocation[0].end_bus_number =
> + PCIE_MMCFG_BUS(memmap[ecam_id].size - 1);
>
> build_header(linker, table_data, (void *)(table_data->data + mcfg_start),
> "MCFG", table_data->len - mcfg_start, 1, NULL, NULL);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: use PCIE_MMCFG_BUS to retrieve end_bus_number
2019-03-12 7:49 [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: use PCIE_MMCFG_BUS to retrieve end_bus_number Wei Yang
2019-03-12 8:26 ` [Qemu-arm] " Auger Eric
@ 2019-03-13 11:48 ` Igor Mammedov
2019-03-14 13:41 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Igor Mammedov @ 2019-03-13 11:48 UTC (permalink / raw)
To: Wei Yang; +Cc: shannon.zhaosl, qemu-arm, qemu-devel, mst
On Tue, 12 Mar 2019 15:49:53 +0800
Wei Yang <richardw.yang@linux.intel.com> wrote:
> This is more proper to use PCIE_MMCFG_BUS to retrieve end_bus_number.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/arm/virt-acpi-build.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index d7e2e4885b..57679a89bf 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -560,8 +560,8 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
> /* Only a single allocation so no need to play with segments */
> mcfg->allocation[0].pci_segment = cpu_to_le16(0);
> mcfg->allocation[0].start_bus_number = 0;
> - mcfg->allocation[0].end_bus_number = (memmap[ecam_id].size
> - / PCIE_MMCFG_SIZE_MIN) - 1;
> + mcfg->allocation[0].end_bus_number =
> + PCIE_MMCFG_BUS(memmap[ecam_id].size - 1);
>
> build_header(linker, table_data, (void *)(table_data->data + mcfg_start),
> "MCFG", table_data->len - mcfg_start, 1, NULL, NULL);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: use PCIE_MMCFG_BUS to retrieve end_bus_number
2019-03-12 7:49 [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: use PCIE_MMCFG_BUS to retrieve end_bus_number Wei Yang
2019-03-12 8:26 ` [Qemu-arm] " Auger Eric
2019-03-13 11:48 ` Igor Mammedov
@ 2019-03-14 13:41 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2019-03-14 13:41 UTC (permalink / raw)
To: Wei Yang
Cc: Igor Mammedov, qemu-arm, Michael S. Tsirkin, QEMU Developers,
Shannon Zhao
On Tue, 12 Mar 2019 at 07:51, Wei Yang <richardw.yang@linux.intel.com> wrote:
>
> This is more proper to use PCIE_MMCFG_BUS to retrieve end_bus_number.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
> hw/arm/virt-acpi-build.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index d7e2e4885b..57679a89bf 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -560,8 +560,8 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
> /* Only a single allocation so no need to play with segments */
> mcfg->allocation[0].pci_segment = cpu_to_le16(0);
> mcfg->allocation[0].start_bus_number = 0;
> - mcfg->allocation[0].end_bus_number = (memmap[ecam_id].size
> - / PCIE_MMCFG_SIZE_MIN) - 1;
> + mcfg->allocation[0].end_bus_number =
> + PCIE_MMCFG_BUS(memmap[ecam_id].size - 1);
>
> build_header(linker, table_data, (void *)(table_data->data + mcfg_start),
> "MCFG", table_data->len - mcfg_start, 1, NULL, NULL);
> --
> 2.19.1
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-14 13:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-12 7:49 [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: use PCIE_MMCFG_BUS to retrieve end_bus_number Wei Yang
2019-03-12 8:26 ` [Qemu-arm] " Auger Eric
2019-03-13 11:48 ` Igor Mammedov
2019-03-14 13:41 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.