From: Greg KH <gregkh@linuxfoundation.org>
To: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Cc: outreachy-kernel@googlegroups.com, Julia Lawall <Julia.Lawall@lip6.fr>
Subject: Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: rtw_recv.c: fixed a space indentation issue
Date: Wed, 13 Mar 2019 07:20:08 -0700 [thread overview]
Message-ID: <20190313142008.GC5328@kroah.com> (raw)
In-Reply-To: <CAO-bXGD2WYekE6pT-6DM-4W7ZMWEw6jpk4qLaiRY_nfSzc4RmA@mail.gmail.com>
On Wed, Mar 13, 2019 at 08:39:04AM +0530, Sanjana Sanikommu wrote:
> Subject: [PATCH] Staging: rtl8188eu: rtw_recv.c: fix a tab indent issue
Why is this line in the body of the email? It should be the subject of
the email itself. Using 'git send-email' should do all of that for you
automatically.
>
> Fix a tab issue in 2 lines which removed no extra space before starting
> a line warning. This warning appeared when I compiled checkpatch.pl in
> rtw_recv.c,
>
> Signed-off-by: Sanjana Sanikommu<sanjana99reddy99@gmail.com>
We need a space after your name and before the '<' character.
>
> ---
> drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
> b/drivers/staging/rtl8188eu/core/rtw_recv.c
> index 1d83affc08ce..cc6f1a23da01 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
> @@ -24,11 +24,11 @@ static u8 SNAP_ETH_TYPE_APPLETALK_AARP[2] = {0x80,
> 0xf3};
>
> /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */
> static u8 rtw_bridge_tunnel_header[] = {
> - 0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
> + 0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
> };
All tabs were turned into spaces by your email client, making this patch
impossible to apply. Also it was line-wrapped :(
You can not cut-paste a patch into an email, please use 'git send-email'
to send a patch out properly.
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-13 14:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 19:26 [PATCH] Staging: rtl8188eu: rtw_recv.c: fixed a space indentation issue Sanjana Reddy
2019-03-12 19:29 ` Julia Lawall
2019-03-12 19:41 ` Greg KH
2019-03-12 19:48 ` [Outreachy kernel] " Greg KH
[not found] ` <CAO-bXGBSvngtL5dF+njH3QpLZfme6UWxNkLdS64FETSXQ+cmJg@mail.gmail.com>
2019-03-13 3:09 ` Sanjana Sanikommu
2019-03-13 9:22 ` Sanjana Sanikommu
2019-03-13 9:26 ` Julia Lawall
2019-03-13 14:20 ` Greg KH [this message]
2019-03-13 15:51 ` Sanjana Sanikommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313142008.GC5328@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Julia.Lawall@lip6.fr \
--cc=outreachy-kernel@googlegroups.com \
--cc=sanjana99reddy99@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.