[PATCH] Staging: rtl8188eu: rtw_recv.c: fixed a space indentation issue

[PATCH] Staging: rtl8188eu: rtw_recv.c: fixed a space indentation issue

[Sanjana Reddy]

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

Fixed a space in 2 lines which removed warnings.
Signed-off-by: Sanjana <sanjana99reddy99@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 1d83affc08ce..cc6f1a23da01 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -24,11 +24,11 @@ static u8 SNAP_ETH_TYPE_APPLETALK_AARP[2] = {0x80,
0xf3};

 /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */
 static u8 rtw_bridge_tunnel_header[] = {
-       0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
+        0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
 };

 static u8 rtw_rfc1042_header[] = {
-       0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
+       0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
 };

 static void rtw_signal_stat_timer_hdl(struct timer_list *t);
-- 
2.17.1

[-- Attachment #2: Type: text/html, Size: 1354 bytes --]

Re: [PATCH] Staging: rtl8188eu: rtw_recv.c: fixed a space indentation issue

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]



On Wed, 13 Mar 2019, Sanjana Reddy wrote:

>
> Fixed a space in 2 lines which removed warnings.

What was the fix.  It is pretty obvious that this is correct, but still it
would be good to get in the habit of saying what you actually did.  Are
these converting spaces to tabs?

The log message should be in the imperative, so for your message it would
start with Fix rather than Fixed.

It would also be good to say how you got the warnings.  Checkpatch I
guess?

julia


> Signed-off-by: Sanjana <sanjana99reddy99@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
> b/drivers/staging/rtl8188eu/core/rtw_recv.c
> index 1d83affc08ce..cc6f1a23da01 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
> @@ -24,11 +24,11 @@ static u8 SNAP_ETH_TYPE_APPLETALK_AARP[2] = {0x80,
> 0xf3};
>
>  /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */
>  static u8 rtw_bridge_tunnel_header[] = {
> -       0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
> +        0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
>  };
>
>  static u8 rtw_rfc1042_header[] = {
> -       0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
> +       0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
>  };
>
>  static void rtw_signal_stat_timer_hdl(struct timer_list *t);
> -- 
> 2.17.1
>
>
>

Re: [PATCH] Staging: rtl8188eu: rtw_recv.c: fixed a space indentation issue

[Greg KH]

On Wed, Mar 13, 2019 at 12:56:34AM +0530, Sanjana Reddy wrote:
> Fixed a space in 2 lines which removed warnings.
> Signed-off-by: Sanjana <sanjana99reddy99@gmail.com>

Please put a blank line between the changelog text and your
signed-off-by: line, otherwise the tools will choke :(

I think checkpatch.pl will catch this, did you run it against your
patch?

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: rtw_recv.c: fixed a space indentation issue

[Greg KH]

On Tue, Mar 12, 2019 at 12:41:37PM -0700, Greg KH wrote:
> On Wed, Mar 13, 2019 at 12:56:34AM +0530, Sanjana Reddy wrote:
> > Fixed a space in 2 lines which removed warnings.
> > Signed-off-by: Sanjana <sanjana99reddy99@gmail.com>
> 
> Please put a blank line between the changelog text and your
> signed-off-by: line, otherwise the tools will choke :(

Also we need a "real" name here, not just a first name.  And your email
address should be correct, it's bouncing right now :(

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: rtw_recv.c: fixed a space indentation issue

[Sanjana Sanikommu]

[-- Attachment #1: Type: text/plain, Size: 1965 bytes --]

Subject: [PATCH] Staging: rtl8188eu: rtw_recv.c: fix a tab indent issue

Fix a tab issue in 2 lines which removed no extra space before starting
a line warning. This warning appeared when I compiled checkpatch.pl in
rtw_recv.c,

Signed-off-by: Sanjana Sanikommu<sanjana99reddy99@gmail.com>

---
 drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 1d83affc08ce..cc6f1a23da01 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -24,11 +24,11 @@ static u8 SNAP_ETH_TYPE_APPLETALK_AARP[2] = {0x80,
0xf3};

 /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */
 static u8 rtw_bridge_tunnel_header[] = {
-       0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
+        0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
 };

 static u8 rtw_rfc1042_header[] = {
-       0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
+       0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
 };

 static void rtw_signal_stat_timer_hdl(struct timer_list *t);
-- 
2.17.1


On Wed, Mar 13, 2019 at 8:36 AM Sanjana Sanikommu <
sanjana99reddy99@gmail.com> wrote:

> I reedited the file by taking note of the above mentioned mistakes. I
> would be resending the patch as this has lot of mistakes :)
>
> On Wed, Mar 13, 2019 at 1:18 AM Greg KH <gregkh@linuxfoundation.org>
> wrote:
>
>> On Tue, Mar 12, 2019 at 12:41:37PM -0700, Greg KH wrote:
>> > On Wed, Mar 13, 2019 at 12:56:34AM +0530, Sanjana Reddy wrote:
>> > > Fixed a space in 2 lines which removed warnings.
>> > > Signed-off-by: Sanjana <sanjana99reddy99@gmail.com>
>> >
>> > Please put a blank line between the changelog text and your
>> > signed-off-by: line, otherwise the tools will choke :(
>>
>> Also we need a "real" name here, not just a first name.  And your email
>> address should be correct, it's bouncing right now :(
>>
>> thanks,
>>
>> greg k-h
>>
>

[-- Attachment #2: Type: text/html, Size: 3178 bytes --]

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: rtw_recv.c: fixed a space indentation issue

[Sanjana Sanikommu]

[-- Attachment #1: Type: text/plain, Size: 2278 bytes --]

1.Could you please review this patch and suggest me any changes?

2. How do I know whether this patch is approved or not?

Thanks
Sanjana.


On Wed, 13 Mar 2019, 08:39 Sanjana Sanikommu, <sanjana99reddy99@gmail.com>
wrote:

> Subject: [PATCH] Staging: rtl8188eu: rtw_recv.c: fix a tab indent issue
>
> Fix a tab issue in 2 lines which removed no extra space before starting
> a line warning. This warning appeared when I compiled checkpatch.pl in
> rtw_recv.c,
>
> Signed-off-by: Sanjana Sanikommu<sanjana99reddy99@gmail.com>
>
> ---
>  drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
> b/drivers/staging/rtl8188eu/core/rtw_recv.c
> index 1d83affc08ce..cc6f1a23da01 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
> @@ -24,11 +24,11 @@ static u8 SNAP_ETH_TYPE_APPLETALK_AARP[2] = {0x80,
> 0xf3};
>
>  /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */
>  static u8 rtw_bridge_tunnel_header[] = {
> -       0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
> +        0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
>  };
>
>  static u8 rtw_rfc1042_header[] = {
> -       0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
> +       0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
>  };
>
>  static void rtw_signal_stat_timer_hdl(struct timer_list *t);
> --
> 2.17.1
>
>
> On Wed, Mar 13, 2019 at 8:36 AM Sanjana Sanikommu <
> sanjana99reddy99@gmail.com> wrote:
>
>> I reedited the file by taking note of the above mentioned mistakes. I
>> would be resending the patch as this has lot of mistakes :)
>>
>> On Wed, Mar 13, 2019 at 1:18 AM Greg KH <gregkh@linuxfoundation.org>
>> wrote:
>>
>>> On Tue, Mar 12, 2019 at 12:41:37PM -0700, Greg KH wrote:
>>> > On Wed, Mar 13, 2019 at 12:56:34AM +0530, Sanjana Reddy wrote:
>>> > > Fixed a space in 2 lines which removed warnings.
>>> > > Signed-off-by: Sanjana <sanjana99reddy99@gmail.com>
>>> >
>>> > Please put a blank line between the changelog text and your
>>> > signed-off-by: line, otherwise the tools will choke :(
>>>
>>> Also we need a "real" name here, not just a first name.  And your email
>>> address should be correct, it's bouncing right now :(
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>

[-- Attachment #2: Type: text/html, Size: 3947 bytes --]

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: rtw_recv.c: fixed a space indentation issue

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 3178 bytes --]



On Wed, 13 Mar 2019, Sanjana Sanikommu wrote:

> 1.Could you please review this patch and suggest me any changes? 
> 2. How do I know whether this patch is approved or not?

You need to just wait until someone has time to look at it.  Greg will
decide if it is ultimately approved, but he is travelling this week
(announced before you joined the group).  You can work on something else
in the meantime.

julia

>  
> Thanks 
> Sanjana.
>
>
> On Wed, 13 Mar 2019, 08:39 Sanjana Sanikommu, <sanjana99reddy99@gmail.com> wrote:
>       Subject: [PATCH] Staging: rtl8188eu: rtw_recv.c: fix a tab indent issue
>
> Fix a tab issue in 2 lines which removed no extra space before starting
> a line warning. This warning appeared when I compiled checkpatch.pl in
> rtw_recv.c,
>
> Signed-off-by: Sanjana Sanikommu<sanjana99reddy99@gmail.com>
>
> ---
>  drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/core/rtw_recv.c
> index 1d83affc08ce..cc6f1a23da01 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
> @@ -24,11 +24,11 @@ static u8 SNAP_ETH_TYPE_APPLETALK_AARP[2] = {0x80, 0xf3};
>
>  /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */
>  static u8 rtw_bridge_tunnel_header[] = {
> -       0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
> +        0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
>  };
>
>  static u8 rtw_rfc1042_header[] = {
> -       0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
> +       0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
>  };
>
>  static void rtw_signal_stat_timer_hdl(struct timer_list *t);
> -- 
> 2.17.1
>
>
> On Wed, Mar 13, 2019 at 8:36 AM Sanjana Sanikommu <sanjana99reddy99@gmail.com> wrote:
>       I reedited the file by taking note of the above mentioned mistakes. I would be resending the patch as this has lot of mistakes :) 
>
> On Wed, Mar 13, 2019 at 1:18 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>       On Tue, Mar 12, 2019 at 12:41:37PM -0700, Greg KH wrote:
>       > On Wed, Mar 13, 2019 at 12:56:34AM +0530, Sanjana Reddy wrote:
>       > > Fixed a space in 2 lines which removed warnings.
>       > > Signed-off-by: Sanjana <sanjana99reddy99@gmail.com>
>       >
>       > Please put a blank line between the changelog text and your
>       > signed-off-by: line, otherwise the tools will choke :(
>
>       Also we need a "real" name here, not just a first name.  And your email
>       address should be correct, it's bouncing right now :(
>
>       thanks,
>
>       greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAO-bXGAZXP2zCUKymYTWG5_ijtsbGqyi6j4LVx3vHr7Qs7kxqw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: rtw_recv.c: fixed a space indentation issue

[Greg KH]

On Wed, Mar 13, 2019 at 08:39:04AM +0530, Sanjana Sanikommu wrote:
> Subject: [PATCH] Staging: rtl8188eu: rtw_recv.c: fix a tab indent issue

Why is this line in the body of the email?  It should be the subject of
the email itself.  Using 'git send-email' should do all of that for you
automatically.

> 
> Fix a tab issue in 2 lines which removed no extra space before starting
> a line warning. This warning appeared when I compiled checkpatch.pl in
> rtw_recv.c,
> 
> Signed-off-by: Sanjana Sanikommu<sanjana99reddy99@gmail.com>

We need a space after your name and before the '<' character.

> 
> ---
>  drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
> b/drivers/staging/rtl8188eu/core/rtw_recv.c
> index 1d83affc08ce..cc6f1a23da01 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
> @@ -24,11 +24,11 @@ static u8 SNAP_ETH_TYPE_APPLETALK_AARP[2] = {0x80,
> 0xf3};
> 
>  /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */
>  static u8 rtw_bridge_tunnel_header[] = {
> -       0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
> +        0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
>  };

All tabs were turned into spaces by your email client, making this patch
impossible to apply.  Also it was line-wrapped :(

You can not cut-paste a patch into an email, please use 'git send-email'
to send a patch out properly.

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: rtw_recv.c: fixed a space indentation issue

[Sanjana Sanikommu]

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

Please...ignore this patch. I have resend the patch using mutt...kindly do
consider that patch which I sent and suggest me the changes...:)

Thanks
Sanjana

On Wed, 13 Mar 2019, 19:50 Greg KH, <gregkh@linuxfoundation.org> wrote:

> On Wed, Mar 13, 2019 at 08:39:04AM +0530, Sanjana Sanikommu wrote:
> > Subject: [PATCH] Staging: rtl8188eu: rtw_recv.c: fix a tab indent issue
>
> Why is this line in the body of the email?  It should be the subject of
> the email itself.  Using 'git send-email' should do all of that for you
> automatically.
>
> >
> > Fix a tab issue in 2 lines which removed no extra space before starting
> > a line warning. This warning appeared when I compiled checkpatch.pl in
> > rtw_recv.c,
> >
> > Signed-off-by: Sanjana Sanikommu<sanjana99reddy99@gmail.com>
>
> We need a space after your name and before the '<' character.
>
> >
> > ---
> >  drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
> > b/drivers/staging/rtl8188eu/core/rtw_recv.c
> > index 1d83affc08ce..cc6f1a23da01 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> > +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
> > @@ -24,11 +24,11 @@ static u8 SNAP_ETH_TYPE_APPLETALK_AARP[2] = {0x80,
> > 0xf3};
> >
> >  /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */
> >  static u8 rtw_bridge_tunnel_header[] = {
> > -       0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
> > +        0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8
> >  };
>
> All tabs were turned into spaces by your email client, making this patch
> impossible to apply.  Also it was line-wrapped :(
>
> You can not cut-paste a patch into an email, please use 'git send-email'
> to send a patch out properly.
>
> thanks,
>
> greg k-h
>

[-- Attachment #2: Type: text/html, Size: 2574 bytes --]