* [PATCH] staging: speakup: Remove unused variable. @ 2019-03-13 18:23 Bhagyashri Dighole 2019-03-13 19:31 ` Greg Kroah-Hartman 2019-03-13 19:32 ` [Outreachy kernel] " Julia Lawall 0 siblings, 2 replies; 5+ messages in thread From: Bhagyashri Dighole @ 2019-03-13 18:23 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Outreachy Remove unused variable which is used to store return value, Detected by Coccinelle semantic patch ret.cocci. Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com> --- drivers/staging/speakup/i18n.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c index ee240d3..a748eb8 100644 --- a/drivers/staging/speakup/i18n.c +++ b/drivers/staging/speakup/i18n.c @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input) input++; /* Advance over %. */ input = skip_flags(input); input = skip_width(input); - input = skip_conversion(input); - return input; + return skip_conversion(input); } /* -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: speakup: Remove unused variable. 2019-03-13 18:23 [PATCH] staging: speakup: Remove unused variable Bhagyashri Dighole @ 2019-03-13 19:31 ` Greg Kroah-Hartman 2019-03-14 5:33 ` Bhagyashri Dighole 2019-03-13 19:32 ` [Outreachy kernel] " Julia Lawall 1 sibling, 1 reply; 5+ messages in thread From: Greg Kroah-Hartman @ 2019-03-13 19:31 UTC (permalink / raw) To: Bhagyashri Dighole; +Cc: Outreachy On Wed, Mar 13, 2019 at 11:53:15PM +0530, Bhagyashri Dighole wrote: > Remove unused variable which is used to store return value, > Detected by Coccinelle semantic patch ret.cocci. > > Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com> > --- > drivers/staging/speakup/i18n.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c > index ee240d3..a748eb8 100644 > --- a/drivers/staging/speakup/i18n.c > +++ b/drivers/staging/speakup/i18n.c > @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input) > input++; /* Advance over %. */ > input = skip_flags(input); > input = skip_width(input); > - input = skip_conversion(input); > - return input; > + return skip_conversion(input); This same patch just got rejected a few days ago :( Please see the mailing list for the details. greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: speakup: Remove unused variable. 2019-03-13 19:31 ` Greg Kroah-Hartman @ 2019-03-14 5:33 ` Bhagyashri Dighole 0 siblings, 0 replies; 5+ messages in thread From: Bhagyashri Dighole @ 2019-03-14 5:33 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Outreachy [-- Attachment #1: Type: text/plain, Size: 1116 bytes --] On Thu, Mar 14, 2019 at 1:01 AM Greg Kroah-Hartman < gregkh@linuxfoundation.org> wrote: > On Wed, Mar 13, 2019 at 11:53:15PM +0530, Bhagyashri Dighole wrote: > > Remove unused variable which is used to store return value, > > Detected by Coccinelle semantic patch ret.cocci. > > > > Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com> > > --- > > drivers/staging/speakup/i18n.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/staging/speakup/i18n.c > b/drivers/staging/speakup/i18n.c > > index ee240d3..a748eb8 100644 > > --- a/drivers/staging/speakup/i18n.c > > +++ b/drivers/staging/speakup/i18n.c > > @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input) > > input++; /* Advance over %. */ > > input = skip_flags(input); > > input = skip_width(input); > > - input = skip_conversion(input); > > - return input; > > + return skip_conversion(input); > > This same patch just got rejected a few days ago :( > > Please see the mailing list for the details. > I will check the mailing list. > > greg k-h > [-- Attachment #2: Type: text/html, Size: 1767 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: speakup: Remove unused variable. 2019-03-13 18:23 [PATCH] staging: speakup: Remove unused variable Bhagyashri Dighole 2019-03-13 19:31 ` Greg Kroah-Hartman @ 2019-03-13 19:32 ` Julia Lawall 2019-03-14 5:37 ` Bhagyashri Dighole 1 sibling, 1 reply; 5+ messages in thread From: Julia Lawall @ 2019-03-13 19:32 UTC (permalink / raw) To: Bhagyashri Dighole; +Cc: Greg Kroah-Hartman, Outreachy On Wed, 13 Mar 2019, Bhagyashri Dighole wrote: > Remove unused variable which is used to store return value, > Detected by Coccinelle semantic patch ret.cocci. > > Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com> > --- > drivers/staging/speakup/i18n.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c > index ee240d3..a748eb8 100644 > --- a/drivers/staging/speakup/i18n.c > +++ b/drivers/staging/speakup/i18n.c > @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input) > input++; /* Advance over %. */ > input = skip_flags(input); > input = skip_width(input); > - input = skip_conversion(input); > - return input; > + return skip_conversion(input); The maintainer already said that he preferred this one left as is, because he liked the input = input = input = pattern. julia > } > > /* > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1552501395-12308-1-git-send-email-digholebhagyashri%40gmail.com. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: speakup: Remove unused variable. 2019-03-13 19:32 ` [Outreachy kernel] " Julia Lawall @ 2019-03-14 5:37 ` Bhagyashri Dighole 0 siblings, 0 replies; 5+ messages in thread From: Bhagyashri Dighole @ 2019-03-14 5:37 UTC (permalink / raw) To: Julia Lawall; +Cc: Greg Kroah-Hartman, Outreachy [-- Attachment #1: Type: text/plain, Size: 2263 bytes --] On Thu, Mar 14, 2019 at 1:02 AM Julia Lawall <julia.lawall@lip6.fr> wrote: > > > On Wed, 13 Mar 2019, Bhagyashri Dighole wrote: > > > Remove unused variable which is used to store return value, > > Detected by Coccinelle semantic patch ret.cocci. > > > > Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com> > > --- > > drivers/staging/speakup/i18n.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/staging/speakup/i18n.c > b/drivers/staging/speakup/i18n.c > > index ee240d3..a748eb8 100644 > > --- a/drivers/staging/speakup/i18n.c > > +++ b/drivers/staging/speakup/i18n.c > > @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input) > > input++; /* Advance over %. */ > > input = skip_flags(input); > > input = skip_width(input); > > - input = skip_conversion(input); > > - return input; > > + return skip_conversion(input); > > The maintainer already said that he preferred this one left as is, because > he liked the input = input = input = pattern. > Yes, I will consider this scenario for next time :). Thanks > julia > > > } > > > > /* > > -- > > 2.7.4 > > > > -- > > You received this message because you are subscribed to the Google > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/1552501395-12308-1-git-send-email-digholebhagyashri%40gmail.com > . > > For more options, visit https://groups.google.com/d/optout. > > > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1903132031440.2515%40hadrien > . > For more options, visit https://groups.google.com/d/optout. > [-- Attachment #2: Type: text/html, Size: 3904 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-14 5:38 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-03-13 18:23 [PATCH] staging: speakup: Remove unused variable Bhagyashri Dighole 2019-03-13 19:31 ` Greg Kroah-Hartman 2019-03-14 5:33 ` Bhagyashri Dighole 2019-03-13 19:32 ` [Outreachy kernel] " Julia Lawall 2019-03-14 5:37 ` Bhagyashri Dighole
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.