From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v4 0/3] drm/i915: introduce macros to define register contents
Date: Fri, 15 Mar 2019 15:58:10 -0700 [thread overview]
Message-ID: <20190315225810.GB1167@intel.com> (raw)
In-Reply-To: <cover.1552657998.git.jani.nikula@intel.com>
On Fri, Mar 15, 2019 at 03:56:17PM +0200, Jani Nikula wrote:
> v4 of [1], rebased and very mildly tweaked, with the intention to merge.
before it starts conflicting again :)
> I added
> Chris' Reviewed-bys despite the rebase.
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Do you intend to follow-up with a big sed or coccinelle?
and document that we should prefer REG_BIT?
>
> BR,
> Jani.
>
>
> [1] http://mid.mail-archive.com/cover.1551286447.git.jani.nikula@intel.com
>
>
> Jani Nikula (3):
> drm/i915: introduce REG_BIT() and REG_GENMASK() to define register
> contents
> drm/i915: deprecate _SHIFT in favor of _MASK passed to accessors
> drm/i915: use REG_FIELD_PREP() to define register bitfield values
>
> drivers/gpu/drm/i915/i915_reg.h | 182 +++++++++++++++++++-----------
> drivers/gpu/drm/i915/intel_dp.c | 42 +++----
> drivers/gpu/drm/i915/intel_lvds.c | 42 ++++---
> 3 files changed, 150 insertions(+), 116 deletions(-)
>
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-15 22:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 13:56 [PATCH v4 0/3] drm/i915: introduce macros to define register contents Jani Nikula
2019-03-15 13:56 ` [PATCH v4 1/3] drm/i915: introduce REG_BIT() and REG_GENMASK() " Jani Nikula
2019-03-15 13:56 ` [PATCH v4 2/3] drm/i915: deprecate _SHIFT in favor of _MASK passed to accessors Jani Nikula
2019-03-15 13:56 ` [PATCH v4 3/3] drm/i915: use REG_FIELD_PREP() to define register bitfield values Jani Nikula
2019-03-15 15:10 ` ✓ Fi.CI.BAT: success for drm/i915: introduce macros to define register contents (rev4) Patchwork
2019-03-15 17:01 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-15 22:58 ` Rodrigo Vivi [this message]
2019-03-18 14:57 ` [PATCH v4 0/3] drm/i915: introduce macros to define register contents Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315225810.GB1167@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.