Re: [PATCH v4 0/3] drm/i915: introduce macros to define register contents

[Jani Nikula <jani.nikula@intel.com>]

On Fri, 15 Mar 2019, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Fri, Mar 15, 2019 at 03:56:17PM +0200, Jani Nikula wrote:
>> v4 of [1], rebased and very mildly tweaked, with the intention to merge.
>
> before it starts conflicting again :)
>
>> I added
>> Chris' Reviewed-bys despite the rebase.
>
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Thanks, pushed.

> Do you intend to follow-up with a big sed or coccinelle?
> and document that we should prefer REG_BIT?

It's already documented in i915_reg.h. I'm not keen on disrupting
everything with the mass changes.

BR,
Jani.



>
>
>> 
>> BR,
>> Jani.
>> 
>> 
>> [1] http://mid.mail-archive.com/cover.1551286447.git.jani.nikula@intel.com
>> 
>> 
>> Jani Nikula (3):
>>   drm/i915: introduce REG_BIT() and REG_GENMASK() to define register
>>     contents
>>   drm/i915: deprecate _SHIFT in favor of _MASK passed to accessors
>>   drm/i915: use REG_FIELD_PREP() to define register bitfield values
>> 
>>  drivers/gpu/drm/i915/i915_reg.h   | 182 +++++++++++++++++++-----------
>>  drivers/gpu/drm/i915/intel_dp.c   |  42 +++----
>>  drivers/gpu/drm/i915/intel_lvds.c |  42 ++++---
>>  3 files changed, 150 insertions(+), 116 deletions(-)
>> 
>> -- 
>> 2.20.1
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx