* [PATCH] Staging: gasket: Replace symbolic permissions with octal permissions
@ 2019-03-01 8:12 Wentao Cai
2019-03-01 8:19 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Wentao Cai @ 2019-03-01 8:12 UTC (permalink / raw)
To: Rob Springer, Todd Poynor, Ben Chan, Greg Kroah-Hartman
Cc: outreachy-kernel, Wentao Cai
This patch fixes the checkpatch.pl warning:
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
Signed-off-by: Wentao Cai <etsai042@gmail.com>
---
drivers/staging/gasket/gasket_sysfs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h
index 151e8edd28ea..708ee43175ba 100644
--- a/drivers/staging/gasket/gasket_sysfs.h
+++ b/drivers/staging/gasket/gasket_sysfs.h
@@ -40,7 +40,7 @@
*/
#define GASKET_END_OF_ATTR_ARRAY \
{ \
- .attr = __ATTR(GASKET_ARRAY_END_TOKEN, S_IRUGO, NULL, NULL), \
+ .attr = __ATTR(GASKET_ARRAY_END_TOKEN, 0444, NULL, NULL), \
.data.attr_type = 0, \
}
@@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
#define GASKET_SYSFS_RO(_name, _show_function, _attr_type) \
{ \
- .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \
+ .attr = __ATTR(_name, 0444, _show_function, NULL), \
.data.attr_type = _attr_type \
}
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Staging: gasket: Replace symbolic permissions with octal permissions
2019-03-01 8:12 [PATCH] Staging: gasket: Replace symbolic permissions with octal permissions Wentao Cai
@ 2019-03-01 8:19 ` Greg Kroah-Hartman
2019-03-01 9:25 ` etsai042
2019-03-13 8:50 ` Wentao Cai
0 siblings, 2 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2019-03-01 8:19 UTC (permalink / raw)
To: Wentao Cai; +Cc: Rob Springer, Todd Poynor, Ben Chan, outreachy-kernel
On Fri, Mar 01, 2019 at 04:12:38PM +0800, Wentao Cai wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
>
> Signed-off-by: Wentao Cai <etsai042@gmail.com>
> ---
> drivers/staging/gasket/gasket_sysfs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h
> index 151e8edd28ea..708ee43175ba 100644
> --- a/drivers/staging/gasket/gasket_sysfs.h
> +++ b/drivers/staging/gasket/gasket_sysfs.h
> @@ -40,7 +40,7 @@
> */
> #define GASKET_END_OF_ATTR_ARRAY \
> { \
> - .attr = __ATTR(GASKET_ARRAY_END_TOKEN, S_IRUGO, NULL, NULL), \
> + .attr = __ATTR(GASKET_ARRAY_END_TOKEN, 0444, NULL, NULL), \
This is fun, it keeps coming up and no one looks in the archives to see
why I keep rejecting it :)
This should be __ATTR_NULL(), but really, the whole macro can be deleted.
> .data.attr_type = 0, \
> }
>
> @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
>
> #define GASKET_SYSFS_RO(_name, _show_function, _attr_type) \
> { \
> - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \
> + .attr = __ATTR(_name, 0444, _show_function, NULL), \
__ATTR_RO() please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Staging: gasket: Replace symbolic permissions with octal permissions
2019-03-01 8:19 ` Greg Kroah-Hartman
@ 2019-03-01 9:25 ` etsai042
2019-03-13 8:50 ` Wentao Cai
1 sibling, 0 replies; 5+ messages in thread
From: etsai042 @ 2019-03-01 9:25 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 2042 bytes --]
Sorry Greg, I'll check the archive first next time, before I send my
patches.
Wentao Cai
在 2019年3月1日星期五 UTC+8下午4:19:07，gregkh写道：
>
> On Fri, Mar 01, 2019 at 04:12:38PM +0800, Wentao Cai wrote:
> > This patch fixes the checkpatch.pl warning:
> > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
> using octal permissions '0444'.
> >
> > Signed-off-by: Wentao Cai <etsa...@gmail.com <javascript:>>
> > ---
> > drivers/staging/gasket/gasket_sysfs.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/gasket/gasket_sysfs.h
> b/drivers/staging/gasket/gasket_sysfs.h
> > index 151e8edd28ea..708ee43175ba 100644
> > --- a/drivers/staging/gasket/gasket_sysfs.h
> > +++ b/drivers/staging/gasket/gasket_sysfs.h
> > @@ -40,7 +40,7 @@
> > */
> > #define GASKET_END_OF_ATTR_ARRAY
> \
> > {
> \
> > - .attr = __ATTR(GASKET_ARRAY_END_TOKEN, S_IRUGO, NULL,
> NULL), \
> > + .attr = __ATTR(GASKET_ARRAY_END_TOKEN, 0444, NULL,
> NULL), \
>
> This is fun, it keeps coming up and no one looks in the archives to see
> why I keep rejecting it :)
>
> This should be __ATTR_NULL(), but really, the whole macro can be deleted.
>
> > .data.attr_type = 0,
> \
> > }
> >
> > @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
> >
> > #define GASKET_SYSFS_RO(_name, _show_function, _attr_type)
> \
> > {
> \
> > - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL),
> \
> > + .attr = __ATTR(_name, 0444, _show_function, NULL),
> \
>
> __ATTR_RO() please.
>
> thanks,
>
> greg k-h
>
[-- Attachment #1.2: Type: text/html, Size: 3213 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Staging: gasket: Replace symbolic permissions with octal permissions
2019-03-01 8:19 ` Greg Kroah-Hartman
2019-03-01 9:25 ` etsai042
@ 2019-03-13 8:50 ` Wentao Cai
2019-03-17 10:12 ` [Outreachy kernel] " Greg KH
1 sibling, 1 reply; 5+ messages in thread
From: Wentao Cai @ 2019-03-13 8:50 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1538 bytes --]
On Friday, March 1, 2019 at 12:19:07 AM UTC-8, gregkh wrote:
>
>
> This is fun, it keeps coming up and no one looks in the archives to see
> why I keep rejecting it :)
>
> This should be __ATTR_NULL(), but really, the whole macro can be deleted.
>
> > .data.attr_type = 0,
> \
> > }
> >
> > @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
> >
> > #define GASKET_SYSFS_RO(_name, _show_function, _attr_type)
> \
> > {
> \
> > - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL),
> \
> > + .attr = __ATTR(_name, 0444, _show_function, NULL),
> \
>
> __ATTR_RO() please.
>
> Hi. I just submit a patch to fix the first __ATTR_NULL, but I have some
question about the latter one.
I understand it is better to use read only attribute here, but by changing
__ATTR to __ATTR_RO, since the new macro does not need the _show_function
parameter:
> (linux/sysfs.h, line 115)
> #define __ATTR_RO(_name) { \
> .attr = { .name = __stringify(_name), .mode = 0444 }, \
> .show = _name##_show, \
> }
it seems to me that the second parameter in this macro should be deleted,
which means all other file which calls this macro should be revise.
I think it's a big code change, and don't know whether it's suitable to do
this. Could you give me some advice?
Thanks,
Wentao
> thanks,
>
> greg k-h
>
[-- Attachment #1.2: Type: text/html, Size: 2579 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Outreachy kernel] Re: [PATCH] Staging: gasket: Replace symbolic permissions with octal permissions
2019-03-13 8:50 ` Wentao Cai
@ 2019-03-17 10:12 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2019-03-17 10:12 UTC (permalink / raw)
To: Wentao Cai; +Cc: outreachy-kernel
On Wed, Mar 13, 2019 at 01:50:33AM -0700, Wentao Cai wrote:
>
>
> On Friday, March 1, 2019 at 12:19:07 AM UTC-8, gregkh wrote:
> >
> >
> > This is fun, it keeps coming up and no one looks in the archives to see
> > why I keep rejecting it :)
> >
> > This should be __ATTR_NULL(), but really, the whole macro can be deleted.
> >
> > > .data.attr_type = 0,
> > \
> > > }
> > >
> > > @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
> > >
> > > #define GASKET_SYSFS_RO(_name, _show_function, _attr_type)
> > \
> > > {
> > \
> > > - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL),
> > \
> > > + .attr = __ATTR(_name, 0444, _show_function, NULL),
> > \
> >
> > __ATTR_RO() please.
> >
> > Hi. I just submit a patch to fix the first __ATTR_NULL, but I have some
> question about the latter one.
> I understand it is better to use read only attribute here, but by changing
> __ATTR to __ATTR_RO, since the new macro does not need the _show_function
> parameter:
>
> > (linux/sysfs.h, line 115)
> > #define __ATTR_RO(_name) { \
> > .attr = { .name = __stringify(_name), .mode = 0444 }, \
> > .show = _name##_show, \
> > }
>
> it seems to me that the second parameter in this macro should be deleted,
> which means all other file which calls this macro should be revise.
> I think it's a big code change, and don't know whether it's suitable to do
> this. Could you give me some advice?
Yes, it is a big code change, and if you are not comfortable with it, I
would not recommend it at this point in time.
This is also why no one has done it yet :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-17 10:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-01 8:12 [PATCH] Staging: gasket: Replace symbolic permissions with octal permissions Wentao Cai
2019-03-01 8:19 ` Greg Kroah-Hartman
2019-03-01 9:25 ` etsai042
2019-03-13 8:50 ` Wentao Cai
2019-03-17 10:12 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.