[PATCH] Staging: gasket: Create a new variable to improve readability

[PATCH] Staging: gasket: Create a new variable to improve readability

[anushkacharu9]

From: Anushka Shukla <anushkacharu9@gmail.com>

- Define a new variable temp_table.
- Modify it to maintain Linux Kernel Coding style.

Signed-off-by: Anushka Shukla <anushkacharu9@gmail.com>
---
 drivers/staging/gasket/apex_driver.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c
index 7c2ffa467557..d0fffb51c9c4 100644
--- a/drivers/staging/gasket/apex_driver.c
+++ b/drivers/staging/gasket/apex_driver.c
@@ -526,21 +526,22 @@ static ssize_t sysfs_show(struct device *device, struct device_attribute *attr,
 	}
 
 	type = (enum sysfs_attribute_type)gasket_attr->data.attr_type;
+	struct gasket_page_table *temp_table = gasket_dev->page_table[0]
 	switch (type) {
 	case ATTR_KERNEL_HIB_PAGE_TABLE_SIZE:
 		ret = scnprintf(buf, PAGE_SIZE, "%u\n",
-				gasket_page_table_num_entries
-				       (gasket_dev->page_table[0]));
+				gasket_page_table_num_entries(temp_table);
+				       
 		break;
 	case ATTR_KERNEL_HIB_SIMPLE_PAGE_TABLE_SIZE:
 		ret = scnprintf(buf, PAGE_SIZE, "%u\n",
-				gasket_page_table_num_entries
-				       (gasket_dev->page_table[0]));
+				gasket_page_table_num_entries(temp_table);
+				       
 		break;
 	case ATTR_KERNEL_HIB_NUM_ACTIVE_PAGES:
 		ret = scnprintf(buf, PAGE_SIZE, "%u\n",
-				gasket_page_table_num_active_pages
-				       (gasket_dev->page_table[0]));
+				gasket_page_table_num_active_pages(temp_table);
+				       
 		break;
 	default:
 		dev_dbg(gasket_dev->dev, "Unknown attribute: %s\n",
-- 
2.17.1

Re: [Outreachy kernel] [PATCH] Staging: gasket: Create a new variable to improve readability

[Greg KH]

On Sun, Mar 17, 2019 at 01:24:27AM +0530, anushkacharu9@gmail.com wrote:
> From: Anushka Shukla <anushkacharu9@gmail.com>
> 
> - Define a new variable temp_table.
> - Modify it to maintain Linux Kernel Coding style.

What is "it" here?

> 
> Signed-off-by: Anushka Shukla <anushkacharu9@gmail.com>
> ---
>  drivers/staging/gasket/apex_driver.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c
> index 7c2ffa467557..d0fffb51c9c4 100644
> --- a/drivers/staging/gasket/apex_driver.c
> +++ b/drivers/staging/gasket/apex_driver.c
> @@ -526,21 +526,22 @@ static ssize_t sysfs_show(struct device *device, struct device_attribute *attr,
>  	}
>  
>  	type = (enum sysfs_attribute_type)gasket_attr->data.attr_type;
> +	struct gasket_page_table *temp_table = gasket_dev->page_table[0]

Did you build this code?  The compiler should have complained a lot
about this :(

>  	switch (type) {
>  	case ATTR_KERNEL_HIB_PAGE_TABLE_SIZE:
>  		ret = scnprintf(buf, PAGE_SIZE, "%u\n",
> -				gasket_page_table_num_entries
> -				       (gasket_dev->page_table[0]));
> +				gasket_page_table_num_entries(temp_table);
> +				       

Always run your patches through checkpatch.pl before sending them out,
so that a maintainer does not have to tell you to run them through
checkpatch.pl :)

thanks,

greg k-h