From: Greg KH <gregkh@linuxfoundation.org>
To: Branden Bonaby <brandonbonaby94@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2] staging: rts5208: Lines should not end with a '('
Date: Sun, 17 Mar 2019 11:47:44 +0100 [thread overview]
Message-ID: <20190317104744.GD16257@kroah.com> (raw)
In-Reply-To: <20190314152828.25859-1-brandonbonaby94@gmail.com>
On Thu, Mar 14, 2019 at 11:28:28AM -0400, Branden Bonaby wrote:
> Start function arguments after initial bracket so that the
> line does not end with a opening bracket.
> CHECK: Lines should not end with a '('
>
> Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
> ---
> Changes in v2:
> Moved function arguments that do not go over the
> 80 character a line limit, to the same line as the
> function name.
>
> drivers/staging/rts5208/rtsx_transport.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
> index 8277d7895608..a476e22767e9 100644
> --- a/drivers/staging/rts5208/rtsx_transport.c
> +++ b/drivers/staging/rts5208/rtsx_transport.c
> @@ -257,8 +257,9 @@ int rtsx_send_cmd(struct rtsx_chip *chip, u8 card, int timeout)
> spin_unlock_irq(&rtsx->reg_lock);
>
> /* Wait for TRANS_OK_INT */
> - timeleft = wait_for_completion_interruptible_timeout(
> - &trans_done, msecs_to_jiffies(timeout));
> + timeleft =
> + wait_for_completion_interruptible_timeout(&trans_done,
Indenting 4 spaces is not acceptable coding style, sorry.
greg k-h
prev parent reply other threads:[~2019-03-17 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 15:00 [PATCH] staging: rts5208: Lines should not end with a '(' Branden Bonaby
2019-03-14 15:03 ` [Outreachy kernel] " Julia Lawall
2019-03-14 15:28 ` [PATCH v2] " Branden Bonaby
2019-03-17 10:47 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190317104744.GD16257@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=brandonbonaby94@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.